[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 123884: Make sure the desktop folderview doesn't overlap with panels.
From: "Kai Uwe Broulik" <kde () privat ! broulik ! de>
Date: 2015-05-23 17:40:36
Message-ID: 20150523174036.17018.66173 () mimi ! kde ! org
[Download RAW message or body]
--===============4545616135349414894==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123884/#review80752
-----------------------------------------------------------
containments/desktop/package/contents/ui/main.qml (lines 238 - 241)
<https://git.reviewboard.kde.org/r/123884/#comment55365>
Can't you just use bindings for that?
anchors {
leftMargin: plasmoid.availableScreenRect.x
…
}
containments/desktop/package/contents/ui/main.qml (line 239)
<https://git.reviewboard.kde.org/r/123884/#comment55366>
That doesn't look right, I think you need to subract the x value as well
- Kai Uwe Broulik
On Mai 23, 2015, 5:14 nachm., Yoann Laissus wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123884/
> -----------------------------------------------------------
>
> (Updated Mai 23, 2015, 5:14 nachm.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-desktop
>
>
> Description
> -------
>
> Currently, when the desktop is configured with "Folder view" mode, it uses the \
> whole screen, no matter if there are panels in the area. This patch resizes the \
> folder view to the available space to avoid overlaps with panels.
>
> Diffs
> -----
>
> containments/desktop/package/contents/ui/main.qml \
> c546236abf6376963180ffec648d412bcd6e40db
> Diff: https://git.reviewboard.kde.org/r/123884/diff/
>
>
> Testing
> -------
>
> Tested with panels on each screen side
>
>
> File Attachments
> ----------------
>
> Without the patch
> https://git.reviewboard.kde.org/media/uploaded/files/2015/05/23/0572c44b-1f06-46ab-86ad-9aa626c0dc2b__with_overlap.jpg
> With the patch
> https://git.reviewboard.kde.org/media/uploaded/files/2015/05/23/8e137ad4-6a6d-4a9c-b9b9-3b9bd7bf05ec__without_overlap.jpg
>
>
> Thanks,
>
> Yoann Laissus
>
>
--===============4545616135349414894==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123884/">https://git.reviewboard.kde.org/r/123884/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/123884/diff/1/?file=370557#file370557line238" \
style="color: black; font-weight: bold; text-decoration: \
underline;">containments/desktop/package/contents/ui/main.qml</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">238</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="nx">folderViewLayer</span><span class="p">.</span><span \
class="nx">anchors</span><span class="p">.</span><span class="nx">leftMargin</span> \
<span class="o">=</span> <span class="nx">plasmoid</span><span \
class="p">.</span><span class="nx">availableScreenRect</span><span \
class="p">.</span><span class="nx">x</span><span class="p">;</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">239</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="nx">folderViewLayer</span><span class="p">.</span><span \
class="nx">anchors</span><span class="p">.</span><span class="nx">rightMargin</span> \
<span class="o">=</span> <span class="nx">root</span><span class="p">.</span><span \
class="nx">width</span> <span class="o">-</span> <span \
class="nx">plasmoid</span><span class="p">.</span><span \
class="nx">availableScreenRect</span><span class="p">.</span><span \
class="nx">width</span><span class="p">;</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">240</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="nx">folderViewLayer</span><span class="p">.</span><span \
class="nx">anchors</span><span class="p">.</span><span class="nx">bottomMargin</span> \
<span class="o">=</span> <span class="nx">root</span><span class="p">.</span><span \
class="nx">height</span> <span class="o">-</span> <span \
class="nx">plasmoid</span><span class="p">.</span><span \
class="nx">availableScreenRect</span><span class="p">.</span><span \
class="nx">height</span><span class="p">;</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">241</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="nx">folderViewLayer</span><span class="p">.</span><span \
class="nx">anchors</span><span class="p">.</span><span class="nx">topMargin</span> \
<span class="o">=</span> <span class="nx">plasmoid</span><span \
class="p">.</span><span class="nx">availableScreenRect</span><span \
class="p">.</span><span class="nx">y</span><span class="p">;</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Can't \
you just use bindings for that?</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">anchors { leftMargin: \
plasmoid.availableScreenRect.x …
}</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/123884/diff/1/?file=370557#file370557line239" \
style="color: black; font-weight: bold; text-decoration: \
underline;">containments/desktop/package/contents/ui/main.qml</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">239</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="nx">folderViewLayer</span><span class="p">.</span><span \
class="nx">anchors</span><span class="p">.</span><span class="nx">rightMargin</span> \
<span class="o">=</span> <span class="nx">root</span><span class="p">.</span><span \
class="nx">width</span> <span class="o">-</span> <span \
class="nx">plasmoid</span><span class="p">.</span><span \
class="nx">availableScreenRect</span><span class="p">.</span><span \
class="nx">width</span><span class="p">;</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">That \
doesn't look right, I think you need to subract the x value as well</p></pre> </div>
</div>
<br />
<p>- Kai Uwe Broulik</p>
<br />
<p>On Mai 23rd, 2015, 5:14 nachm. UTC, Yoann Laissus wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Yoann Laissus.</div>
<p style="color: grey;"><i>Updated Mai 23, 2015, 5:14 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Currently, when the desktop is configured with "Folder \
view" mode, it uses the whole screen, no matter if there are panels in the area. This \
patch resizes the folder view to the available space to avoid overlaps with \
panels.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Tested with panels on each screen side</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>containments/desktop/package/contents/ui/main.qml <span style="color: \
grey">(c546236abf6376963180ffec648d412bcd6e40db)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123884/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/05/23/0572c44b-1f06-46ab-86ad-9aa626c0dc2b__with_overlap.jpg">Without \
the patch</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/05/23/8e137ad4-6a6d-4a9c-b9b9-3b9bd7bf05ec__without_overlap.jpg">With \
the patch</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4545616135349414894==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic