[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 123877: [digital-clock] Bring back font family and color options
From: "Kai Uwe Broulik" <kde () privat ! broulik ! de>
Date: 2015-05-22 5:49:03
Message-ID: 20150522054903.11005.6564 () mimi ! kde ! org
[Download RAW message or body]
--===============0403502921564176233==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Mai 22, 2015, 2:14 vorm., Andrew Lake wrote:
> > Just a couple observations:
> > 1. I think it might be helpful to have a way to restore using the default font \
> > specified in the fonts kcm without having to explicitly know/set the font to \
> > match the default. A checkbox to enable/disable setting a custom font family as \
> > is done for the color might work. 2. "Font style" in the fonts kcm refers to face \
> > within a font family like weight (light, normal, bold, heavy) and emphasis \
> > (italic, oblique). So I think the label here should be "Font" not "Font style" \
> > for consistency.
> > Hope this helps!
there is a "Default" entry at the top of the list which restores whatever font your \
plasma theme uses. I just took the "font style" from the Plasma 4 dialog but indeed \
it's wrong.
- Kai Uwe
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123877/#review80719
-----------------------------------------------------------
On Mai 21, 2015, 9:45 nachm., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123877/
> -----------------------------------------------------------
>
> (Updated Mai 21, 2015, 9:45 nachm.)
>
>
> Review request for Plasma.
>
>
> Bugs: 348072
> https://bugs.kde.org/show_bug.cgi?id=348072
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> This restores the custom font family and font color options; also clean ups the \
> layout a bit - we don't have a FormLayout, so that's the best it can get. Did I \
> mention dealing with ComboBox is horrible?
>
> Diffs
> -----
>
> applets/digital-clock/package/contents/config/main.xml 5237160
> applets/digital-clock/package/contents/ui/DigitalClock.qml a142d33
> applets/digital-clock/package/contents/ui/configAppearance.qml 669b1cc
>
> Diff: https://git.reviewboard.kde.org/r/123877/diff/
>
>
> Testing
> -------
>
> Checking and unchecking the custom color checkbox properly sets/unsets the color, \
> the "Default" font option restores the default font, options in the dialog are \
> properly restored when it opens, Apply button does not appear to have become \
> broken.
>
> File Attachments
> ----------------
>
> The clock
> https://git.reviewboard.kde.org/media/uploaded/files/2015/05/21/1a6c37c2-5a11-4692-b658-241f2c3073af__uglyclock.png
> Settings
> https://git.reviewboard.kde.org/media/uploaded/files/2015/05/21/226b7028-69cf-4f6e-87db-2ba37ad3be29__uglyclock2.png
>
>
> Thanks,
>
> Kai Uwe Broulik
>
>
--===============0403502921564176233==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123877/">https://git.reviewboard.kde.org/r/123877/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On Mai 22nd, 2015, 2:14 vorm. UTC, <b>Andrew \
Lake</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Just a couple observations: 1. I think it might be \
helpful to have a way to restore using the default font specified in the fonts kcm \
without having to explicitly know/set the font to match the default. A checkbox to \
enable/disable setting a custom font family as is done for the color might work. 2. \
"Font style" in the fonts kcm refers to face within a font family like weight (light, \
normal, bold, heavy) and emphasis (italic, oblique). So I think the label here should \
be "Font" not "Font style" for consistency.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Hope this \
helps!</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">there \
is a "Default" entry at the top of the list which restores whatever font your plasma \
theme uses. I just took the "font style" from the Plasma 4 dialog but indeed it's \
wrong.</p></pre> <br />
<p>- Kai Uwe</p>
<br />
<p>On Mai 21st, 2015, 9:45 nachm. UTC, Kai Uwe Broulik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated Mai 21, 2015, 9:45 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=348072">348072</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This restores the custom font family and font color \
options; also clean ups the layout a bit - we don't have a FormLayout, so that's the \
best it can get. Did I mention dealing with ComboBox is horrible?</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Checking and unchecking the custom color checkbox \
properly sets/unsets the color, the "Default" font option restores the default font, \
options in the dialog are properly restored when it opens, Apply button does not \
appear to have become broken.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/digital-clock/package/contents/config/main.xml <span style="color: \
grey">(5237160)</span></li>
<li>applets/digital-clock/package/contents/ui/DigitalClock.qml <span style="color: \
grey">(a142d33)</span></li>
<li>applets/digital-clock/package/contents/ui/configAppearance.qml <span \
style="color: grey">(669b1cc)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123877/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/05/21/1a6c37c2-5a11-4692-b658-241f2c3073af__uglyclock.png">The \
clock</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/05/21/226b7028-69cf-4f6e-87db-2ba37ad3be29__uglyclock2.png">Settings</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0403502921564176233==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic