'Review Request 123877: [digital-clock] Bring back font family and color options'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Review Request 123877: [digital-clock] Bring back font family and color options
From:       "Kai Uwe Broulik" <kde () privat ! broulik ! de>
Date:       2015-05-21 21:45:49
Message-ID: 20150521214549.11005.74235 () mimi ! kde ! org
[Download RAW message or body]

--===============4065172964001820304==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123877/
-----------------------------------------------------------

Review request for Plasma.

Bugs: 348072
    https://bugs.kde.org/show_bug.cgi?id=348072

Repository: plasma-workspace

Description
-------

This restores the custom font family and font color options; also clean ups the \
layout a bit - we don't have a FormLayout, so that's the best it can get. Did I \
mention dealing with ComboBox is horrible?

Diffs
-----

  applets/digital-clock/package/contents/config/main.xml 5237160 
  applets/digital-clock/package/contents/ui/DigitalClock.qml a142d33 
  applets/digital-clock/package/contents/ui/configAppearance.qml 669b1cc 

Diff: https://git.reviewboard.kde.org/r/123877/diff/

Testing
-------

Checking and unchecking the custom color checkbox properly sets/unsets the color, the \
"Default" font option restores the default font, options in the dialog are properly \
restored when it opens, Apply button does not appear to have become broken.

File Attachments
----------------

The clock
  https://git.reviewboard.kde.org/media/uploaded/files/2015/05/21/1a6c37c2-5a11-4692-b658-241f2c3073af__uglyclock.png
 Settings
  https://git.reviewboard.kde.org/media/uploaded/files/2015/05/21/226b7028-69cf-4f6e-87db-2ba37ad3be29__uglyclock2.png

Thanks,

Kai Uwe Broulik

--===============4065172964001820304==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/123877/">https://git.reviewboard.kde.org/r/123877/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Kai Uwe Broulik.</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://bugs.kde.org/show_bug.cgi?id=348072">348072</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This restores the custom font family and font color \
options; also clean ups the layout a bit - we don't have a FormLayout, so that's the \
best it can get. Did I mention dealing with ComboBox is horrible?</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Checking and unchecking the custom color checkbox \
properly sets/unsets the color, the "Default" font option restores the default font, \
options in the dialog are properly restored when it opens, Apply button does not \
appear to have become broken.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>applets/digital-clock/package/contents/config/main.xml <span style="color: \
grey">(5237160)</span></li>

 <li>applets/digital-clock/package/contents/ui/DigitalClock.qml <span style="color: \
grey">(a142d33)</span></li>

 <li>applets/digital-clock/package/contents/ui/configAppearance.qml <span \
style="color: grey">(669b1cc)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/123877/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/05/21/1a6c37c2-5a11-4692-b658-241f2c3073af__uglyclock.png">The \
clock</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/05/21/226b7028-69cf-4f6e-87db-2ba37ad3be29__uglyclock2.png">Settings</a></li>

</ul>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============4065172964001820304==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 