'Re: Review Request 123859: prepare for single QQmlengine mode'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 123859: prepare for single QQmlengine mode
From:       "Marco Martin" <notmart () gmail ! com>
Date:       2015-05-20 11:16:10
Message-ID: 20150520111610.16315.73293 () mimi ! kde ! org
[Download RAW message or body]

--===============2131890195745901733==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123859/
-----------------------------------------------------------

(Updated May 20, 2015, 11:16 a.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma.

Changes
-------

Submitted with commit 7813ea168a3a2be88081e88e25f63bb73e11579c by Marco Martin to \
branch master.

Repository: bluedevil

Description
-------

remove the plasmapackage:/ url: just importing loginc.js will automatically take it \
from code/ anyways (also on current master as well) increment the plugininfo version \
to 3 that is another check the loader does to decide wether to use the legacy mode or \
not

Diffs
-----

  src/applet/package/contents/ui/BluetoothApplet.qml 397c075 
  src/applet/package/contents/ui/CompactRepresentation.qml e3ac14b 
  src/applet/package/metadata.desktop 84b46de 

Diff: https://git.reviewboard.kde.org/r/123859/diff/

Testing
-------

Thanks,

Marco Martin

--===============2131890195745901733==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/123859/">https://git.reviewboard.kde.org/r/123859/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Marco Martin.</div>

<p style="color: grey;"><i>Updated May 20, 2015, 11:16 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 7813ea168a3a2be88081e88e25f63bb73e11579c by Marco \
Martin to branch master.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
bluedevil
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">remove the plasmapackage:/ url: just importing \
loginc.js will automatically take it from code/ anyways (also on current master as \
well) increment the plugininfo version to 3 that is another check the loader does to \
decide wether to use the legacy mode or not</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/applet/package/contents/ui/BluetoothApplet.qml <span style="color: \
grey">(397c075)</span></li>

 <li>src/applet/package/contents/ui/CompactRepresentation.qml <span style="color: \
grey">(e3ac14b)</span></li>

 <li>src/applet/package/metadata.desktop <span style="color: \
grey">(84b46de)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/123859/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============2131890195745901733==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 