[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 123783: Adjust showing desktop behavior
From: Thomas_Lübking <thomas.luebking () gmail ! com>
Date: 2015-05-19 21:13:01
Message-ID: 20150519211301.16315.8015 () mimi ! kde ! org
[Download RAW message or body]
--===============7453707992750240852==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123783/
-----------------------------------------------------------
(Updated May 19, 2015, 9:13 p.m.)
Status
------
This change has been marked as submitted.
Review request for kwin, Plasma, Kai Uwe Broulik, David Edmundson, Martin Gräßlin, \
Marco Martin, Sebastian Kügler, and Thomas Pfeiffer.
Changes
-------
Submitted with commit f3b69b0ed0d3fa863ed4b2233ac5ce6c5fcdd9c3 by Thomas Lübking to \
branch Plasma/5.3.
Bugs: 346837, 346933 and 347212
https://bugs.kde.org/show_bug.cgi?id=346837
https://bugs.kde.org/show_bug.cgi?id=346933
https://bugs.kde.org/show_bug.cgi?id=347212
Repository: kwin
Description
-------
Errhemmmm... while we're waiting for final comments of the HIG group ;-)
Here's a patch that *mostly* restores the 5.2 behavior
Notable differences:
1) The minimizability of windows is ignored. It's a cornercase, but the former \
behavior was a side-effect of the implementation. (At least I don't know a reason to \
keep them)
2) The state is broken with the *activation* of windows, not them becoming visible. \
Latter doesn't work for most cases (unminimizing) for obvious reasons (they're not \
minimized ;-) and when a new window is mapped, the focus stealing prevention seems a \
good filter (if it's not good enough to gain the focus, it's not good enough to break \
the state either ;-)
3) Keep above windows remain visible and do not break the state (as if they'd belong \
to the desktop) for a request by the HIG group. I'm frankly not sure about the \
background of this behavior (hopefully not krunner - that doesn't work)
4) Windows in the desktop group initially remain above the desktop and can be \
activated w/ breaking the state, but can also hide behind the desktop (notably when \
that is clicked/activated)
Diffs
-----
activation.cpp fe0a51f
client.h 40d503c
client.cpp a6fbf3e
layers.cpp b6d5b75
manage.cpp 75af4e5
workspace.cpp 09ae9a2
Diff: https://git.reviewboard.kde.org/r/123783/diff/
Testing
-------
Thanks,
Thomas Lübking
--===============7453707992750240852==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123783/">https://git.reviewboard.kde.org/r/123783/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for kwin, Plasma, Kai Uwe Broulik, David Edmundson, Martin \
Gräßlin, Marco Martin, Sebastian Kügler, and Thomas Pfeiffer.</div> <div>By Thomas \
Lübking.</div>
<p style="color: grey;"><i>Updated May 19, 2015, 9:13 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit f3b69b0ed0d3fa863ed4b2233ac5ce6c5fcdd9c3 by Thomas \
Lübking to branch Plasma/5.3.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=346837">346837</a>,
<a href="https://bugs.kde.org/show_bug.cgi?id=346933">346933</a>,
<a href="https://bugs.kde.org/show_bug.cgi?id=347212">347212</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwin
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Errhemmmm... while we're waiting for final comments of \
the HIG group ;-) Here's a patch that <em style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">mostly</em> restores the \
5.2 behavior</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Notable differences:</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">1) \
The minimizability of windows is ignored. It's a cornercase, but the former behavior \
was a side-effect of the implementation. (At least I don't know a reason to keep \
them)</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">2) The state is broken with the <em style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">activation</em> of windows, not them becoming visible. Latter doesn't work \
for most cases (unminimizing) for obvious reasons (they're not minimized ;-) and when \
a new window is mapped, the focus stealing prevention seems a good filter (if it's \
not good enough to gain the focus, it's not good enough to break the state either \
;-)</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">3) Keep above windows remain visible and do not break \
the state (as if they'd belong to the desktop) for a request by the HIG group. I'm \
frankly not sure about the background of this behavior (hopefully not krunner - that \
doesn't work)</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">4) Windows in the desktop group initially remain above \
the desktop and can be activated w/ breaking the state, but can also hide behind the \
desktop (notably when that is clicked/activated)</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>activation.cpp <span style="color: grey">(fe0a51f)</span></li>
<li>client.h <span style="color: grey">(40d503c)</span></li>
<li>client.cpp <span style="color: grey">(a6fbf3e)</span></li>
<li>layers.cpp <span style="color: grey">(b6d5b75)</span></li>
<li>manage.cpp <span style="color: grey">(75af4e5)</span></li>
<li>workspace.cpp <span style="color: grey">(09ae9a2)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123783/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7453707992750240852==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic