'Re: Review Request 123821: Highlight leading and trailing whitespace'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 123821: Highlight leading and trailing whitespace
From:       "Kai Uwe Broulik" <kde () privat ! broulik ! de>
Date:       2015-05-17 18:18:35
Message-ID: 20150517181835.16315.96960 () mimi ! kde ! org
[Download RAW message or body]

--===============6811904397581340043==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123821/
-----------------------------------------------------------

(Updated May 17, 2015, 6:18 p.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma, KDE Usability, Martin Gräßlin, and Patrick Eigensatz.

Changes
-------

Submitted with commit 4fdfcded48f222a2aa1f8032142d8191f0624f5e by Kai Uwe Broulik to \
branch master.

Bugs: 159267
    https://bugs.kde.org/show_bug.cgi?id=159267

Repository: plasma-workspace

Description
-------

This patch makes klipper highlight leading and trailing white-space (line break, \
spaces, tabs) by coloring them and replacing them with visible characters

(Using the "open box", "double arrow" and "down-left arrow" that look more familiar \
(though I recall word processors using a mid dot for space) instead of the unicode \
SP/HT/CR thingies)

Diffs
-----

  applets/clipboard/contents/ui/ClipboardItemDelegate.qml f9b0d59 

Diff: https://git.reviewboard.kde.org/r/123821/diff/

Testing
-------

Seems to work pretty well, copied random console output

File Attachments
----------------

Screenshot
  https://git.reviewboard.kde.org/media/uploaded/files/2015/05/16/e31d060b-ab13-4f37-9ba3-26cb743ddee4__klippercolorcoded.png

Thanks,

Kai Uwe Broulik

--===============6811904397581340043==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/123821/">https://git.reviewboard.kde.org/r/123821/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma, KDE Usability, Martin Gräßlin, and Patrick \
Eigensatz.</div> <div>By Kai Uwe Broulik.</div>

<p style="color: grey;"><i>Updated May 17, 2015, 6:18 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 4fdfcded48f222a2aa1f8032142d8191f0624f5e by Kai \
Uwe Broulik to branch master.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://bugs.kde.org/show_bug.cgi?id=159267">159267</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This patch makes klipper highlight leading and \
trailing white-space (line break, spaces, tabs) by coloring them and replacing them \
with visible characters</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">(Using the "open box", "double arrow" \
and "down-left arrow" that look more familiar (though I recall word processors using \
a mid dot for space) instead of the unicode SP/HT/CR thingies)</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Seems to work pretty well, copied random console \
output</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>applets/clipboard/contents/ui/ClipboardItemDelegate.qml <span style="color: \
grey">(f9b0d59)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/123821/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/05/16/e31d060b-ab13-4f37-9ba3-26cb743ddee4__klippercolorcoded.png">Screenshot</a></li>

</ul>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============6811904397581340043==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 