'Re: Review Request 123815: Fix the panel configuration width in case of long strings in buttons.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 123815: Fix the panel configuration width in case of long strings in buttons.
From:       "Yoann Laissus" <yoann.laissus () gmail ! com>
Date:       2015-05-17 13:23:09
Message-ID: 20150517132309.16315.6102 () mimi ! kde ! org
[Download RAW message or body]

--===============1701873990830325818==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123815/
-----------------------------------------------------------

(Updated May 17, 2015, 1:23 p.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma.

Changes
-------

Submitted with commit ad81cae37b112b67de2a515255cf73ce6df2330d by Yoann Laissus to \
branch master.

Repository: plasma-desktop

Description
-------

The panel configuration width is defined to a fixed value when it's vertical.
In English, it's not a problem because strings are very compacts. But for example, in \
French, some strings get too big for the buttons.

The width is now computed dynamically from the button layout.
I'm really not a QML expert, please let me know if there is a better way to achieve \
that.

Diffs
-----

  desktoppackage/contents/configuration/panelconfiguration/ToolBar.qml \
7cf567e30c99b38e6fbdfa718e4de2ef32c2f5dd 

Diff: https://git.reviewboard.kde.org/r/123815/diff/

Testing
-------

Tested in all screen edges.

File Attachments
----------------

Truncated text
  https://git.reviewboard.kde.org/media/uploaded/files/2015/05/16/d04883f4-e479-4e0c-9c49-fb545003ab9d__truncated_button.jpg
 After the fix
  https://git.reviewboard.kde.org/media/uploaded/files/2015/05/16/60e37174-5523-4682-aabb-fc0e23ac5bdc__fixed_button.jpg

Thanks,

Yoann Laissus

--===============1701873990830325818==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/123815/">https://git.reviewboard.kde.org/r/123815/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Yoann Laissus.</div>

<p style="color: grey;"><i>Updated May 17, 2015, 1:23 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit ad81cae37b112b67de2a515255cf73ce6df2330d by Yoann \
Laissus to branch master.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The panel configuration width is defined to a fixed \
value when it's vertical. In English, it's not a problem because strings are very \
compacts. But for example, in French, some strings get too big for the buttons.</p> \
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The width is now computed dynamically from the button \
layout. I'm really not a QML expert, please let me know if there is a better way to \
achieve that.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Tested in all screen edges.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>desktoppackage/contents/configuration/panelconfiguration/ToolBar.qml <span \
style="color: grey">(7cf567e30c99b38e6fbdfa718e4de2ef32c2f5dd)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/123815/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/05/16/d04883f4-e479-4e0c-9c49-fb545003ab9d__truncated_button.jpg">Truncated \
text</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/05/16/60e37174-5523-4682-aabb-fc0e23ac5bdc__fixed_button.jpg">After \
the fix</a></li>

</ul>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============1701873990830325818==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 