'Re: Review Request 123818: soliddevice: Use KDiskFreeSpaceInfo instead of solid to get disk size'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 123818: soliddevice: Use KDiskFreeSpaceInfo instead of solid to get disk size
From:       "Yoann Laissus" <yoann.laissus () gmail ! com>
Date:       2015-05-16 18:44:18
Message-ID: 20150516184418.8613.59863 () mimi ! kde ! org
[Download RAW message or body]

--===============3634482427346833865==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123818/
-----------------------------------------------------------

(Updated mai 16, 2015, 6:44 après-midi)

Review request for Plasma.

Changes
-------

Refactoring of the free space update code.

Repository: plasma-workspace

Description
-------

Currently, the size of devices is retrieved with solid.
Unfortunately, it doesn't work for network shares. Only the "StorageVolume" type has \
the "size" option.

KDiskFreeSpaceInfo supports every mounted device, not matter its type.

Diffs (updated)
-----

  applets/devicenotifier/package/contents/ui/FullRepresentation.qml \
0a5b035d1afac368faf85f6dd0ff41bab4812562   \
dataengines/soliddevice/soliddeviceengine.h 85bdc68d4d7a9a8704d8ff1dcd29355c784ed435  \
dataengines/soliddevice/soliddeviceengine.cpp \
94819c7405a3eb4b0ef679a55de2de20bd05fdb2   \
dataengines/soliddevice/soliddeviceservice.cpp \
f2f96ef4d63f41e3e2ea9bf31297adfcdf151a97 

Diff: https://git.reviewboard.kde.org/r/123818/diff/

Testing
-------

Tested with local disks, USB devices, NFS shares

Thanks,

Yoann Laissus

--===============3634482427346833865==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/123818/">https://git.reviewboard.kde.org/r/123818/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Yoann Laissus.</div>

<p style="color: grey;"><i>Updated mai 16, 2015, 6:44 après-midi</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Refactoring of the free space update code.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Currently, the size of devices is retrieved with \
solid. Unfortunately, it doesn't work for network shares. Only the "StorageVolume" \
type has the "size" option.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">KDiskFreeSpaceInfo supports every \
mounted device, not matter its type.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Tested with local disks, USB devices, NFS \
shares</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>applets/devicenotifier/package/contents/ui/FullRepresentation.qml <span \
style="color: grey">(0a5b035d1afac368faf85f6dd0ff41bab4812562)</span></li>

 <li>dataengines/soliddevice/soliddeviceengine.h <span style="color: \
grey">(85bdc68d4d7a9a8704d8ff1dcd29355c784ed435)</span></li>

 <li>dataengines/soliddevice/soliddeviceengine.cpp <span style="color: \
grey">(94819c7405a3eb4b0ef679a55de2de20bd05fdb2)</span></li>

 <li>dataengines/soliddevice/soliddeviceservice.cpp <span style="color: \
grey">(f2f96ef4d63f41e3e2ea9bf31297adfcdf151a97)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/123818/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============3634482427346833865==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 