[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 123688: Improve sddm login experience
From: "David Kahles" <david.kahles96 () gmail ! com>
Date: 2015-05-09 12:45:24
Message-ID: 20150509124524.26284.30073 () mimi ! kde ! org
[Download RAW message or body]
--===============6040116285151780968==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On May 8, 2015, 9:14 p.m., Kai Uwe Broulik wrote:
> > lookandfeel/contents/loginmanager/Main.qml, line 97
> > <https://git.reviewboard.kde.org/r/123688/diff/1/?file=367729#file367729line97>
> >
> > Why would you put that into a property? Just tive the Timer an id
Yes, done.
Would you have time to explain the difference to me (e.g. next week)? I'm always \
struggling with this stuff and the qt.io wiki doesn't help :-/
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123688/#review80101
-----------------------------------------------------------
On May 8, 2015, 6:48 p.m., David Kahles wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123688/
> -----------------------------------------------------------
>
> (Updated May 8, 2015, 6:48 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> Disables the button and the passwordfield while the password check is
> running and hides the "Login Failed" message after 3 seconds.
>
>
> Diffs
> -----
>
> lookandfeel/contents/loginmanager/Main.qml 528f9b4e43ee6b8636ca1c816d5bad556bede871 \
>
> Diff: https://git.reviewboard.kde.org/r/123688/diff/
>
>
> Testing
> -------
>
> Login and failed login are working as expected.
> Tested in qmlscene and on two computers running Archlinux.
>
>
> Thanks,
>
> David Kahles
>
>
--===============6040116285151780968==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123688/">https://git.reviewboard.kde.org/r/123688/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On May 8th, 2015, 9:14 p.m. CEST, <b>Kai Uwe \
Broulik</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/123688/diff/1/?file=367729#file367729line97" \
style="color: black; font-weight: bold; text-decoration: \
underline;">lookandfeel/contents/loginmanager/Main.qml</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">96</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="nx">property</span> <span class="nx">Timer</span> <span \
class="k">notificationResetTimer:</span> <span class="nx">Timer</span> <span \
class="p">{</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Why \
would you put that into a property? Just tive the Timer an id</p></pre> \
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Yes, done. Would you have time to explain the difference to me (e.g. next \
week)? I'm always struggling with this stuff and the qt.io wiki doesn't help \
:-/</p></pre> <br />
<p>- David</p>
<br />
<p>On May 8th, 2015, 6:48 p.m. CEST, David Kahles wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By David Kahles.</div>
<p style="color: grey;"><i>Updated May 8, 2015, 6:48 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Disables the button and the passwordfield while the \
password check is running and hides the "Login Failed" message after 3 \
seconds.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Login and failed login are working as expected. Tested \
in qmlscene and on two computers running Archlinux.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>lookandfeel/contents/loginmanager/Main.qml <span style="color: \
grey">(528f9b4e43ee6b8636ca1c816d5bad556bede871)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123688/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6040116285151780968==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic