[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 123547: Task manager : New instances can now be opened by mid click.
From:       "Yoann Laissus" <yoann.laissus () gmail ! com>
Date:       2015-05-08 12:35:07
Message-ID: 20150508123507.26284.62040 () mimi ! kde ! org
[Download RAW message or body]

--===============8695812978719810205==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123547/
-----------------------------------------------------------

(Updated mai 8, 2015, 12:35 après-midi)


Review request for Plasma.


Changes
-------

This new patch implements what you say in your last message, Eike.
About the "Close Window", it's actually a "Close group" as it will close all opened \
windows of a group.


Repository: plasma-desktop


Description
-------

Currently, only the shortcut Shift + Left click is available.
In KDE4, we had both.


Diffs (updated)
-----

  applets/taskmanager/package/contents/config/main.xml 7d3226d 
  applets/taskmanager/package/contents/ui/ConfigGeneral.qml 72d4539 
  applets/taskmanager/package/contents/ui/Task.qml fcf7980 
  applets/taskmanager/package/contents/ui/main.qml 49c612a 
  applets/taskmanager/plugin/backend.h ba2e453 
  applets/taskmanager/plugin/backend.cpp 68d8414 

Diff: https://git.reviewboard.kde.org/r/123547/diff/


Testing
-------

Tested with classic task manager and the icon only one.
Tested with all mouse button combinaisons and keyboard modifiers.


Thanks,

Yoann Laissus


--===============8695812978719810205==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/123547/">https://git.reviewboard.kde.org/r/123547/</a>
  </td>
    </tr>
   </table>
   <br />




<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Yoann Laissus.</div>


<p style="color: grey;"><i>Updated mai 8, 2015, 12:35 après-midi</i></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This new patch implements what you say in your last message, Eike. About \
the &quot;Close Window&quot;, it&#39;s actually a &quot;Close group&quot; as it will \
close all opened windows of a group.</pre>  </td>
 </tr>
</table>







<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Currently, only the shortcut Shift + Left click is \
available. In KDE4, we had both.</p></pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Tested with classic task manager and the icon only \
one. Tested with all mouse button combinaisons and keyboard modifiers.</p></pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>applets/taskmanager/package/contents/config/main.xml <span style="color: \
grey">(7d3226d)</span></li>

 <li>applets/taskmanager/package/contents/ui/ConfigGeneral.qml <span style="color: \
grey">(72d4539)</span></li>

 <li>applets/taskmanager/package/contents/ui/Task.qml <span style="color: \
grey">(fcf7980)</span></li>

 <li>applets/taskmanager/package/contents/ui/main.qml <span style="color: \
grey">(49c612a)</span></li>

 <li>applets/taskmanager/plugin/backend.h <span style="color: \
grey">(ba2e453)</span></li>

 <li>applets/taskmanager/plugin/backend.cpp <span style="color: \
grey">(68d8414)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/123547/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>



  </div>
 </body>
</html>


--===============8695812978719810205==--


[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic