[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 123671: add visibleWhileDesktopShown property
From: "Marco Martin" <notmart () gmail ! com>
Date: 2015-05-07 11:23:03
Message-ID: 20150507112303.16998.67639 () mimi ! kde ! org
[Download RAW message or body]
--===============3162933816325429181==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123671/#review80028
-----------------------------------------------------------
I think i would like more either all panels always shown or always hidden.
however I'm fine, given the discussion on this if this mechanism is used instead.
just a question: wouldn't make more sense to use this in a private component of the \
show desktop applet instead of giving api for everything? I feel the use case so far \
is quite limited to a potential single applet. If then more applets come out that \
would need this, it could be moved in bindings (of which i would prefer in \
appletinterface rather than appletquickitem)
src/plasmaquick/appletquickitem.h (line 94)
<https://git.reviewboard.kde.org/r/123671/#comment54912>
I would prefer it in AppletInterface, as appletquickitem is mostly for qml \
loading and exports public symbols
- Marco Martin
On May 7, 2015, 11:14 a.m., Thomas Lübking wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123671/
> -----------------------------------------------------------
>
> (Updated May 7, 2015, 11:14 a.m.)
>
>
> Review request for Plasma and Marco Martin.
>
>
> Bugs: 346837, 346933 and 347212
> http://bugs.kde.org/show_bug.cgi?id=346837
> http://bugs.kde.org/show_bug.cgi?id=346933
> http://bugs.kde.org/show_bug.cgi?id=347212
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> plasmoids only need to add
> Plasmoid.visibleWhileDesktopShown: true;
> to ensure their panel (and thus them) remains visible while showing the desktop
>
> This is achieved by setting the panel transient for the (first found, under them \
> and visible) desktop type window.
> This is mostly relevant for the showdesktop plasmoid (for now)
>
> Notice that all bugs are only CC, we need this to be used in the showdesktop \
> plasmoid.
>
> Diffs
> -----
>
> src/plasmaquick/appletquickitem.h dffbcf3
> src/plasmaquick/appletquickitem.cpp 0748a8d
> src/plasmaquick/private/appletquickitem_p.h a1ec683
>
> Diff: https://git.reviewboard.kde.org/r/123671/diff/
>
>
> Testing
> -------
>
> added/removed (multiple) showdesktop plasmoids - panel transient for correct \
> desktop window (and visible) unless the last is gone (they seem to be deleted with \
> a short random delay?)
>
> Thanks,
>
> Thomas Lübking
>
>
--===============3162933816325429181==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123671/">https://git.reviewboard.kde.org/r/123671/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
think i would like more either all panels always shown or always hidden. however I'm \
fine, given the discussion on this if this mechanism is used instead. just a \
question: wouldn't make more sense to use this in a private component of the show \
desktop applet instead of giving api for everything? I feel the use case so far is \
quite limited to a potential single applet. If then more applets come out that would \
need this, it could be moved in bindings (of which i would prefer in appletinterface \
rather than appletquickitem)</p></pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/123671/diff/1/?file=367366#file367366line94" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/plasmaquick/appletquickitem.h</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">class \
PLASMAQUICK_EXPORT AppletQuickItem : public QQuickItem</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">94</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">Q_PROPERTY</span><span class="p">(</span><span class="kt">bool</span> <span \
class="n">visibleWhileDesktopShown</span> <span class="n">READ</span> <span \
class="n">keepsVisibleWhileDesktopShown</span> <span class="n">WRITE</span> <span \
class="n">setVisibleWhileDesktopShown</span><span class="p">)</span></pre></td> \
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
would prefer it in AppletInterface, as appletquickitem is mostly for qml loading and \
exports public symbols</p></pre> </div>
</div>
<br />
<p>- Marco Martin</p>
<br />
<p>On May 7th, 2015, 11:14 a.m. UTC, Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma and Marco Martin.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated May 7, 2015, 11:14 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=346837">346837</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=346933">346933</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=347212">347212</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">plasmoids only need to add \
Plasmoid.visibleWhileDesktopShown: true; to ensure their panel (and thus them) \
remains visible while showing the desktop</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">This is achieved by \
setting the panel transient for the (first found, under them and visible) desktop \
type window.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This is mostly relevant for the showdesktop plasmoid \
(for now)</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Notice that all bugs are only CC, we need this to be \
used in the showdesktop plasmoid.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">added/removed (multiple) showdesktop plasmoids - panel \
transient for correct desktop window (and visible) unless the last is gone (they seem \
to be deleted with a short random delay?)</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/plasmaquick/appletquickitem.h <span style="color: \
grey">(dffbcf3)</span></li>
<li>src/plasmaquick/appletquickitem.cpp <span style="color: \
grey">(0748a8d)</span></li>
<li>src/plasmaquick/private/appletquickitem_p.h <span style="color: \
grey">(a1ec683)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123671/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3162933816325429181==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic