--===============7978499593684944708== Content-Type: multipart/alternative; boundary="===============4828928484977220209==" --===============4828928484977220209== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123575/#review79740 ----------------------------------------------------------- Ship it! Ship It! - Marco Martin On April 30, 2015, 5:35 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123575/ > ----------------------------------------------------------- > > (Updated April 30, 2015, 5:35 p.m.) > > > Review request for KDE Frameworks, Plasma and Marco Martin. > > > Repository: plasma-framework > > > Description > ------- > > I've been trying to figure out why there's so many qml scripts which errors always specify "". > This patch is not ideal, but improves the situation slightly. > > > Diffs > ----- > > src/plasmaquick/appletquickitem.cpp 0748a8d > > Diff: https://git.reviewboard.kde.org/r/123575/diff/ > > > Testing > ------- > > * Tests still pass. > * some warnings have a filename when running "plasmawindowed org.kde.plasma.systemtray". > > > Thanks, > > Aleix Pol Gonzalez > > --===============4828928484977220209== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123575/

Ship it!

Ship It!

- Marco Martin


On April 30th, 2015, 5:35 p.m. UTC, Aleix Pol Gonzalez wrote:

Review request for KDE Frameworks, Plasma and Marco Martin.
By Aleix Pol Gonzalez.

Updated April 30, 2015, 5:35 p.m.

Repository: plasma-framework

Description 

I've been trying to figure out why there's so many qml scripts which errors always specify "<Unknown Files>".
This patch is not ideal, but improves the situation slightly.

Testing 

    

  • Tests still pass.
    • 

  • some warnings have a filename when running "plasmawindowed org.kde.plasma.systemtray".
    •

Diffs

  • src/plasmaquick/appletquickitem.cpp (0748a8d)

View Diff
--===============4828928484977220209==-- --===============7978499593684944708== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============7978499593684944708==--