From kde-panel-devel Thu Apr 30 07:40:34 2015 From: "Marco Martin" Date: Thu, 30 Apr 2015 07:40:34 +0000 To: kde-panel-devel Subject: Re: Review Request 123556: KPackage::findPackages with a filter callback Message-Id: <20150430074034.21733.12904 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=143037966131435 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============8926141915076596340==" --===============8926141915076596340== Content-Type: multipart/alternative; boundary="===============8526065204940759443==" --===============8526065204940759443== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On April 29, 2015, 8:53 p.m., Alex Richardson wrote: > > src/kpackage/packageloader.cpp, line 273 > > > > > > This will crash if there is no filter. > > > > `if (!filter || filter(plugin))` should work. done, thanks - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123556/#review79698 ----------------------------------------------------------- On April 29, 2015, 12:12 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123556/ > ----------------------------------------------------------- > > (Updated April 29, 2015, 12:12 p.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: kpackage > > > Description > ------- > > Add a KPackage::findPackages function similar to KPluginLoader::findPlugins > > > Diffs > ----- > > src/kpackage/packageloader.h 2761d98 > src/kpackage/packageloader.cpp 00defbd > > Diff: https://git.reviewboard.kde.org/r/123556/diff/ > > > Testing > ------- > > > Thanks, > > Marco Martin > > --===============8526065204940759443== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123556/

On April 29th, 2015, 8:53 p.m. UTC, Alex Richardson wrote:

src/kpackage/packageloader.cpp (Diff revision 2) 

    273
    
        if (filter(plugin)) {

  


 




  
This will crash if there is no filter.


if (!filter || filter(plugin)) should work.

 









done, thanks








- Marco






On April 29th, 2015, 12:12 p.m. UTC, Marco Martin wrote:











 

  


Review request for KDE Frameworks and Plasma.


By Marco Martin.




Updated April 29, 2015, 12:12 p.m.












 Repository: 
kpackage





Description 

 

 

  
   
Add a KPackage::findPackages function similar to KPluginLoader::findPlugins

  		
 







Diffs 


    

 
  • src/kpackage/packageloader.h (2761d98)
    • 

 
  • src/kpackage/packageloader.cpp (00defbd)
    • 





View Diff







  		
 










  

 



--===============8526065204940759443==--

--===============8926141915076596340==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl
dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y
Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo=

--===============8926141915076596340==--