[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 123544: kioclient ls: properly construct QUrl.
From: "Aleix Pol Gonzalez" <aleixpol () kde ! org>
Date: 2015-04-29 23:04:15
Message-ID: 20150429230415.21733.66342 () mimi ! kde ! org
[Download RAW message or body]
--===============6557607269129147357==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On April 30, 2015, 1:02 a.m., Mark Gaiser wrote:
> > Pushed. But slightly different then was reviewed here.
> > I added the define which subsequently gave me two more issues of the same nature \
> > in kioclient (cat and openProperties). I've fixed those as well and changed the \
> > commit message accordingly. Yes, i did test them before pushing and they seem to \
> > work just fine now.
> > http://quickgit.kde.org/?p=kde-cli-tools.git&a=commit&h=787bdf628fdf9f74c978363e07ddad0ae306d8bf
> >
Wonderful. Thanks!
- Aleix
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123544/#review79701
-----------------------------------------------------------
On April 30, 2015, 12:56 a.m., Mark Gaiser wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123544/
> -----------------------------------------------------------
>
> (Updated April 30, 2015, 12:56 a.m.)
>
>
> Review request for Plasma and David Faure.
>
>
> Repository: kde-cli-tools
>
>
> Description
> -------
>
> The ls command was using direct user input as QUrl. That in turn caused the QUrl to \
> be constructed without a scheme. Constructing it via makeURL(...) (like all the \
> others do) makes it a valid QUrl with scheme. This allows for example a command \
> like "kioclient ls ~" to work again. Again because it worked in the kdelibs version \
> thus this was a regression.
>
> Diffs
> -----
>
> kioclient/kioclient.cpp 74c9985
>
> Diff: https://git.reviewboard.kde.org/r/123544/diff/
>
>
> Testing
> -------
>
> kioclient ls <path> works. No need to prefix the path with "file://" anymore.
>
>
> Thanks,
>
> Mark Gaiser
>
>
--===============6557607269129147357==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123544/">https://git.reviewboard.kde.org/r/123544/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On April 30th, 2015, 1:02 a.m. CEST, <b>Mark \
Gaiser</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Pushed. But slightly different then was reviewed here. \
I added the define which subsequently gave me two more issues of the same nature in \
kioclient (cat and openProperties). I've fixed those as well and changed the commit \
message accordingly. Yes, i did test them before pushing and they seem to work just \
fine now.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: \
inherit;">http://quickgit.kde.org/?p=kde-cli-tools.git&a=commit&h=787bdf628fdf9f74c978363e07ddad0ae306d8bf</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Wonderful. Thanks!</p></pre> <br />
<p>- Aleix</p>
<br />
<p>On April 30th, 2015, 12:56 a.m. CEST, Mark Gaiser wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma and David Faure.</div>
<div>By Mark Gaiser.</div>
<p style="color: grey;"><i>Updated April 30, 2015, 12:56 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-cli-tools
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The ls command was using direct user input as QUrl. \
That in turn caused the QUrl to be constructed without a scheme. Constructing it via \
makeURL(...) (like all the others do) makes it a valid QUrl with scheme. This allows \
for example a command like "kioclient ls ~" to work again. Again because it worked in \
the kdelibs version thus this was a regression.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">kioclient ls <path> works. No need to prefix the \
path with "file://" anymore.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kioclient/kioclient.cpp <span style="color: grey">(74c9985)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123544/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6557607269129147357==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic