From kde-panel-devel Wed Apr 29 12:00:08 2015 From: "Heiko Becker" Date: Wed, 29 Apr 2015 12:00:08 +0000 To: kde-panel-devel Subject: Review Request 123557: FindQalculate: Use FindPkgConfig instead of UsePkgConfig Message-Id: <20150429120008.6735.59910 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=143031153212226 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============9174692434186566776==" --===============9174692434186566776== Content-Type: multipart/alternative; boundary="===============7274250843017398552==" --===============7274250843017398552== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123557/ ----------------------------------------------------------- Review request for Plasma. Repository: plasma-workspace Description ------- The latter is deprecated and doesn't respect the PKG_CONFIG environment variable which makes it easy to deal with differently named pkg-config executables, e.g. arch-prefixed ones. Diffs ----- cmake/FindQalculate.cmake 707a9f7c96b16daf18c1b75400eb8ac4dd30da2c Diff: https://git.reviewboard.kde.org/r/123557/diff/ Testing ------- Configured, built and checked that plasma-workspace links to qualculate and cln. Thanks, Heiko Becker --===============7274250843017398552== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123557/

Review request for Plasma.

By Heiko Becker.

Repository: plasma-workspace

Description

The latter is deprecated and doesn't respect the PKG_CONFIG
environment variable which makes it easy to deal with differently
named pkg-config executables, e.g. arch-prefixed ones.

Testing

Configured, built and checked that plasma-workspace links to qualculate and cln.

Diffs

cmake/FindQalculate.cmake (707a9f7c96b16daf18c1b75400eb8ac4dd30da2c)

View Diff

--===============7274250843017398552==-- --===============9174692434186566776== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============9174692434186566776==--