[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 123555: Fix a crash in PowermanagementEngine::populateApplicationData when the gi
From: "Kai Uwe Broulik" <kde () privat ! broulik ! de>
Date: 2015-04-29 11:53:28
Message-ID: 20150429115328.21733.68301 () mimi ! kde ! org
[Download RAW message or body]
--===============3757090601876216959==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123555/#review79666
-----------------------------------------------------------
Ship it!
Nice one!
Please commit to Plasma/5.3 and then merge into master.
- Kai Uwe Broulik
On April 29, 2015, 10:40 vorm., Emmanuel Pescosta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123555/
> -----------------------------------------------------------
>
> (Updated April 29, 2015, 10:40 vorm.)
>
>
> Review request for Plasma and Kai Uwe Broulik.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> Fix a crash in PowermanagementEngine::populateApplicationData when the given name \
> is empty.
> Use QString::section instead of QString::split + QList::last (which requires a non \
> empty list) to prevent the crash.
> The crash is sometimes reproducible with Spotify. (plasmashell crashes in an \
> endless loop in this case)
>
> IMO: Maybe the PowermanagementEngine should only add inhibitions from applications \
> which have a non empty name?!
>
> Diffs
> -----
>
> dataengines/powermanagement/powermanagementengine.cpp 2fbf23f
>
> Diff: https://git.reviewboard.kde.org/r/123555/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Emmanuel Pescosta
>
>
--===============3757090601876216959==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123555/">https://git.reviewboard.kde.org/r/123555/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Nice \
one!</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Please commit to Plasma/5.3 and then merge into \
master.</p></pre> <br />
<p>- Kai Uwe Broulik</p>
<br />
<p>On April 29th, 2015, 10:40 vorm. UTC, Emmanuel Pescosta wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma and Kai Uwe Broulik.</div>
<div>By Emmanuel Pescosta.</div>
<p style="color: grey;"><i>Updated April 29, 2015, 10:40 vorm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Fix a crash in \
PowermanagementEngine::populateApplicationData when the given name is empty.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Use QString::section instead of QString::split + QList::last (which \
requires a non empty list) to prevent the crash.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The \
crash is sometimes reproducible with Spotify. (plasmashell crashes in an endless loop \
in this case)</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">IMO: Maybe the PowermanagementEngine should only add \
inhibitions from applications which have a non empty name?!</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dataengines/powermanagement/powermanagementengine.cpp <span style="color: \
grey">(2fbf23f)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123555/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3757090601876216959==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic