[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 123547: Task manager : New instances can now be opened by mid click.
From: "Yoann Laissus" <yoann.laissus () gmail ! com>
Date: 2015-04-29 7:36:36
Message-ID: 20150429073636.21733.6843 () mimi ! kde ! org
[Download RAW message or body]
--===============0397959620594884827==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On avr. 28, 2015, 9:47 après-midi, David Edmundson wrote:
> > applets/taskmanager/package/contents/ui/Task.qml, line 108
> > <https://git.reviewboard.kde.org/r/123547/diff/1/?file=364298#file364298line108>
> >
> > now shift + right click will also start a new instance, that's probably \
> > unintended?
The right click was inhibitted in the press event (pressed != true) as it doesn't \
need a release event to be triggered. But I could add a check in release just to be \
safe.
- Yoann
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123547/#review79647
-----------------------------------------------------------
On avr. 28, 2015, 8:45 après-midi, Yoann Laissus wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123547/
> -----------------------------------------------------------
>
> (Updated avr. 28, 2015, 8:45 après-midi)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-desktop
>
>
> Description
> -------
>
> Currently, only the shortcut Shift + Left click is available.
> In KDE4, we had both.
>
>
> Diffs
> -----
>
> applets/taskmanager/package/contents/ui/Task.qml f5fc723
>
> Diff: https://git.reviewboard.kde.org/r/123547/diff/
>
>
> Testing
> -------
>
> Tested with classic task manager and the icon only one.
> Tested with all mouse button combinaisons and keyboard modifiers.
>
>
> Thanks,
>
> Yoann Laissus
>
>
--===============0397959620594884827==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123547/">https://git.reviewboard.kde.org/r/123547/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On avril 28th, 2015, 9:47 après-midi UTC, \
<b>David Edmundson</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: \
2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/123547/diff/1/?file=364298#file364298line108" \
style="color: black; font-weight: bold; text-decoration: \
underline;">applets/taskmanager/package/contents/ui/Task.qml</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">108</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">if</span> <span class="p">(</span><span class="o"><span \
class="hl">!</span></span><span class="nx">mouse</span><span class="p">.</span><span \
class="nx">button</span> <span class="o">==</span> <span class="nx">Qt</span><span \
class="p">.</span><span class="nx"><span class="hl">Left</span>Button</span><span \
class="p">)</span> <span class="p">{</span></pre></td> <th bgcolor="#e9eaa8" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">108</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">if</span> <span class="p">(</span><span class="nx">mouse</span><span \
class="p">.</span><span class="nx">button</span> <span class="o">==</span> <span \
class="nx">Qt</span><span class="p">.</span><span class="nx"><span \
class="hl">Mid</span>Button</span><span class="hl"> </span><span class="o"><span \
class="hl">||</span></span><span class="hl"> </span><span class="nx"><span \
class="hl">mouse</span></span><span class="p"><span class="hl">.</span></span><span \
class="nx"><span class="hl">modifiers</span></span><span class="hl"> </span><span \
class="o"><span class="hl">&</span></span><span class="hl"> </span><span \
class="nx"><span class="hl">Qt</span></span><span class="p"><span \
class="hl">.</span></span><span class="nx"><span \
class="hl">ShiftModifier</span></span><span class="p">)</span> <span \
class="p">{</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">now \
shift + right click will also start a new instance, that's probably \
unintended?</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">The right click was inhibitted in the press event (pressed != true) as it \
doesn't need a release event to be triggered. But I could add a check in release just \
to be safe.</p></pre> <br />
<p>- Yoann</p>
<br />
<p>On avril 28th, 2015, 8:45 après-midi UTC, Yoann Laissus wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Yoann Laissus.</div>
<p style="color: grey;"><i>Updated avr. 28, 2015, 8:45 après-midi</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Currently, only the shortcut Shift + Left click is \
available. In KDE4, we had both.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Tested with classic task manager and the icon only \
one. Tested with all mouse button combinaisons and keyboard modifiers.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/taskmanager/package/contents/ui/Task.qml <span style="color: \
grey">(f5fc723)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123547/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0397959620594884827==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic