'Re: Review Request 123547: Task manager : New instances can now be opened by mid click.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 123547: Task manager : New instances can now be opened by mid click.
From:       "Eike Hein" <hein () kde ! org>
Date:       2015-04-28 23:48:36
Message-ID: 20150428234836.14758.92050 () mimi ! kde ! org
[Download RAW message or body]

--===============2032929247081567353==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123547/#review79649
-----------------------------------------------------------

People  frequently request either "new instance" or "close window" for middle-click, \
so unfortunately I think this will have to be a config option and I won't accept a \
patch that only implements the one behavior.

- Eike Hein

On April 28, 2015, 8:45 p.m., Yoann Laissus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123547/
> -----------------------------------------------------------
> 
> (Updated April 28, 2015, 8:45 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> Currently, only the shortcut Shift + Left click is available.
> In KDE4, we had both.
> 
> 
> Diffs
> -----
> 
> applets/taskmanager/package/contents/ui/Task.qml f5fc723 
> 
> Diff: https://git.reviewboard.kde.org/r/123547/diff/
> 
> 
> Testing
> -------
> 
> Tested with classic task manager and the icon only one.
> Tested with all mouse button combinaisons and keyboard modifiers.
> 
> 
> Thanks,
> 
> Yoann Laissus
> 
> 

--===============2032929247081567353==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/123547/">https://git.reviewboard.kde.org/r/123547/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">People  frequently request either "new instance" or "close window" for \
middle-click, so unfortunately I think this will have to be a config option and I \
won't accept a patch that only implements the one behavior.</p></pre>  <br />

<p>- Eike Hein</p>

<br />
<p>On April 28th, 2015, 8:45 p.m. UTC, Yoann Laissus wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Yoann Laissus.</div>

<p style="color: grey;"><i>Updated April 28, 2015, 8:45 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Currently, only the shortcut Shift + Left click is \
available. In KDE4, we had both.</p></pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Tested with classic task manager and the icon only \
one. Tested with all mouse button combinaisons and keyboard modifiers.</p></pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>applets/taskmanager/package/contents/ui/Task.qml <span style="color: \
grey">(f5fc723)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/123547/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============2032929247081567353==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 