[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 123224: KIO::suggestName suggests wrong name for some filenames
From: "Aleix Pol Gonzalez" <aleixpol () kde ! org>
Date: 2015-04-28 14:47:35
Message-ID: 20150428144735.14758.20318 () mimi ! kde ! org
[Download RAW message or body]
--===============6546214429557926608==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123224/#review79631
-----------------------------------------------------------
src/core/global.cpp (line 396)
<https://git.reviewboard.kde.org/r/123224/#comment54446>
you can change that for:
if (oldName.lastIndexOf('.') == 0)
src/core/global.cpp (line 412)
<https://git.reviewboard.kde.org/r/123224/#comment54447>
Also char overload.
- Aleix Pol Gonzalez
On April 28, 2015, 4:38 p.m., Ashish Bansal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123224/
> -----------------------------------------------------------
>
> (Updated April 28, 2015, 4:38 p.m.)
>
>
> Review request for KDE Frameworks, Plasma, Aleix Pol Gonzalez, and Arjun AK.
>
>
> Bugs: 341773
> https://bugs.kde.org/show_bug.cgi?id=341773
>
>
> Repository: kio
>
>
> Description
> -------
>
> For filenames like filename-1.6.tar.gz, KIO::suggestName suggests wrong \
> name(something like filename-1 2.6.tar.gz). Expected name: filename-1.6 (1).tar.gz
>
>
> Diffs
> -----
>
> autotests/globaltest.cpp ff8725d
> src/core/global.cpp f18ac10
>
> Diff: https://git.reviewboard.kde.org/r/123224/diff/
>
>
> Testing
> -------
>
> Works fine!
>
>
> Thanks,
>
> Ashish Bansal
>
>
--===============6546214429557926608==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123224/">https://git.reviewboard.kde.org/r/123224/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/123224/diff/3/?file=363223#file363223line407" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/core/global.cpp</a> <span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QUrl \
KIO::upUrl(const QUrl &url)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">407</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> \
<span class="p">(</span><span class="n">index</span> <span class="o">!=</span> <span \
class="o">-</span><span class="mi">1</span><span class="p">)</span> <span \
class="p">{</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">396</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span \
class="p">(</span><span class="n">oldName</span><span class="p">.</span><span \
class="n">startsWith</span><span class="p">(</span><span \
class="s">"."</span><span class="p">)</span> <span \
class="o">&&</span> <span class="n">oldName</span><span \
class="p">.</span><span class="n">count</span><span class="p">(</span><span \
class="s">"."</span><span class="p">)</span> <span class="o">==</span> \
<span class="mi">1</span><span class="p">)</span> <span class="p">{</span></pre></td> \
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">you \
can change that for: if (oldName.lastIndexOf('.') == 0)</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/123224/diff/3/?file=363223#file363223line423" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/core/global.cpp</a> <span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QUrl \
KIO::upUrl(const QUrl &url)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">418</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">412</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">basename</span> <span class="o">=</span> <span \
class="n">basename</span><span class="p">.</span><span class="n">section</span><span \
class="p">(</span><span class="n">QString</span><span class="p">(),</span> <span \
class="mi">0</span><span class="p">,</span> <span class="n">start</span><span \
class="p">)</span> <span class="o">+</span> <span class="s">"("</span> \
<span class="o">+</span> <span class="n">number</span> <span class="o">+</span> <span \
class="s">")"</span><span class="p">;</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Also \
char overload.</p></pre> </div>
</div>
<br />
<p>- Aleix Pol Gonzalez</p>
<br />
<p>On April 28th, 2015, 4:38 p.m. CEST, Ashish Bansal wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks, Plasma, Aleix Pol Gonzalez, and Arjun \
AK.</div> <div>By Ashish Bansal.</div>
<p style="color: grey;"><i>Updated April 28, 2015, 4:38 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=341773">341773</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kio
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">For filenames like filename-1.6.tar.gz, \
KIO::suggestName suggests wrong name(something like filename-1 2.6.tar.gz). Expected \
name: filename-1.6 (1).tar.gz</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Works fine!</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/globaltest.cpp <span style="color: grey">(ff8725d)</span></li>
<li>src/core/global.cpp <span style="color: grey">(f18ac10)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123224/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6546214429557926608==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic