[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 123529: update kmenuedit docbook and screenshots to plasma 5.3
From: Sebastian_Kügler <sebas () kde ! org>
Date: 2015-04-28 14:21:30
Message-ID: 20150428142130.14758.62766 () mimi ! kde ! org
[Download RAW message or body]
--===============4836454237751274848==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123529/#review79623
-----------------------------------------------------------
doc/index.docbook (line 182)
<https://git.reviewboard.kde.org/r/123529/#comment54408>
~/.local is the XDG default, ~/.local5 was what we used during KF5 development. \
Ultimately, it dependso on what the user set.
Same for the following lines.
Env vars seem to refer to a custom set XDG path, otherwise it looks good to me.
- Sebastian Kügler
On April 27, 2015, 1:14 p.m., Burkhard Lück wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123529/
> -----------------------------------------------------------
>
> (Updated April 27, 2015, 1:14 p.m.)
>
>
> Review request for Documentation and Plasma.
>
>
> Repository: kmenuedit
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> doc/done.png 202b4e0
> doc/index.docbook ebc1e9d
> doc/selectinternet.png deeb67c
>
> Diff: https://git.reviewboard.kde.org/r/123529/diff/
>
>
> Testing
> -------
>
> builds
>
>
> Thanks,
>
> Burkhard Lück
>
>
--===============4836454237751274848==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123529/">https://git.reviewboard.kde.org/r/123529/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/123529/diff/1/?file=363742#file363742line185" \
style="color: black; font-weight: bold; text-decoration: \
underline;">doc/index.docbook</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">185</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; \
"><filename>$<envar>HOME</envar>/.config/menus/applications-kmenuedit.menu</filename></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px \
solid #C0C0C0;" align="right"><font size="2">182</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"><filename>$<envar>HOME</envar>/.config<span \
class="hl">5</span>/menus/applications-kmenuedit.menu</filename></pre></td> \
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">~/.local is the XDG default, ~/.local5 was what we used during KF5 \
development. Ultimately, it dependso on what the user set.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Same \
for the following lines.</p></pre> </div>
</div>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Env \
vars seem to refer to a custom set XDG path, otherwise it looks good to me.</p></pre>
<p>- Sebastian Kügler</p>
<br />
<p>On April 27th, 2015, 1:14 p.m. UTC, Burkhard Lück wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Documentation and Plasma.</div>
<div>By Burkhard Lück.</div>
<p style="color: grey;"><i>Updated April 27, 2015, 1:14 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kmenuedit
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">see summary</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">builds</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>doc/done.png <span style="color: grey">(202b4e0)</span></li>
<li>doc/index.docbook <span style="color: grey">(ebc1e9d)</span></li>
<li>doc/selectinternet.png <span style="color: grey">(deeb67c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123529/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4836454237751274848==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic