[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 123530: Improve interactivity for the user icon and search field in kickoff
From: Lukáš Tinkl <lukas () kde ! org>
Date: 2015-04-28 13:36:17
Message-ID: 20150428133617.14758.96655 () mimi ! kde ! org
[Download RAW message or body]
--===============3696810706612366062==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123530/
-----------------------------------------------------------
(Updated April 28, 2015, 1:36 p.m.)
Status
------
This change has been marked as submitted.
Review request for Plasma and KDE Usability.
Changes
-------
Submitted with commit bae60a355524ca6b88d87aed28d7ecb002369777 by Lukáš Tinkl to branch master.
Repository: plasma-desktop
Description
-------
This patch makes the user icon and search field clickable. Upon clicking the former, the User Account kcm \
is opened, in the latter case the search field gets visible and activated.
Diffs
-----
applets/kickoff/package/contents/ui/FullRepresentation.qml 15dde96
applets/kickoff/package/contents/ui/Header.qml dfabbe5
Diff: https://git.reviewboard.kde.org/r/123530/diff/
Testing
-------
Everything works as expected, pressing Esc either cancels the search and/or closes the menu popup.
Thanks,
Lukáš Tinkl
--===============3696810706612366062==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123530/">https://git.reviewboard.kde.org/r/123530/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; \
-moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma and KDE Usability.</div>
<div>By Lukáš Tinkl.</div>
<p style="color: grey;"><i>Updated April 28, 2015, 1:36 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Submitted with commit \
bae60a355524ca6b88d87aed28d7ecb002369777 by Lukáš Tinkl to branch master.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch makes the user icon and search \
field clickable. Upon clicking the former, the User Account kcm is opened, in the latter case the search \
field gets visible and activated.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Everything works as expected, pressing Esc \
either cancels the search and/or closes the menu popup.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/kickoff/package/contents/ui/FullRepresentation.qml <span style="color: \
grey">(15dde96)</span></li>
<li>applets/kickoff/package/contents/ui/Header.qml <span style="color: grey">(dfabbe5)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123530/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3696810706612366062==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic