--===============8351191947279173908== Content-Type: multipart/alternative; boundary="===============7283198104276012678==" --===============7283198104276012678== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123540/ ----------------------------------------------------------- (Updated April 28, 2015, 9:48 a.m.) Status ------ This change has been marked as submitted. Review request for KDE Frameworks and Plasma. Changes ------- Submitted with commit 2a8002d00713a7768eae3fde215efeadfe1aaa8d by Martin Klapetek to branch master. Bugs: 345973 https://bugs.kde.org/show_bug.cgi?id=345973 Repository: knotifications Description ------- This patch checks if the properties being set are actually changed before emitting the update signal, which would cause a re-emit of the notification. Furthermore, NotifyByPopup now no longer changes the KNotification object when the server does not support certain capabilities but only does local checking and modifications. This fixes KNotification use with Ubuntu's NotifyOSD. Diffs ----- src/knotification.cpp afac82f src/notifybypopup.cpp 316ff2b Diff: https://git.reviewboard.kde.org/r/123540/diff/ Testing ------- Before this patch there was a continous loop of setting empty actions because the server does not support them -> triggers update -> triggers setting empty actions -> triggers update -> and so on. This made the notification popup look stuck and would block all other notifications from appearing (NotifyOSD supports only one popup at a time). Now everything behaves correctly. Thanks, Martin Klapetek --===============7283198104276012678== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123540/

This change has been marked as submitted.

Review request for KDE Frameworks and Plasma.
By Martin Klapetek.

Updated April 28, 2015, 9:48 a.m.

Changes

Submitted with commit 2a8002d00713a7768eae3fde215efeadfe1aaa8d by Martin Klapetek to branch master.
Bugs: 345973
Repository: knotifications

Description 

This patch checks if the properties being set are actually changed before emitting the update signal, which would cause a re-emit of the notification.


Furthermore, NotifyByPopup now no longer changes the KNotification object when the server does not support certain capabilities but only does local checking and modifications.


This fixes KNotification use with Ubuntu's NotifyOSD.

Testing 

Before this patch there was a continous loop of setting empty actions because the server does not support them -> triggers update -> triggers setting empty actions -> triggers update -> and so on. This made the notification popup look stuck and would block all other notifications from appearing (NotifyOSD supports only one popup at a time).


Now everything behaves correctly.

Diffs

  • src/knotification.cpp (afac82f)
  • src/notifybypopup.cpp (316ff2b)

View Diff
--===============7283198104276012678==-- --===============8351191947279173908== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============8351191947279173908==--