[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 123530: Improve interactivity for the user icon and search field in kickoff
From: Lukáš Tinkl <lukas () kde ! org>
Date: 2015-04-28 3:08:35
Message-ID: 20150428030835.14758.71452 () mimi ! kde ! org
[Download RAW message or body]
--===============6468528043468954095==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On Dub. 27, 2015, 4:56 odp., David Edmundson wrote:
> > Personally I don't think anyone needs to open the accounts KCM so often we need \
> > to link to it. I suspect it'll get more accidental opens than legit ones.
> > The other changes seems good though.
>
> Lukáš Tinkl wrote:
> I for one would expect it to be interactive, and it closely matches what Windows \
> (and Gnome Shell too afaik) does.
> Thomas Pfeiffer wrote:
> By "User Account kcm" you mean the "Password and User Account" kcm, right? I think \
> that's okay, as it lets you edit the information that is shown there. If we get \
> lots of bug reports form people accidentally clicking it, we might reconsider.
Yup exactly, it lets you edit what is being shown there - the user name and your \
face/icon.
- Lukáš
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123530/#review79576
-----------------------------------------------------------
On Dub. 27, 2015, 7:04 odp., Lukáš Tinkl wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123530/
> -----------------------------------------------------------
>
> (Updated Dub. 27, 2015, 7:04 odp.)
>
>
> Review request for Plasma and KDE Usability.
>
>
> Repository: plasma-desktop
>
>
> Description
> -------
>
> This patch makes the user icon and search field clickable. Upon clicking the \
> former, the User Account kcm is opened, in the latter case the search field gets \
> visible and activated.
>
> Diffs
> -----
>
> applets/kickoff/package/contents/ui/FullRepresentation.qml 15dde96
> applets/kickoff/package/contents/ui/Header.qml dfabbe5
>
> Diff: https://git.reviewboard.kde.org/r/123530/diff/
>
>
> Testing
> -------
>
> Everything works as expected, pressing Esc either cancels the search and/or closes \
> the menu popup.
>
> Thanks,
>
> Lukáš Tinkl
>
>
--===============6468528043468954095==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123530/">https://git.reviewboard.kde.org/r/123530/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On duben 27th, 2015, 4:56 odp. CEST, <b>David \
Edmundson</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Personally I don't think anyone needs to open the \
accounts KCM so often we need to link to it. I suspect it'll get more accidental \
opens than legit ones.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">The other changes seems good \
though.</p></pre> </blockquote>
<p>On duben 27th, 2015, 6:16 odp. CEST, <b>Lukáš Tinkl</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I for \
one would expect it to be interactive, and it closely matches what Windows (and Gnome \
Shell too afaik) does.</p></pre> </blockquote>
<p>On duben 28th, 2015, 12:19 dop. CEST, <b>Thomas Pfeiffer</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">By \
"User Account kcm" you mean the "Password and User Account" kcm, right? I think \
that's okay, as it lets you edit the information that is shown there. If we get lots \
of bug reports form people accidentally clicking it, we might reconsider.</p></pre> \
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yup \
exactly, it lets you edit what is being shown there - the user name and your \
face/icon.</p></pre> <br />
<p>- Lukáš</p>
<br />
<p>On duben 27th, 2015, 7:04 odp. CEST, Lukáš Tinkl wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma and KDE Usability.</div>
<div>By Lukáš Tinkl.</div>
<p style="color: grey;"><i>Updated Dub. 27, 2015, 7:04 odp.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This patch makes the user icon and search field \
clickable. Upon clicking the former, the User Account kcm is opened, in the latter \
case the search field gets visible and activated.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Everything works as expected, pressing Esc either \
cancels the search and/or closes the menu popup.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/kickoff/package/contents/ui/FullRepresentation.qml <span style="color: \
grey">(15dde96)</span></li>
<li>applets/kickoff/package/contents/ui/Header.qml <span style="color: \
grey">(dfabbe5)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123530/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6468528043468954095==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic