From kde-panel-devel Mon Apr 27 18:10:46 2015 From: "Kai Uwe Broulik" Date: Mon, 27 Apr 2015 18:10:46 +0000 To: kde-panel-devel Subject: Re: Review Request 123502: Manually keep track of jobs sources Message-Id: <20150427181046.14758.80216 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=143015979001390 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============5694096735821780487==" --===============5694096735821780487== Content-Type: multipart/alternative; boundary="===============6152715410749626655==" --===============6152715410749626655== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123502/ ----------------------------------------------------------- (Updated April 27, 2015, 6:10 p.m.) Status ------ This change has been marked as submitted. Review request for Plasma and Martin Klapetek. Changes ------- Submitted with commit bc5c47537f3bbb706b3fe7af66508f5ef2fadc6e by Kai Uwe Broulik to branch Plasma/5.3. Bugs: 346673 https://bugs.kde.org/show_bug.cgi?id=346673 Repository: plasma-workspace Description ------- DataSource sources is a QStringList property which means changes within cannot be tracked causing all the job delegates to be destroyed and re-created when sourcesChanged it emitted. This is pretty wasteful but also causes the delegate to lose their sate (eg. details expanded). Diffs ----- applets/notifications/package/contents/ui/JobDelegate.qml 709b7fd applets/notifications/package/contents/ui/Jobs.qml 6ecf366 Diff: https://git.reviewboard.kde.org/r/123502/diff/ Testing ------- Adding, removing and pausing jobs works as expected, when a job appears or disappears the other delegates keep their state. The only slight imperfection is now that the indeterminate state of multiple jobs is no longer move in sync because the items are no longer created at the same time. Thanks, Kai Uwe Broulik --===============6152715410749626655== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123502/

This change has been marked as submitted.

Review request for Plasma and Martin Klapetek.

By Kai Uwe Broulik.

Updated April 27, 2015, 6:10 p.m.

Changes

Submitted with commit bc5c47537f3bbb706b3fe7af66508f5ef2fadc6e by Kai Uwe Broulik to branch Plasma/5.3.

Bugs: 346673

Repository: plasma-workspace

Description

DataSource sources is a QStringList property which means changes within cannot be tracked causing all the job delegates to be destroyed and re-created when sourcesChanged it emitted. This is pretty wasteful but also causes the delegate to lose their sate (eg. details expanded).

Testing

Adding, removing and pausing jobs works as expected, when a job appears or disappears the other delegates keep their state. The only slight imperfection is now that the indeterminate state of multiple jobs is no longer move in sync because the items are no longer created at the same time.

Diffs

applets/notifications/package/contents/ui/JobDelegate.qml (709b7fd)
applets/notifications/package/contents/ui/Jobs.qml (6ecf366)

--===============6152715410749626655==-- --===============5694096735821780487== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============5694096735821780487==--