[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 123506: Match window switch dialog borders with addwidgets/switch activity
From: "David Edmundson" <david () davidedmundson ! co ! uk>
Date: 2015-04-27 11:22:35
Message-ID: 20150427112235.14758.18398 () mimi ! kde ! org
[Download RAW message or body]
--===============8848029792027566403==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On April 27, 2015, 5:54 a.m., Martin Gräßlin wrote:
> > will this also look good if it's at the left edge of a right screen in a \
> > multi-screen environment?
>
> David Edmundson wrote:
> yes as almost all monitors have kind of bezel
>
> Thomas Lübking wrote:
> I think Martin meant "when midst of your workspace" - you basically get a vertical \
> bar that cuts your workspace in two halfs while the items you control (windows) \
> flow across both areas.
> David Edmundson wrote:
> This patch doesn't change the actual position of anything, it just adjusts which \
> borders are shown on the frame round that dialog.
> Martin Gräßlin wrote:
> I think you don't get what I mean. Consider two screens in a left-to-right layout. \
> If it opens on the left screen, it'll be OK, but what if it opens on the right \
> screen? Will it then also look ok, even if it is not at an actual screen border?
You have a multiple monitor system, right click on the right screen and click add \
widgets. It will look like that.
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123506/#review79549
-----------------------------------------------------------
On April 26, 2015, 9:41 p.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123506/
> -----------------------------------------------------------
>
> (Updated April 26, 2015, 9:41 p.m.)
>
>
> Review request for kwin and Plasma.
>
>
> Bugs: 345614
> https://bugs.kde.org/show_bug.cgi?id=345614
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> BUG: 345614
>
>
> Diffs
> -----
>
> lookandfeel/contents/windowswitcher/WindowSwitcher.qml \
> e4a46366c2a4e157860f55d2cb0e3781a239cb66
> Diff: https://git.reviewboard.kde.org/r/123506/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> David Edmundson
>
>
--===============8848029792027566403==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123506/">https://git.reviewboard.kde.org/r/123506/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On April 27th, 2015, 5:54 a.m. UTC, <b>Martin \
Gräßlin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">will this also look good if it's at the left edge of a \
right screen in a multi-screen environment?</p></pre> </blockquote>
<p>On April 27th, 2015, 8:28 a.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">yes \
as almost all monitors have kind of bezel</p></pre> </blockquote>
<p>On April 27th, 2015, 8:38 a.m. UTC, <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
think Martin meant "when midst of your workspace" - you basically get a vertical bar \
that cuts your workspace in two halfs while the items you control (windows) flow \
across both areas.</p></pre> </blockquote>
<p>On April 27th, 2015, 11:10 a.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This \
patch doesn't change the actual position of anything, it just adjusts which borders \
are shown on the frame round that dialog.</p></pre> </blockquote>
<p>On April 27th, 2015, 11:14 a.m. UTC, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
think you don't get what I mean. Consider two screens in a left-to-right layout. If \
it opens on the left screen, it'll be OK, but what if it opens on the right screen? \
Will it then also look ok, even if it is not at an actual screen border?</p></pre> \
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">You \
have a multiple monitor system, right click on the right screen and click add \
widgets. It will look like that.</p></pre> <br />
<p>- David</p>
<br />
<p>On April 26th, 2015, 9:41 p.m. UTC, David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for kwin and Plasma.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated April 26, 2015, 9:41 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=345614">345614</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">BUG: 345614</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>lookandfeel/contents/windowswitcher/WindowSwitcher.qml <span style="color: \
grey">(e4a46366c2a4e157860f55d2cb0e3781a239cb66)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123506/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============8848029792027566403==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic