'Re: Review Request 123502: Manually keep track of jobs sources'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 123502: Manually keep track of jobs sources
From:       "Martin Klapetek" <martin.klapetek () gmail ! com>
Date:       2015-04-27 8:27:16
Message-ID: 20150427082716.14758.85955 () mimi ! kde ! org
[Download RAW message or body]

--===============3285674974006375357==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123502/#review79554
-----------------------------------------------------------

Looks good

> indeterminate state of multiple jobs is no longer move in sync

If this is desired, the indet. state could be reset on all the jobs that are in that \
state (like set it again or set different state and right back to indeterminate) when \
new indet. job appears

- Martin Klapetek

On April 26, 2015, 7:24 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123502/
> -----------------------------------------------------------
> 
> (Updated April 26, 2015, 7:24 p.m.)
> 
> 
> Review request for Plasma and Martin Klapetek.
> 
> 
> Bugs: 346673
> https://bugs.kde.org/show_bug.cgi?id=346673
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> DataSource sources is a QStringList property which means changes within cannot be \
> tracked causing all the job delegates to be destroyed and re-created when \
> sourcesChanged it emitted. This is pretty wasteful but also causes the delegate to \
> lose their sate (eg. details expanded). 
> 
> Diffs
> -----
> 
> applets/notifications/package/contents/ui/JobDelegate.qml 709b7fd 
> applets/notifications/package/contents/ui/Jobs.qml 6ecf366 
> 
> Diff: https://git.reviewboard.kde.org/r/123502/diff/
> 
> 
> Testing
> -------
> 
> Adding, removing and pausing jobs works as expected, when a job appears or \
> disappears the other delegates keep their state. The only slight imperfection is \
> now that the indeterminate state of multiple jobs is no longer move in sync because \
> the items are no longer created at the same time. 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
> 

--===============3285674974006375357==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/123502/">https://git.reviewboard.kde.org/r/123502/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Looks \
good</p> <blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: \
1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;"> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">indeterminate state of multiple jobs is no longer move in sync</p> \
</blockquote> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">If this is desired, the indet. state could be reset on \
all the jobs that are in that state (like set it again or set different state and \
right back to indeterminate) when new indet. job appears</p></pre>  <br />

<p>- Martin Klapetek</p>

<br />
<p>On April 26th, 2015, 7:24 p.m. CEST, Kai Uwe Broulik wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma and Martin Klapetek.</div>
<div>By Kai Uwe Broulik.</div>

<p style="color: grey;"><i>Updated April 26, 2015, 7:24 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://bugs.kde.org/show_bug.cgi?id=346673">346673</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">DataSource sources is a QStringList property which \
means changes within cannot be tracked causing all the job delegates to be destroyed \
and re-created when sourcesChanged it emitted. This is pretty wasteful but also \
causes the delegate to lose their sate (eg. details expanded).</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Adding, removing and pausing jobs works as expected, \
when a job appears or disappears the other delegates keep their state. The only \
slight imperfection is now that the indeterminate state of multiple jobs is no longer \
move in sync because the items are no longer created at the same time.</p></pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>applets/notifications/package/contents/ui/JobDelegate.qml <span style="color: \
grey">(709b7fd)</span></li>

 <li>applets/notifications/package/contents/ui/Jobs.qml <span style="color: \
grey">(6ecf366)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/123502/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============3285674974006375357==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 