From kde-panel-devel Sun Apr 26 17:10:16 2015 From: "Kai Uwe Broulik" Date: Sun, 26 Apr 2015 17:10:16 +0000 To: kde-panel-devel Subject: Re: Review Request 123501: Improve suspended job appearance Message-Id: <20150426171016.14758.22137 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=143006823011611 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============4154782395439158191==" --===============4154782395439158191== Content-Type: multipart/alternative; boundary="===============4525580415051075876==" --===============4525580415051075876== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123501/ ----------------------------------------------------------- (Updated April 26, 2015, 5:10 p.m.) Status ------ This change has been marked as submitted. Review request for Plasma and Martin Klapetek. Changes ------- Submitted with commit 2b503ba920e44f629fe83ec6a1382239dcb7c6a2 by Kai Uwe Broulik to branch master. Repository: plasma-workspace Description ------- Today I noticed that a paused job is not really obvious, other than the tiny pause button turning into a play button. This adds "(Paused)" to the title, such as "Copying (Paused)" in that case. Also turns off the indeterminate animation then since it's not really doing anything. Diffs ----- applets/notifications/package/contents/ui/JobDelegate.qml f3f091d Diff: https://git.reviewboard.kde.org/r/123501/diff/ Testing ------- Works fine Thanks, Kai Uwe Broulik --===============4525580415051075876== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123501/

This change has been marked as submitted.

Review request for Plasma and Martin Klapetek.

By Kai Uwe Broulik.

Updated April 26, 2015, 5:10 p.m.

Changes

Submitted with commit 2b503ba920e44f629fe83ec6a1382239dcb7c6a2 by Kai Uwe Broulik to branch master.

Repository: plasma-workspace

Description

Today I noticed that a paused job is not really obvious, other than the tiny pause button turning into a play button. This adds "(Paused)" to the title, such as "Copying (Paused)" in that case. Also turns off the indeterminate animation then since it's not really doing anything.

Testing

Works fine

Diffs

applets/notifications/package/contents/ui/JobDelegate.qml (f3f091d)

View Diff

--===============4525580415051075876==-- --===============4154782395439158191== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============4154782395439158191==--