[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 123475: Execute KAuth jobs for brightness control in an async manner
From: Martin_Gräßlin <mgraesslin () kde ! org>
Date: 2015-04-24 6:25:09
Message-ID: 20150424062509.5446.55020 () mimi ! kde ! org
[Download RAW message or body]
--===============4113272933338554103==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On April 23, 2015, 1:32 p.m., Aleix Pol Gonzalez wrote:
> > daemon/backends/upower/powerdevilupowerbackend.cpp, line 161
> > <https://git.reviewboard.kde.org/r/123475/diff/1/?file=362676#file362676line161>
> >
> > Is it fine to use exec() here?
no, I missed that one :-(
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123475/#review79375
-----------------------------------------------------------
On April 23, 2015, 1:05 p.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123475/
> -----------------------------------------------------------
>
> (Updated April 23, 2015, 1:05 p.m.)
>
>
> Review request for Plasma, Solid and Kai Uwe Broulik.
>
>
> Repository: powerdevil
>
>
> Description
> -------
>
> KJob::exec is dangerous and caused freezes on my system. Thus this change
> to remodel the interaction in an async way.
>
>
> Diffs
> -----
>
> daemon/backends/upower/powerdevilupowerbackend.h \
> 1c4dd592f0a3cb07b9821c7f82c89517d599635a \
> daemon/backends/upower/powerdevilupowerbackend.cpp \
> 87b9cc7b7db1b6a6f5b31263cd3832715c497328
> Diff: https://git.reviewboard.kde.org/r/123475/diff/
>
>
> Testing
> -------
>
> kded5 no longer freezes. But I'm not sure whether the init gets finished: is there \
> a way to easily verify whether the module loaded completely?
>
> Thanks,
>
> Martin Gräßlin
>
>
--===============4113272933338554103==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123475/">https://git.reviewboard.kde.org/r/123475/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On April 23rd, 2015, 1:32 p.m. CEST, <b>Aleix Pol \
Gonzalez</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/123475/diff/1/?file=362676#file362676line161" \
style="color: black; font-weight: bold; text-decoration: \
underline;">daemon/backends/upower/powerdevilupowerbackend.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
PowerDevilUPowerBackend::init()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">161</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">if</span> <span class="p">(</span><span class="n">syspathJob</span><span \
class="o">-></span><span class="n">exec</span><span class="p">())</span> <span \
class="p">{</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">156</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span \
class="p">(</span><span class="n"><span \
class="hl">brightnessMax</span>Job</span><span class="o">-></span><span \
class="n">exec</span><span class="p">())</span> <span class="p">{</span></pre></td> \
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Is it \
fine to use exec() here?</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">no, I missed that one :-(</p></pre> <br />
<p>- Martin</p>
<br />
<p>On April 23rd, 2015, 1:05 p.m. CEST, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma, Solid and Kai Uwe Broulik.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated April 23, 2015, 1:05 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
powerdevil
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">KJob::exec is dangerous and caused freezes on my system. Thus this \
change to remodel the interaction in an async way.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">kded5 no longer freezes. But I'm not sure whether the \
init gets finished: is there a way to easily verify whether the module loaded \
completely?</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>daemon/backends/upower/powerdevilupowerbackend.h <span style="color: \
grey">(1c4dd592f0a3cb07b9821c7f82c89517d599635a)</span></li>
<li>daemon/backends/upower/powerdevilupowerbackend.cpp <span style="color: \
grey">(87b9cc7b7db1b6a6f5b31263cd3832715c497328)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123475/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4113272933338554103==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic