'Re: Review Request 123411: Protect X11 calls in the Pager plasmoid to prevent plasmashell from crash'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 123411: Protect X11 calls in the Pager plasmoid to prevent plasmashell from crash
From:       "Nerdopolis Turfwalker" <bluescreen_avenger () verizon ! net>
Date:       2015-04-22 5:55:12
Message-ID: 20150422055512.5446.14499 () mimi ! kde ! org
[Download RAW message or body]

--===============2015136387326425389==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123411/
-----------------------------------------------------------

(Updated April 22, 2015, 5:55 a.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma.

Changes
-------

Submitted with commit dd635224de346c1e87a68139301128834a6f0677 by Martin Gräßlin on \
behalf of Nerdopolis Turfwalker to branch master.

Repository: plasma-desktop

Description
-------

Protect X11 calls in the Pager plasmoid to prevent plasmashell from crashing in \
Wayland

Diffs
-----

  applets/pager/plugin/pager.h 78d461d2554e4885721da3d2eff82151c97f9305 
  applets/pager/plugin/pager.cpp 22c6ca2747f297dc3d37d02b46cb33196e64b1e0 

Diff: https://git.reviewboard.kde.org/r/123411/diff/

Testing
-------

Ran plasmoidviewer -a org.kde.plasma.pager in with QT_QPA_PLATFORM=wayland got no \
crash from plasmoid viewer.

Started an Xephyr session, set QT_QPA_PLATFORM=xcb and DISPLAY=:1, started kwin_x11, \
and then plasmoidviewer -a org.kde.plasma.pager and had full functionality.

Thanks,

Nerdopolis Turfwalker

--===============2015136387326425389==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/123411/">https://git.reviewboard.kde.org/r/123411/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Nerdopolis Turfwalker.</div>

<p style="color: grey;"><i>Updated April 22, 2015, 5:55 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit dd635224de346c1e87a68139301128834a6f0677 by Martin \
Gräßlin on behalf of Nerdopolis Turfwalker to branch master.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Protect X11 calls in the Pager plasmoid to prevent \
plasmashell from crashing in Wayland</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Ran plasmoidviewer -a org.kde.plasma.pager in with \
QT_QPA_PLATFORM=wayland got no crash from plasmoid viewer.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Started an Xephyr session, set QT_QPA_PLATFORM=xcb and DISPLAY=:1, started \
kwin_x11, and then plasmoidviewer -a org.kde.plasma.pager and had full \
functionality.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>applets/pager/plugin/pager.h <span style="color: \
grey">(78d461d2554e4885721da3d2eff82151c97f9305)</span></li>

 <li>applets/pager/plugin/pager.cpp <span style="color: \
grey">(22c6ca2747f297dc3d37d02b46cb33196e64b1e0)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/123411/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============2015136387326425389==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 