'Re: Review Request 123448: Message dialog should be shown before we change a category in the "Deskto'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 123448: Message dialog should be shown before we change a category in the "Deskto
From:       "Antonis Tsiapaliokas" <antonis.tsiapaliokas () kde ! org>
Date:       2015-04-21 20:30:03
Message-ID: 20150421203003.5446.62812 () mimi ! kde ! org
[Download RAW message or body]

--===============2220966835098786052==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123448/
-----------------------------------------------------------

(Updated April 21, 2015, 8:30 p.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma.

Changes
-------

Submitted with commit 8d6a08416f95ce8b346d205fd4bdab3692ce24de by Antonis \
Tsiapaliokas to branch master.

Bugs: 346431
    https://bugs.kde.org/show_bug.cgi?id=346431

Repository: plasma-desktop

Description
-------

The "Wallpaper" and the  "Mouse Actions" category should always show
the message dialog if they have pending changes.

Futhermore there is no need to check if there are pending changes,
since we already know that because of the "Apply" Button.
So we don't need the  "configurationHasChanged" function anymore.

Diffs
-----

  desktoppackage/contents/configuration/AppletConfiguration.qml 9e61cc0 
  desktoppackage/contents/configuration/ConfigCategoryDelegate.qml 68301ad 

Diff: https://git.reviewboard.kde.org/r/123448/diff/

Testing
-------

Thanks,

Antonis Tsiapaliokas

--===============2220966835098786052==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/123448/">https://git.reviewboard.kde.org/r/123448/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Antonis Tsiapaliokas.</div>

<p style="color: grey;"><i>Updated April 21, 2015, 8:30 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 8d6a08416f95ce8b346d205fd4bdab3692ce24de by \
Antonis Tsiapaliokas to branch master.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://bugs.kde.org/show_bug.cgi?id=346431">346431</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The "Wallpaper" and the  "Mouse Actions" category \
should always show the message dialog if they have pending changes.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Futhermore there is no need to check if there are \
pending changes, since we already know that because of the "Apply" Button.
So we don't need the  "configurationHasChanged" function anymore.</p></pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>desktoppackage/contents/configuration/AppletConfiguration.qml <span \
style="color: grey">(9e61cc0)</span></li>

 <li>desktoppackage/contents/configuration/ConfigCategoryDelegate.qml <span \
style="color: grey">(68301ad)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/123448/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============2220966835098786052==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 