[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 123420: Timer: added tooltip for compact mode (e.g. in panel) and full mode
From: "Bernhard Friedreich" <friesoft () gmail ! com>
Date: 2015-04-21 19:37:41
Message-ID: 20150421193741.5446.16169 () mimi ! kde ! org
[Download RAW message or body]
--===============2522109835231009408==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123420/
-----------------------------------------------------------
(Updated April 21, 2015, 7:37 p.m.)
Status
------
This change has been marked as submitted.
Review request for Plasma.
Changes
-------
Submitted with commit 8f09567eae260a1241e65e2ec2a9e9ba28bbf0ad by Bernhard Friedreich \
to branch master.
Repository: kdeplasma-addons
Description
-------
Compact Mode: shows the name of the timer and the remaining seconds
Using the tooltip it is possible to glance at the timer without
opening the full representation by clicking
Full Mode: shows information that you can use the scroll wheel to
change the digits and choose from predefined timers using the
context menu
BUG: 259630
Added missing i18n for notifaction finished text
Diffs
-----
applets/timer/package/contents/ui/timer.qml \
2f7af4f3815b3c8a43e4a7b32d6a020cf3dc0848
Diff: https://git.reviewboard.kde.org/r/123420/diff/
Testing
-------
File Attachments
----------------
Compact mode running
https://git.reviewboard.kde.org/media/uploaded/files/2015/04/18/9b90a460-8808-49bd-969f-cedcc9251f32__tooltip_compact_mode_running.png
Compact mode
https://git.reviewboard.kde.org/media/uploaded/files/2015/04/18/f548efea-0635-4647-b9a3-6d2d4c497bfa__tooltip_compact_mode.png
Full mode running
https://git.reviewboard.kde.org/media/uploaded/files/2015/04/18/c7370926-e497-43f1-a254-8448e4ffbdf0__tooltip_full_mode_running.png
Full mode
https://git.reviewboard.kde.org/media/uploaded/files/2015/04/18/e4068531-ced8-4487-8b2e-d95b339d7e53__tooltip_full_mode.png
Compact mode with title and time already set
https://git.reviewboard.kde.org/media/uploaded/files/2015/04/18/4d574a75-d469-4f65-acb7-6961fe567782__tooltip_compact_mode_title_set.png
Thanks,
Bernhard Friedreich
--===============2522109835231009408==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123420/">https://git.reviewboard.kde.org/r/123420/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Bernhard Friedreich.</div>
<p style="color: grey;"><i>Updated April 21, 2015, 7:37 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 8f09567eae260a1241e65e2ec2a9e9ba28bbf0ad by \
Bernhard Friedreich to branch master.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeplasma-addons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Compact Mode: shows the name of the timer and the remaining seconds \
Using the tooltip it is possible to glance at the timer without opening the full \
representation by clicking
Full Mode: shows information that you can use the scroll wheel to
change the digits and choose from predefined timers using the
context menu
BUG: 259630
Added missing i18n for notifaction finished text</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/timer/package/contents/ui/timer.qml <span style="color: \
grey">(2f7af4f3815b3c8a43e4a7b32d6a020cf3dc0848)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123420/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/04/18/9b90a460-8808-49bd-969f-cedcc9251f32__tooltip_compact_mode_running.png">Compact \
mode running</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/04/18/f548efea-0635-4647-b9a3-6d2d4c497bfa__tooltip_compact_mode.png">Compact \
mode</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/04/18/c7370926-e497-43f1-a254-8448e4ffbdf0__tooltip_full_mode_running.png">Full \
mode running</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/04/18/e4068531-ced8-4487-8b2e-d95b339d7e53__tooltip_full_mode.png">Full \
mode</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/04/18/4d574a75-d469-4f65-acb7-6961fe567782__tooltip_compact_mode_title_set.png">Compact \
mode with title and time already set</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============2522109835231009408==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic