[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 123381: Fallback to AttentionIcon for SNI when animations are disabled
From: "Martin Klapetek" <martin.klapetek () gmail ! com>
Date: 2015-04-16 12:05:52
Message-ID: 20150416120552.4623.92665 () mimi ! kde ! org
[Download RAW message or body]
--===============7938484245136012849==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On April 16, 2015, 1:43 p.m., Kai Uwe Broulik wrote:
> > I think we should always pulse, and if available, use the needs attention icon \
> > (but don't cycle between normal and attention icon)
>
> Martin Klapetek wrote:
> If you don't cycle it's quite easy to miss, so I think there'd be very little point \
> in just switching the icon (the purpose is to get your attention).
Ah I misunderstood. The slight problem I see with always using the attention icon for \
the pulse animation is that they are not necessarily covered by the plasma theme, so \
when it starts pulsing with attention icon, the icon can look completely different \
while simply pulsing the normal icon seems more consistent. Dunno.
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123381/#review79045
-----------------------------------------------------------
On April 16, 2015, 1:23 p.m., Martin Klapetek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123381/
> -----------------------------------------------------------
>
> (Updated April 16, 2015, 1:23 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> This returns the kde4 behavior of simply switching the icon for attention icon when \
> animations are disabled.
> I don't think that always using the attention icon with the pulse animation looks \
> good, it looks like there's too much going on. I believe it should be an either-or. \
> So I did it only as a fallback.
>
> Diffs
> -----
>
> applets/systemtray/package/contents/ui/StatusNotifierItem.qml 5380b09
> applets/systemtray/package/contents/ui/TaskDelegate.qml f2738bd
>
> Diff: https://git.reviewboard.kde.org/r/123381/diff/
>
>
> Testing
> -------
>
> I didn't test with animations off (I'm not sure how to set) so I just explicitly \
> enabled the timer and disabled the PulseAnimation. Works just like in the old \
> times.
>
> Thanks,
>
> Martin Klapetek
>
>
--===============7938484245136012849==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123381/">https://git.reviewboard.kde.org/r/123381/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On April 16th, 2015, 1:43 p.m. CEST, <b>Kai Uwe \
Broulik</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I think we should always pulse, and if available, use \
the needs attention icon (but don't cycle between normal and attention \
icon)</p></pre> </blockquote>
<p>On April 16th, 2015, 1:57 p.m. CEST, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">If \
you don't cycle it's quite easy to miss, so I think there'd be very little point in \
just switching the icon (the purpose is to get your attention).</p></pre> \
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ah I \
misunderstood. The slight problem I see with always using the attention icon for the \
pulse animation is that they are not necessarily covered by the plasma theme, so when \
it starts pulsing with attention icon, the icon can look completely different while \
simply pulsing the normal icon seems more consistent. Dunno.</p></pre> <br />
<p>- Martin</p>
<br />
<p>On April 16th, 2015, 1:23 p.m. CEST, Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated April 16, 2015, 1:23 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This returns the kde4 behavior of simply switching the \
icon for attention icon when animations are disabled.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
don't think that always using the attention icon with the pulse animation looks good, \
it looks like there's too much going on. I believe it should be an either-or. So I \
did it only as a fallback.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I didn't test with animations off (I'm not sure how to \
set) so I just explicitly enabled the timer and disabled the PulseAnimation. Works \
just like in the old times.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/systemtray/package/contents/ui/StatusNotifierItem.qml <span \
style="color: grey">(5380b09)</span></li>
<li>applets/systemtray/package/contents/ui/TaskDelegate.qml <span style="color: \
grey">(f2738bd)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123381/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7938484245136012849==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic