[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 123271: improve kickoff representation on vertical panels
From: "Kai Uwe Broulik" <kde () privat ! broulik ! de>
Date: 2015-04-07 9:43:53
Message-ID: 20150407094353.31692.97542 () mimi ! kde ! org
[Download RAW message or body]
--===============8319476404147363975==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123271/#review78604
-----------------------------------------------------------
What when I place it on the desktop? I'd like it to fill the entire room there. If I \
want a massive Kickoff button on my desktop, that's up to me :)
applets/kickoff/package/contents/ui/CompactRepresentation.qml (line 25)
<https://git.reviewboard.kde.org/r/123271/#comment53776>
You might as well just make the MouseArea the root item
applets/kickoff/package/contents/ui/CompactRepresentation.qml (line 28)
<https://git.reviewboard.kde.org/r/123271/#comment53774>
readonly property
applets/kickoff/package/contents/ui/CompactRepresentation.qml (lines 47 - 48)
<https://git.reviewboard.kde.org/r/123271/#comment53775>
Coding style: MouseArea {
applets/kickoff/package/contents/ui/CompactRepresentation.qml (line 50)
<https://git.reviewboard.kde.org/r/123271/#comment53777>
No semicolon at the end
- Kai Uwe Broulik
On April 6, 2015, 11:40 vorm., Mathias Kraus wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123271/
> -----------------------------------------------------------
>
> (Updated April 6, 2015, 11:40 vorm.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-desktop
>
>
> Description
> -------
>
> In vertical panels, the kickoff button is huge. This patch limits the size of the \
> kickoff button.
>
> Diffs
> -----
>
> applets/kickoff/package/contents/ui/CompactRepresentation.qml PRE-CREATION
> applets/kickoff/package/contents/ui/Kickoff.qml 33b49eb
>
> Diff: https://git.reviewboard.kde.org/r/123271/diff/
>
>
> Testing
> -------
>
> see screenshots
>
>
> File Attachments
> ----------------
>
> kickoff-horizontal-before
> https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/a4848ebd-8dd6-4e46-9f28-ab01fbe13cc6__kickoff-horizontal-before.png
> kickoff-horizontal-after
> https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/b6532939-498e-4c3d-85da-07c0a8162b2f__kickoff-horizontal-after.png
> kickoff-vertical-before
> https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/b71c4d86-dff3-4b2f-a11e-430bc59a732d__kickoff-vertical-before.png
> kickoff-vertical-after
> https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/55396e5a-1a2d-4523-87f8-4d9cd1d0f067__kickoff-vertical-after.png
>
>
> Thanks,
>
> Mathias Kraus
>
>
--===============8319476404147363975==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123271/">https://git.reviewboard.kde.org/r/123271/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">What \
when I place it on the desktop? I'd like it to fill the entire room there. If I want \
a massive Kickoff button on my desktop, that's up to me :)</p></pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/123271/diff/1/?file=360272#file360272line25" \
style="color: black; font-weight: bold; text-decoration: \
underline;">applets/kickoff/package/contents/ui/CompactRepresentation.qml</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">25</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="nx">Item</span> <span class="p">{</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">You \
might as well just make the MouseArea the root item</p></pre> </div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/123271/diff/1/?file=360272#file360272line28" \
style="color: black; font-weight: bold; text-decoration: \
underline;">applets/kickoff/package/contents/ui/CompactRepresentation.qml</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">28</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="nx">property</span> <span class="nx">bool</span> <span \
class="k">vertical:</span> <span class="p">(</span><span \
class="nx">plasmoid</span><span class="p">.</span><span class="nx">formFactor</span> \
<span class="o">==</span> <span class="nx">PlasmaCore</span><span \
class="p">.</span><span class="nx">Type</span><span class="p">.</span><span \
class="nx">Vertical</span><span class="p">)</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">readonly property</p></pre> </div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/123271/diff/1/?file=360272#file360272line47" \
style="color: black; font-weight: bold; text-decoration: \
underline;">applets/kickoff/package/contents/ui/CompactRepresentation.qml</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">47</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="nx">MouseArea</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">48</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="p">{</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Coding style: MouseArea {</p></pre> </div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/123271/diff/1/?file=360272#file360272line50" \
style="color: black; font-weight: bold; text-decoration: \
underline;">applets/kickoff/package/contents/ui/CompactRepresentation.qml</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">50</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="nx">property</span> <span class="nx">bool</span> <span \
class="k">wasExpanded:</span> <span class="kc">false</span><span \
class="p">;</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">No \
semicolon at the end</p></pre> </div>
</div>
<br />
<p>- Kai Uwe Broulik</p>
<br />
<p>On April 6th, 2015, 11:40 vorm. UTC, Mathias Kraus wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Mathias Kraus.</div>
<p style="color: grey;"><i>Updated April 6, 2015, 11:40 vorm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">In vertical panels, the kickoff button is huge. This \
patch limits the size of the kickoff button.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">see screenshots</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/kickoff/package/contents/ui/CompactRepresentation.qml <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>applets/kickoff/package/contents/ui/Kickoff.qml <span style="color: \
grey">(33b49eb)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123271/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/a4848ebd \
-8dd6-4e46-9f28-ab01fbe13cc6__kickoff-horizontal-before.png">kickoff-horizontal-before</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/b6532939 \
-498e-4c3d-85da-07c0a8162b2f__kickoff-horizontal-after.png">kickoff-horizontal-after</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/b71c4d86 \
-dff3-4b2f-a11e-430bc59a732d__kickoff-vertical-before.png">kickoff-vertical-before</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/55396e5a \
-1a2d-4523-87f8-4d9cd1d0f067__kickoff-vertical-after.png">kickoff-vertical-after</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============8319476404147363975==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic