'Re: Review Request 122842: Allow selecting notifications position on screen'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 122842: Allow selecting notifications position on screen
From:       "Martin Klapetek" <martin.klapetek () gmail ! com>
Date:       2015-04-06 18:09:23
Message-ID: 20150406180923.31692.8013 () mimi ! kde ! org
[Download RAW message or body]

--===============9114472531229083095==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122842/
-----------------------------------------------------------

(Updated April 6, 2015, 6:09 p.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma and KDE Usability.

Changes
-------

Submitted with commit 9429c845ae3fee1d65b026b2d496aae1305db232 by Martin Klapetek to \
branch master.

Bugs: 344841
    https://bugs.kde.org/show_bug.cgi?id=344841

Repository: plasma-workspace

Description
-------

Allows to select each corner and top or bottom edges of the screen.

The radio selection thing is currently a bit ugly and I'd like to ask for suggestions \
on it (I originally wanted to add VDG here but there's no vdg group (?) so I'll post \
in the forums).

Diffs
-----

  applets/notifications/CMakeLists.txt 113d731 
  applets/notifications/lib/CMakeLists.txt PRE-CREATION 
  applets/notifications/lib/notificationsapplet.h PRE-CREATION 
  applets/notifications/lib/notificationsapplet.cpp PRE-CREATION 
  applets/notifications/package/contents/ui/Notifications.qml 4312774 
  applets/notifications/package/contents/ui/ScreenPositionSelector.qml PRE-CREATION 
  applets/notifications/package/contents/ui/configNotifications.qml cda9ac9 
  applets/notifications/package/metadata.desktop 333fa2c 
  applets/notifications/plugin/notificationshelper.h ca0b63b 
  applets/notifications/plugin/notificationshelper.cpp cd8a5a5 

Diff: https://git.reviewboard.kde.org/r/122842/diff/

Testing
-------

All positions work

File Attachments
----------------

Screenshot
  https://git.reviewboard.kde.org/media/uploaded/files/2015/03/06/f80f9345-3d5f-49b4-83d7-16ecbfbc607a__notification_pos.png
 New Screenshot
  https://git.reviewboard.kde.org/media/uploaded/files/2015/03/11/e1fd3405-b008-4d6e-90c7-2000ab011008__notifications_config.png

Thanks,

Martin Klapetek

--===============9114472531229083095==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/122842/">https://git.reviewboard.kde.org/r/122842/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma and KDE Usability.</div>
<div>By Martin Klapetek.</div>

<p style="color: grey;"><i>Updated April 6, 2015, 6:09 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 9429c845ae3fee1d65b026b2d496aae1305db232 by Martin \
Klapetek to branch master.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://bugs.kde.org/show_bug.cgi?id=344841">344841</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Allows to select each corner and top or bottom edges \
of the screen.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">The radio selection thing is currently \
a bit ugly and I'd like to ask for suggestions on it (I originally wanted to add VDG \
here but there's no vdg group (?) so I'll post in the forums).</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">All positions work</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>applets/notifications/CMakeLists.txt <span style="color: \
grey">(113d731)</span></li>

 <li>applets/notifications/lib/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>applets/notifications/lib/notificationsapplet.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>applets/notifications/lib/notificationsapplet.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>applets/notifications/package/contents/ui/Notifications.qml <span style="color: \
grey">(4312774)</span></li>

 <li>applets/notifications/package/contents/ui/ScreenPositionSelector.qml <span \
style="color: grey">(PRE-CREATION)</span></li>

 <li>applets/notifications/package/contents/ui/configNotifications.qml <span \
style="color: grey">(cda9ac9)</span></li>

 <li>applets/notifications/package/metadata.desktop <span style="color: \
grey">(333fa2c)</span></li>

 <li>applets/notifications/plugin/notificationshelper.h <span style="color: \
grey">(ca0b63b)</span></li>

 <li>applets/notifications/plugin/notificationshelper.cpp <span style="color: \
grey">(cd8a5a5)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/122842/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/03/06/f80f9345-3d5f-49b4-83d7-16ecbfbc607a__notification_pos.png">Screenshot</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/03/11/e1fd3405-b008-4d6e-90c7-2000ab011008__notifications_config.png">New \
Screenshot</a></li>

</ul>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============9114472531229083095==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 