[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 123272: improve digital clock representation on vertical panels
From: "Martin Klapetek" <martin.klapetek () gmail ! com>
Date: 2015-04-06 12:34:41
Message-ID: 20150406123441.31692.60752 () mimi ! kde ! org
[Download RAW message or body]
--===============5613140908740286086==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123272/#review78557
-----------------------------------------------------------
File Attachment: clock-vertical-after2 - clock-vertical-after2.png
<https://git.reviewboard.kde.org//r/123272/#fcomment389>
As you can see here, the date is now cramped to the burger menu; that's because \
of the "height:" change; that one should not be there
- Martin Klapetek
On April 6, 2015, 1:55 p.m., Mathias Kraus wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123272/
> -----------------------------------------------------------
>
> (Updated April 6, 2015, 1:55 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> On vertical panels, the date of the digital clock doesn't fit on the panel. This \
> patch sets the size of the date label to fit the panel.
>
> Diffs
> -----
>
> applets/digital-clock/package/contents/ui/DigitalClock.qml 74ffac1
>
> Diff: https://git.reviewboard.kde.org/r/123272/diff/
>
>
> Testing
> -------
>
> see screenshots
>
>
> File Attachments
> ----------------
>
> clock-horizontal-before1
> https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/23b26092-8a78-41c5-af9c-4f8ce6abc782__clock-horizontal-befor1.png
> clock-horizontal-after1
> https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/7898603f-037f-4fcf-b219-db095a167be5__clock-horizontal-after1.png
> clock-horizontal-before2
> https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/f22e29d7-9fcd-4a3c-8d46-859d4f3fbe3e__clock-horizontal-befor2.png
> clock-horizontal-after2
> https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/3d189422-5929-44c2-b8a3-7b5470833390__clock-horizontal-after2.png
> clock-vertical-before1
> https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/8b870753-d2e9-437b-adf8-dce8dba8b49e__clock-vertical-before1.png
> clock-vertical-after1
> https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/f1eef7c8-b02b-41bc-8c91-10fe778dae73__clock-vertical-after1.png
> clock-vertical-before2
> https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/3939f8f4-f618-438f-b908-c72861286004__clock-vertical-before2.png
> clock-vertical-after2
> https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/fa52c342-96d7-4176-83ea-37eb76e31910__clock-vertical-after2.png
>
>
> Thanks,
>
> Mathias Kraus
>
>
--===============5613140908740286086==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123272/">https://git.reviewboard.kde.org/r/123272/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid \
#c0c0c0; margin-bottom: 10px"> <tr>
<td>
<a href="https://git.reviewboard.kde.org/r/123272/file/2009/" style="color: black; \
font-weight: bold; font-size: 9pt;">clock-vertical-after2.png</a>
<p>clock-vertical-after2</p>
<div><img class="modified-image" \
src="/media/uploaded/files/2015/04/06/fa52c342-96d7-4176-83ea-37eb76e31910__clock-vertical-after2_50_162_56_27.png" \
width="56" height="27" alt="As you can see here, the date is now cramped to the \
burger menu; that's because of the "height:" change; that one should \
not be there" /></div>
</td>
</tr>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">As \
you can see here, the date is now cramped to the burger menu; that's because of the \
"height:" change; that one should not be there</p></pre> </div>
<br />
<p>- Martin Klapetek</p>
<br />
<p>On April 6th, 2015, 1:55 p.m. CEST, Mathias Kraus wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Mathias Kraus.</div>
<p style="color: grey;"><i>Updated April 6, 2015, 1:55 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">On vertical panels, the date of the digital clock \
doesn't fit on the panel. This patch sets the size of the date label to fit the \
panel.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">see screenshots</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/digital-clock/package/contents/ui/DigitalClock.qml <span style="color: \
grey">(74ffac1)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123272/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/23b26092 \
-8a78-41c5-af9c-4f8ce6abc782__clock-horizontal-befor1.png">clock-horizontal-before1</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/7898603f \
-037f-4fcf-b219-db095a167be5__clock-horizontal-after1.png">clock-horizontal-after1</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/f22e29d7 \
-9fcd-4a3c-8d46-859d4f3fbe3e__clock-horizontal-befor2.png">clock-horizontal-before2</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/3d189422 \
-5929-44c2-b8a3-7b5470833390__clock-horizontal-after2.png">clock-horizontal-after2</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/8b870753 \
-d2e9-437b-adf8-dce8dba8b49e__clock-vertical-before1.png">clock-vertical-before1</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/f1eef7c8 \
-b02b-41bc-8c91-10fe778dae73__clock-vertical-after1.png">clock-vertical-after1</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/3939f8f4 \
-f618-438f-b908-c72861286004__clock-vertical-before2.png">clock-vertical-before2</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/fa52c342 \
-96d7-4176-83ea-37eb76e31910__clock-vertical-after2.png">clock-vertical-after2</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============5613140908740286086==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic