[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 123244: Plasmate repo should no longer depend on kde4.
From: "Antonis Tsiapaliokas" <antonis.tsiapaliokas () kde ! org>
Date: 2015-04-03 17:32:04
Message-ID: 20150403173204.15140.48222 () mimi ! kde ! org
[Download RAW message or body]
--===============3457791783831266955==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123244/
-----------------------------------------------------------
(Updated April 3, 2015, 5:32 p.m.)
Status
------
This change has been marked as submitted.
Review request for Plasma.
Changes
-------
Submitted with commit 85f1b36d8fef10d905457e02f782ec9ca826f74f by Antonis \
Tsiapaliokas to branch frameworks.
Repository: plasmate
Description
-------
The Plasmate repo shouldn't depend on kde4.
The only application inside from this repo which still requires the kdelibs4support \
is the remoteinstaller which is currently part of the Plasmate (application) which is \
being disable by default.
So we should strip away the kde4 depedency from the entire repo and place it into the \
Plasmate(the application).
Diffs
-----
CMakeLists.txt 106cbb4
plasmate/CMakeLists.txt 6e07b30
plasmoidviewer/CMakeLists.txt 6ad061b
Diff: https://git.reviewboard.kde.org/r/123244/diff/
Testing
-------
Thanks,
Antonis Tsiapaliokas
--===============3457791783831266955==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123244/">https://git.reviewboard.kde.org/r/123244/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Antonis Tsiapaliokas.</div>
<p style="color: grey;"><i>Updated April 3, 2015, 5:32 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 85f1b36d8fef10d905457e02f782ec9ca826f74f by \
Antonis Tsiapaliokas to branch frameworks.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasmate
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The Plasmate repo shouldn't depend on kde4. The only \
application inside from this repo which still requires the kdelibs4support is the \
remoteinstaller which is currently part of the Plasmate (application) which is being \
disable by default.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">So we should strip away the kde4 \
depedency from the entire repo and place it into the Plasmate(the \
application).</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(106cbb4)</span></li>
<li>plasmate/CMakeLists.txt <span style="color: grey">(6e07b30)</span></li>
<li>plasmoidviewer/CMakeLists.txt <span style="color: grey">(6ad061b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123244/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3457791783831266955==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic