'Re: Review Request 123227: Consider visualParent rotation in popupPosition'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 123227: Consider visualParent rotation in popupPosition
From:       "Marco Martin" <notmart () gmail ! com>
Date:       2015-04-02 14:53:55
Message-ID: 20150402145355.20835.32233 () mimi ! kde ! org
[Download RAW message or body]

--===============4319968244701260399==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

> On April 2, 2015, 2:23 p.m., David Edmundson wrote:
> > +1.
> > 
> > I'd suggest not merging until after 5.9 is tagged given how finicky dialog tends \
> > to be.
> 
> Marco Martin wrote:
> ok, will push next week so

superseded by gerrit version https://gerrit.vesnicky.cesnet.cz/r/#/c/438/

- Marco

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123227/#review78408
-----------------------------------------------------------

On April 2, 2015, 2:53 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123227/
> -----------------------------------------------------------
> 
> (Updated April 2, 2015, 2:53 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 345787
> http://bugs.kde.org/show_bug.cgi?id=345787
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> if there are transforms in the scene, to correctly compute the position the \
> transpfrm is needed to be accounter for. QQuickITem::mapRectToScene does consider \
> tranforms. this adresses bug 345787 where the toolbox may be rotated.
> a test is added
> 
> 
> Diffs
> -----
> 
> src/plasmaquick/dialog.cpp cdf78eb 
> tests/dialog_positioning_parentrotated.qml PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/123227/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
> 

--===============4319968244701260399==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/123227/">https://git.reviewboard.kde.org/r/123227/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On April 2nd, 2015, 2:23 p.m. UTC, <b>David \
Edmundson</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">+1.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">I'd suggest not merging \
until after 5.9 is tagged given how finicky dialog tends to be.</p></pre>  \
</blockquote>

 <p>On April 2nd, 2015, 2:53 p.m. UTC, <b>Marco Martin</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">ok, \
will push next week so</p></pre>  </blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">superseded by gerrit version \
https://gerrit.vesnicky.cesnet.cz/r/#/c/438/</p></pre> <br />

<p>- Marco</p>

<br />
<p>On April 2nd, 2015, 2:53 p.m. UTC, Marco Martin wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Marco Martin.</div>

<p style="color: grey;"><i>Updated April 2, 2015, 2:53 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=345787">345787</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">if there are transforms in the scene, to correctly \
compute the position the transpfrm is needed to be accounter for. \
QQuickITem::mapRectToScene does consider tranforms. this adresses bug 345787 where \
the toolbox may be rotated. a test is added</p></pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/plasmaquick/dialog.cpp <span style="color: grey">(cdf78eb)</span></li>

 <li>tests/dialog_positioning_parentrotated.qml <span style="color: \
grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/123227/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============4319968244701260399==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 