'Re: Review Request 123220: kfontinst: Fix font list view header alignment and item sizehint'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 123220: kfontinst: Fix font list view header alignment and item sizehint
From:       Daniel_Vrátil <dvratil () redhat ! com>
Date:       2015-04-02 9:49:02
Message-ID: 20150402094902.20835.80596 () mimi ! kde ! org
[Download RAW message or body]

--===============1429826320120837690==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123220/
-----------------------------------------------------------

(Updated April 2, 2015, 9:49 a.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma.

Changes
-------

Submitted with commit a385460fc2a2ccec70f00bcc5ab51d4d648904e1 by Dan Vrátil to \
branch master.

Repository: plasma-desktop

Description
-------

I'm not sure the Qt::TextAlignmentRole is even needed (I think it would be better if \
the KCM obeyed whathever is the current theme default), but it should at least be \
centered vertically. I guess this wasn't so obvious with Oxygen, but Breeze makes the \
missing vertical alignment really obvious.

For the SizeHint role, relying on size of a particular random icon if we have a \
standard method for retrieving default icon size sounds wrong to me. For some reason \
my system refuses to load dialog-ok icon (so SmallIcon("dialog-ok").size() was \
returning QSize(0, 0)), which caused all items in the view to have SizeHint QSize(0, \
4), making it KCM basically unusable.

Diffs
-----

  kcms/kfontinst/kcmfontinst/FontList.cpp 802b383 
  kcms/kfontinst/kcmfontinst/GroupList.cpp 4532c0d 

Diff: https://git.reviewboard.kde.org/r/123220/diff/

Testing
-------

Thanks,

Daniel Vrátil

--===============1429826320120837690==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/123220/">https://git.reviewboard.kde.org/r/123220/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Daniel Vrátil.</div>

<p style="color: grey;"><i>Updated April 2, 2015, 9:49 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit a385460fc2a2ccec70f00bcc5ab51d4d648904e1 by Dan \
Vrátil to branch master.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I'm not sure the Qt::TextAlignmentRole is even needed \
(I think it would be better if the KCM obeyed whathever is the current theme \
default), but it should at least be centered vertically. I guess this wasn't so \
obvious with Oxygen, but Breeze makes the missing vertical alignment really \
obvious.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">For the SizeHint role, relying on size of a particular \
random icon if we have a standard method for retrieving default icon size sounds \
wrong to me. For some reason my system refuses to load dialog-ok icon (so \
SmallIcon("dialog-ok").size() was returning QSize(0, 0)), which caused all items in \
the view to have SizeHint QSize(0, 4), making it KCM basically unusable.</p></pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kcms/kfontinst/kcmfontinst/FontList.cpp <span style="color: \
grey">(802b383)</span></li>

 <li>kcms/kfontinst/kcmfontinst/GroupList.cpp <span style="color: \
grey">(4532c0d)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/123220/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============1429826320120837690==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 