'Re: Review Request 123188: Replicate functionality of Frameworks KStyle for KDE4'

[prev in list] [next in list] [prev in thread] [next in thread] 

List: kde-panel-devel
Subject: Re: Review Request 123188: Replicate functionality of Frameworks KStyle for KDE4
From: "David Edmundson" <david () davidedmundson ! co ! uk>
Date: 2015-04-01 10:58:20
Message-ID: 20150401105820.26405.54342 () mimi ! kde ! org
[Download RAW message or body]

--===============8292243676505676148==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

> On April 1, 2015, 10:54 a.m., Hugo Pereira Da Costa wrote:
> > (from the branch, not from the patch).
> > All is good.
> > Thanks ! 
> > 
> > (PS: will you push a similar thing for oxygen ?)

Yes, I planned to push into oxygen too

- David

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123188/#review78321
-----------------------------------------------------------

On April 1, 2015, 10:57 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123188/
> -----------------------------------------------------------
> 
> (Updated April 1, 2015, 10:57 a.m.)
> 
> 
> Review request for Plasma and Hugo Pereira Da Costa.
> 
> 
> Repository: breeze
> 
> 
> Description
> -------
> 
> Some important style hints are supplied by the KStyle class, mostly
> importantly whether listviews activate folders on single or double
> click.
> 
> For frameworks this now exists in KStyle, so code was not included in
> Breeze and latest Oxygen. However for KDE4 builds we still need this
> code.
> 
> There is a KDE4 kstyle class, but this behvaiour is very different and
> causes conflicts and a lot of other problems. Re-implementing the part
> we need seems the easier approach
> 
> 
> Diffs
> -----
> 
> kstyle/CMakeLists.txt e13a13d 
> kstyle/animations/breezegenericdata.cpp aa7c154 
> kstyle/breezestyle.h f9df1e8 
> kstyle/kstylekde4compat.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/123188/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
> 

--===============8292243676505676148==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/123188/">https://git.reviewboard.kde.org/r/123188/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> On April 1st, 2015, 10:54 a.m. UTC, Hugo \
Pereira Da Costa wrote: <blockquote style="margin-left: 1em; border-left: \
2px solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; \
white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; \
word-wrap: break-word;">(from the branch, not from the patch). \
All is good. Thanks ! 
(PS: will you push a similar thing for oxygen \
?)</pre> </blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yes, \
I planned to push into oxygen too</p></pre> <br />

<p>- David</p>

<br />
<p>On April 1st, 2015, 10:57 a.m. UTC, David Edmundson wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma and Hugo Pereira Da Costa.</div>
<div>By David Edmundson.</div>

<p style="color: grey;"><i>Updated April 1, 2015, 10:57 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
breeze
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Some important style hints are supplied by the KStyle \
class, mostly importantly whether listviews activate folders on single or double
click.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">For frameworks this now exists in KStyle, so code was \
not included in Breeze and latest Oxygen. However for KDE4 builds we still need this
code.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">There is a KDE4 kstyle class, but this behvaiour is \
very different and causes conflicts and a lot of other problems. Re-implementing the \
part we need seems the easier approach</p></pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kstyle/CMakeLists.txt <span style="color: grey">(e13a13d)</span></li>

 <li>kstyle/animations/breezegenericdata.cpp <span style="color: \
grey">(aa7c154)</span></li>

 <li>kstyle/breezestyle.h <span style="color: grey">(f9df1e8)</span></li>

 <li>kstyle/kstylekde4compat.cpp <span style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/123188/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============8292243676505676148==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 