[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 122679: Show Desktop feature: refurbished
From: Thomas_Lübking <thomas.luebking () gmail ! com>
Date: 2015-03-31 20:59:56
Message-ID: 20150331205956.26405.98704 () mimi ! kde ! org
[Download RAW message or body]
--===============0934853202467346800==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On März 22, 2015, 8:28 nachm., Kai Uwe Broulik wrote:
> > Sorry for being late to the party:
> >
> > UX issues I have with that implementation:
> > - No transition, the windows just disappear (would be cool to have them slide out \
> > of the screen or have them stay at the edges of the screen like OSX does it, but \
> > that's visuals)
> > - Cannot access plasmoid or containment config windows (or GHNS in widget \
> > explorer) - they don't appear in that mode, nor do they exit it
> > - KRunner exits this mode, imho KRunner should be usable from there (usability?)
> > - Panels inaccessible (though usability even proposed hiding them in Dashboard \
> > mode, so..)
> > Other than that this would 100% replace my Dashboard usecase, so +1 for the \
> > overall idea.
> > Usability team, ping?
>
> Thomas Lübking wrote:
> - No transition
> Definitively, but another patch (we'll have to wire up a showingDesktop signal and \
> then script something nicely ;-)
> - Cannot access plasmoid or containment config windows
> We'll have to require them to either be transient for the desktop or set the \
> keepAbove flag (and interpret that in layers.cpp) to still keep "normal" docks \
> (panels) hidden
> - KRunner exits this mode
> Afaics that's a general (re-occurring ;-) "problem" w/ krunner, unrelated to this \
> patch. Non-dock type windows that are not in the desktop group break the mode. This \
> applies because krunner is another process than plasmashell (afair the KDE3 runner \
> was part of kdesktop) => KRunner must either become a dock-type (and keepabove or \
> transient) or move itself into the desktops window group (be transient for it or \
> have the same WM_CLIENT_LEADER)
> However, I put "problem" in quotation marks, because that rather seems the \
> minimize-all (aka. "you wanted to switch the VD" ;-) case of cleaning up the \
> workspace (for the very next action will break the mode anyway when you run a new \
> application)??
> - Panels inaccessible
> See above - we can either make dock-type windows (mostly panels) unconditionally \
> visible or require them to setup a special condition (transient for desktop or keep \
> above)
> The question on what to do here is also the question mostly asked by this RR =)
> The global behavior (as long as we don't require transiency/keepabove hints from \
> "some" panels) is very easy to adjust, though.
> @Usability team, please also see my very first comment for more information on \
> layer control.
> kdeuser 56 wrote:
> My use case for the dashboard was mainly, when I had a lot of windows and I wanted \
> to customize plasma: Simply trigger dashboard and cutsomize the Desktop, \
> othwerwise, you would have to use "Show Desktop" or change to an empty workspace. I \
> really liked what we had in plasma5 till now, because the panels were accessible, \
> why wouldn't they be? What speaks against the panels? They are accesible all the \
> time, why wouldn't that be in dashboard mode too? When the panels are inacessible, \
> I have to treat cutsomization (my main use case), seperately for widgets and \
> panels, something I find an unnecessary barrier. If my opinion is worth anything \
> here, I would vote for accessible panels, dimmed or not. On another note: even when \
> you do not customize stuff, you use the dashboard/show desktop for accessing \
> information on the workspace. Now I trigger dashboard, but want to have a look at a \
> notificaiton too, while I am for example reading my plasma notes. Now I would have \
> to exit the dashboard and reenter it, because the panels are not accessible. I \
> don't think the panels ever distract that much, they should be made inaccessible.
> Thomas Pfeiffer wrote:
> Sorry for keeping you waiting for so long. I was very busy recently, and apparently \
> I'm the only one who is currently active on the usability list. So here goes:
> * Transition: We all agree that we need a transition, but since Thomas said it will \
> be another patch, we won't discuss it here further (just keep it in \
> mind)
> * Config windows: I'm still for a separate "workspace configuration mode" (Andrew \
> and I have talked about our plans for that to some Plasma devs, but we yet have to \
> properly introduce our ideas) which would make it unnecessary to show config \
> dialogs on the dashboard (and if we do have a separate mode, I'd indeed vote for \
> _not_ showing them in the dashboard). However, as long as there is no separate \
> config mode, I agree with kdeuser56 that the dashboard is probably the best place \
> available to configure the workspace and therefore config dialogs should be visible \
> there. Just please don't put too much effort into this as it might become obsolete \
> later.
> * Panels: I'm a bit torn here. The thing is that we have not defined what the \
> dashboard is supposed to be used for. If it is only for glancing at or quickly \
> interacting with desktop widgets, then panels would only be distracting. If it is \
> for interacting with the workspace in general, then of course panels should be \
> accessible. One argument against showing panels would be that clicking on a window \
> in the task switcher would break the mode (the window should not go below the \
> dashboard, as that would be inconsistent with switching via alt-tab). Still, I see \
> valid arguments for both alternatives, so I'll leave that to you. Just make sure \
> that either panels are fully visible and can be interacted with, or are \
> hidden/dimmed/faded and cannot be interacted with, as any mix of the two would be \
> confusing.
> * Layer: In contrast to what I said here ( \
> https://bugs.kde.org/show_bug.cgi?id=338534 ), I now think that "always on top" \
> windows should be kept above the dashboard, if we want to encourage the user's \
> mental model of "the desktop as basically just another window, which we would with \
> the tab-switching. In general, we should try to keep that mental model in mind when \
> making decisions in this area.
> * KRunner: Since KRunner is a Plasma user's "life-line", it has to be always \
> accessible. Having it break the dashboard mode would probably feel weird, as it's \
> something one often invokes on the fly, without wanting to leave the current \
> context. Of course if one uses it to start a new GUI application, then that breaks \
> the dashboard mode, which is okay. This is by far not KRunner's only use, though.
> I hope I was able to address all questions. If not, feel free to point any \
> questions that are still open out to me.
There're meanwhile even *two* transitions in this patch series ;-)
* Layer: keepAbove *always* on top of the "deskboard" or conditionally (ie. for the \
latter you'd still be able to alt+tab them above or below)
* We *will* require a hint on krunner, ideally set it transient for the desktop \
window.
-> Vishesh, does krunner already link kwindowsystem (since that'll likely be \
required to find the desktop WId, QDesktopWidget is the root wid)
* Other panels: I'd suggest to leave that to the client? If a panel is set keepabove, \
it would remain shown, otherwise not?!?
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122679/#review77926
-----------------------------------------------------------
On März 30, 2015, 9:06 nachm., Thomas Lübking wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122679/
> -----------------------------------------------------------
>
> (Updated März 30, 2015, 9:06 nachm.)
>
>
> Review request for kwin, Plasma, KDE Usability, Martin Gräßlin, and Marco Martin.
>
>
> Bugs: 344083
> https://bugs.kde.org/show_bug.cgi?id=344083
>
>
> Repository: kwin
>
>
> Description
> -------
>
> commit b4e3a736c3643179b5b4ea73f7706918a03483fe
> Author: Thomas Lübking
> Date: Mon Mar 30 11:38:54 2015 +0200
>
> add eyeOnScreen effect
>
> commit 4aaeeda8fbebded0e915b39a54092c586de179ce
> Author: Thomas Lübking
> Date: Mon Mar 30 11:38:38 2015 +0200
>
> support gaussian curve and animationEnded signal in ScriptedEffect
>
>
> commit a1e7f1a2ccefffd42e360bbaae48ecdfaa5b1ff4 \
>
> Author: Thomas Lübking \
>
> Date: Sun Mar 29 00:15:57 2015 +0100 \
>
> Add effect to move windows to corners on showing the desktop \
> commit d92c46e96fe9fb13403b859c5e334b618d45d268 \
>
> Author: Thomas Lübking \
>
> Date: Sun Mar 29 00:15:22 2015 +0100 \
>
> Remove AnimationData wrapper around metadata. Allow to set metadata directly in \
> animation objects \
> commit ed38cf37b26aa15d77c5b73734581055be234233 \
>
> Author: Thomas Lübking \
>
> Date: Sun Mar 29 00:13:41 2015 +0100 \
>
> make window elevation scriptable \
> commit c297fd5c55ba862151265e4b8b65b5ffe6048a8d \
>
> Author: Thomas Lübking \
>
> Date: Sun Mar 29 00:12:21 2015 +0100 \
>
> forward showingDesktop signal to effects \
> commit 570a92331f3691c1fb2affa4f853c75d6062f7e3 \
>
> Author: Thomas Lübking \
>
> Date: Sun Mar 29 00:08:32 2015 +0100 \
>
> emit signal when showingDesktop changes
>
>
> commit a1b80b4e310b2c75b4d9811af1d23f699bc658b5
> Author: Thomas Lübking
> Date: Sun Feb 22 16:41:45 2015 +0100
>
> add "MinimizeAll" script
>
> to compensate withdrawn core feature (which
> though has been hidden so far)
>
> commit 983efb916e282d2263b4abcc92f714c06b3bfcc1
> Author: Thomas Lübking
> Date: Wed Feb 18 02:09:00 2015 +0100
>
> break showingDesktop w/ tabbox/PW/DG
>
> This is now crucial, because while before (the minimized) windows were \
> conditionally shown, but are now always behind the desktop. Also, it makes the \
> tabbox more consistent.
> commit ff531c8e2adc407da00bef88f18d03e3829b25fa
> Author: Thomas Lübking
> Date: Wed Feb 18 01:37:45 2015 +0100
>
> implement showingDesktop by raising the desktop window
>
> commit 190a0cc022d9935d658a6218d0b3caa79b038563
> Author: Thomas Lübking
> Date: Wed Feb 18 00:09:46 2015 +0100
>
> remove secret showDesktopIsMinimizeAll feature
>
>
> Diffs
> -----
>
> client.h 6b947fe
> client.cpp b6af2fa
> effects.h ae71d61
> effects.cpp 20a8773
> effects/CMakeLists.txt 98a9349
> effects/badbadwindows/CMakeLists.txt PRE-CREATION
> effects/badbadwindows/package/CMakeLists.txt PRE-CREATION
> effects/badbadwindows/package/contents/code/main.js PRE-CREATION
> effects/badbadwindows/package/metadata.desktop PRE-CREATION
> effects/desktopgrid/desktopgrid.cpp 97cb2a3
> effects/eyeonscreen/CMakeLists.txt PRE-CREATION
> effects/eyeonscreen/package/CMakeLists.txt PRE-CREATION
> effects/eyeonscreen/package/contents/code/main.js PRE-CREATION
> effects/eyeonscreen/package/metadata.desktop PRE-CREATION
> effects/presentwindows/presentwindows.cpp 7a62ec0
> kwin.kcfg 80ca365
> layers.cpp ae08207
> libkwineffects/kwineffects.h b77e461
> manage.cpp 8b1a2ee
> options.h 67e5868
> options.cpp cdaa851
> scripting/scriptedeffect.h 39af241
> scripting/scriptedeffect.cpp ba646f6
> scripts/CMakeLists.txt 34dedb7
> scripts/minimizeall/contents/code/main.js PRE-CREATION
> scripts/minimizeall/metadata.desktop PRE-CREATION
> tabbox/tabbox.cpp 4a00e4b
> workspace.h 16fa351
> workspace.cpp f9c1ab1
>
> Diff: https://git.reviewboard.kde.org/r/122679/diff/
>
>
> Testing
> -------
>
> * The script (though mostly in KWin4, trouble w/ ksycoca5...)
> * Obviously the supersecret key is now dead ;-)
> * Been playing around with alternate desktop showing.
>
>
> Thanks,
>
> Thomas Lübking
>
>
--===============0934853202467346800==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122679/">https://git.reviewboard.kde.org/r/122679/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On März 22nd, 2015, 8:28 nachm. UTC, <b>Kai Uwe \
Broulik</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Sorry for being late to the party:</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">UX issues I have with that implementation:
- No transition, the windows just disappear (would be cool to have them slide out of \
the screen or have them stay at the edges of the screen like OSX does it, but that's \
visuals)
- Cannot access plasmoid or containment config windows (or GHNS in widget explorer) - \
they don't appear in that mode, nor do they exit it
- KRunner exits this mode, imho KRunner should be usable from there (usability?)
- Panels inaccessible (though usability even proposed hiding them in Dashboard mode, \
so..)</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Other than that this would 100% replace my Dashboard \
usecase, so +1 for the overall idea.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Usability team, \
ping?</p></pre> </blockquote>
<p>On März 22nd, 2015, 11:08 nachm. UTC, <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><ul style="padding: \
0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: \
normal;"> <li style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;"> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">No transition Definitively, but another \
patch (we'll have to wire up a showingDesktop signal and then script something nicely \
;-)</p> </li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;"> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Cannot access plasmoid or containment \
config windows We'll have to require them to either be transient for the desktop or \
set the keepAbove flag (and interpret that in layers.cpp) to still keep "normal" \
docks (panels) hidden</p> </li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;"> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">KRunner exits this mode Afaics that's a \
general (re-occurring ;-) "problem" w/ krunner, unrelated to this patch. Non-dock \
type windows that are not in the desktop group break the mode. This applies because \
krunner is another process than plasmashell (afair the KDE3 runner was part of \
kdesktop) => KRunner must either become a dock-type (and keepabove or transient) \
or move itself into the desktops window group (be transient for it or have the same \
WM_CLIENT_LEADER)</p> </li>
</ul>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">However, I put "problem" in quotation marks, because \
that rather seems the minimize-all (aka. "you wanted to switch the VD" ;-) case of \
cleaning up the workspace (for the very next action will break the mode anyway when \
you run a new application)??</p> <ul style="padding: 0;text-rendering: \
inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;"> <li \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">Panels inaccessible See above - we can either make dock-type windows (mostly \
panels) unconditionally visible or require them to setup a special condition \
(transient for desktop or keep above)</li> </ul>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The question on what to do here is also the question \
mostly asked by this RR =) The global behavior (as long as we don't require \
transiency/keepabove hints from "some" panels) is very easy to adjust, though.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">@Usability team, please also see my very first comment for more information \
on layer control.</p></pre> </blockquote>
<p>On März 25th, 2015, 4:30 nachm. UTC, <b>kdeuser 56</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">My \
use case for the dashboard was mainly, when I had a lot of windows and I wanted to \
customize plasma: Simply trigger dashboard and cutsomize the Desktop, othwerwise, you \
would have to use "Show Desktop" or change to an empty workspace. I really liked what \
we had in plasma5 till now, because the panels were accessible, why wouldn't they be? \
What speaks against the panels? They are accesible all the time, why wouldn't that be \
in dashboard mode too? When the panels are inacessible, I have to treat cutsomization \
(my main use case), seperately for widgets and panels, something I find an \
unnecessary barrier. If my opinion is worth anything here, I would vote for \
accessible panels, dimmed or not. On another note: even when you do not customize \
stuff, you use the dashboard/show desktop for accessing information on the workspace. \
Now I trigger dashboard, but want to have a look at a notificaiton too, while I am \
for example reading my plasma notes. Now I would have to exit the dashboard and \
reenter it, because the panels are not accessible. I don't think the panels ever \
distract that much, they should be made inaccessible.</p></pre> </blockquote>
<p>On März 30th, 2015, 11:01 nachm. UTC, <b>Thomas Pfeiffer</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Sorry \
for keeping you waiting for so long. I was very busy recently, and apparently I'm the \
only one who is currently active on the usability list. So here goes:</p> <ul \
style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: \
inherit;white-space: normal;"> <li style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;">Transition: We all agree that we need a \
transition, but since Thomas said it will be another patch, we won't discuss it here \
further (just keep it in mind)</li> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">Config windows: I'm \
still for a separate "workspace configuration mode" (Andrew and I have talked about \
our plans for that to some Plasma devs, but we yet have to properly introduce our \
ideas) which would make it unnecessary to show config dialogs on the dashboard (and \
if we do have a separate mode, I'd indeed vote for <em style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">not</em> showing them in the dashboard). However, as long as there is no \
separate config mode, I agree with kdeuser56 that the dashboard is probably the best \
place available to configure the workspace and therefore config dialogs should be \
visible there. Just please don't put too much effort into this as it might become \
obsolete later.</li> <li style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;">Panels: I'm a bit torn here. The thing \
is that we have not defined what the dashboard is supposed to be used for. If it is \
only for glancing at or quickly interacting with desktop widgets, then panels would \
only be distracting. If it is for interacting with the workspace in general, then of \
course panels should be accessible. One argument against showing panels would be that \
clicking on a window in the task switcher would break the mode (the window should not \
go below the dashboard, as that would be inconsistent with switching via alt-tab). \
Still, I see valid arguments for both alternatives, so I'll leave that to you. Just \
make sure that either panels are fully visible and can be interacted with, or are \
hidden/dimmed/faded and cannot be interacted with, as any mix of the two would be \
confusing.</li> <li style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;">Layer: In contrast to what I said here ( \
https://bugs.kde.org/show_bug.cgi?id=338534 ), I now think that "always on top" \
windows should be kept above the dashboard, if we want to encourage the user's mental \
model of "the desktop as basically just another window, which we would with the \
tab-switching. In general, we should try to keep that mental model in mind when \
making decisions in this area.</li> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">KRunner: Since KRunner \
is a Plasma user's "life-line", it has to be always accessible. Having it break the \
dashboard mode would probably feel weird, as it's something one often invokes on the \
fly, without wanting to leave the current context. Of course if one uses it to start \
a new GUI application, then that breaks the dashboard mode, which is okay. This is by \
far not KRunner's only use, though.</li> </ul>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I hope I was able to address all questions. If not, \
feel free to point any questions that are still open out to me.</p></pre> \
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">There're meanwhile even <em style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">two</em> transitions in \
this patch series ;-)</p> <ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 \
1em;line-height: inherit;white-space: normal;"> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;"> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Layer: keepAbove <em style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;">always</em> on top of the "deskboard" or \
conditionally (ie. for the latter you'd still be able to alt+tab them above or \
below)</p> </li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;"> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">We <em style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">will</em> require a hint on krunner, ideally set it transient for the \
desktop window.
-> Vishesh, does krunner already link kwindowsystem (since that'll likely be \
required to find the desktop WId, QDesktopWidget is the root wid)</p> </li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;"> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Other panels: I'd suggest to leave that \
to the client? If a panel is set keepabove, it would remain shown, otherwise \
not?!?</p> </li>
</ul></pre>
<br />
<p>- Thomas</p>
<br />
<p>On März 30th, 2015, 9:06 nachm. UTC, Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for kwin, Plasma, KDE Usability, Martin Gräßlin, and Marco \
Martin.</div> <div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated März 30, 2015, 9:06 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=344083">344083</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwin
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">commit \
b4e3a736c3643179b5b4ea73f7706918a03483fe
Author: Thomas Lübking
Date: Mon Mar 30 11:38:54 2015 +0200</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;"><div class="codehilite" style="background: \
#f8f8f8"><pre style="line-height: 125%">add eyeOnScreen effect </pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">commit \
4aaeeda8fbebded0e915b39a54092c586de179ce
Author: Thomas Lübking
Date: Mon Mar 30 11:38:38 2015 +0200</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;"><div class="codehilite" style="background: \
#f8f8f8"><pre style="line-height: 125%">support gaussian curve and animationEnded \
signal in ScriptedEffect </pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">commit a1e7f1a2ccefffd42e360bbaae48ecdfaa5b1ff4 \
<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;" />
Author: Thomas Lübking \
<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;" />
Date: Sun Mar 29 00:15:57 2015 +0100 \
</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;"><div class="codehilite" style="background: \
#f8f8f8"><pre style="line-height: 125%">Add effect to move windows to corners on \
showing the desktop </pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">commit d92c46e96fe9fb13403b859c5e334b618d45d268 \
<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;" />
Author: Thomas Lübking \
<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;" />
Date: Sun Mar 29 00:15:22 2015 +0100 \
</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;"><div class="codehilite" style="background: \
#f8f8f8"><pre style="line-height: 125%">Remove AnimationData wrapper around metadata. \
Allow to set metadata directly in animation objects </pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">commit ed38cf37b26aa15d77c5b73734581055be234233 \
<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;" />
Author: Thomas Lübking \
<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;" />
Date: Sun Mar 29 00:13:41 2015 +0100 \
</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;"><div class="codehilite" style="background: \
#f8f8f8"><pre style="line-height: 125%">make window elevation scriptable </pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">commit c297fd5c55ba862151265e4b8b65b5ffe6048a8d \
<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;" />
Author: Thomas Lübking \
<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;" />
Date: Sun Mar 29 00:12:21 2015 +0100 \
</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;"><div class="codehilite" style="background: \
#f8f8f8"><pre style="line-height: 125%">forward showingDesktop signal to effects \
</pre></div> </p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">commit 570a92331f3691c1fb2affa4f853c75d6062f7e3 \
<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;" />
Author: Thomas Lübking \
<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;" />
Date: Sun Mar 29 00:08:32 2015 +0100 \
</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;"><div class="codehilite" style="background: \
#f8f8f8"><pre style="line-height: 125%">emit signal when showingDesktop changes \
</pre></div> </p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">commit \
a1b80b4e310b2c75b4d9811af1d23f699bc658b5
Author: Thomas Lübking
Date: Sun Feb 22 16:41:45 2015 +0100</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;"><div class="codehilite" style="background: \
#f8f8f8"><pre style="line-height: 125%">add "MinimizeAll" script
to compensate withdrawn core feature (which
though has been hidden so far)
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">commit \
983efb916e282d2263b4abcc92f714c06b3bfcc1
Author: Thomas Lübking
Date: Wed Feb 18 02:09:00 2015 +0100</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;"><div class="codehilite" style="background: \
#f8f8f8"><pre style="line-height: 125%">break showingDesktop w/ tabbox/PW/DG \
</pre></div> </p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This is now crucial, because while before (the \
minimized) windows were conditionally shown, but are now always behind the desktop. \
Also, it makes the tabbox more consistent.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">commit \
ff531c8e2adc407da00bef88f18d03e3829b25fa
Author: Thomas Lübking
Date: Wed Feb 18 01:37:45 2015 +0100</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;"><div class="codehilite" style="background: \
#f8f8f8"><pre style="line-height: 125%">implement showingDesktop by raising the \
desktop window </pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">commit \
190a0cc022d9935d658a6218d0b3caa79b038563
Author: Thomas Lübking
Date: Wed Feb 18 00:09:46 2015 +0100</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;"><div class="codehilite" style="background: \
#f8f8f8"><pre style="line-height: 125%">remove secret showDesktopIsMinimizeAll \
feature </pre></div>
</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 \
1em;line-height: inherit;white-space: normal;"> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">The script (though \
mostly in KWin4, trouble w/ ksycoca5...)</li> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">Obviously the \
supersecret key is now dead ;-)</li> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">Been playing around with \
alternate desktop showing.</li> </ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>client.h <span style="color: grey">(6b947fe)</span></li>
<li>client.cpp <span style="color: grey">(b6af2fa)</span></li>
<li>effects.h <span style="color: grey">(ae71d61)</span></li>
<li>effects.cpp <span style="color: grey">(20a8773)</span></li>
<li>effects/CMakeLists.txt <span style="color: grey">(98a9349)</span></li>
<li>effects/badbadwindows/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>effects/badbadwindows/package/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>effects/badbadwindows/package/contents/code/main.js <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>effects/badbadwindows/package/metadata.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>effects/desktopgrid/desktopgrid.cpp <span style="color: \
grey">(97cb2a3)</span></li>
<li>effects/eyeonscreen/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>effects/eyeonscreen/package/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>effects/eyeonscreen/package/contents/code/main.js <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>effects/eyeonscreen/package/metadata.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>effects/presentwindows/presentwindows.cpp <span style="color: \
grey">(7a62ec0)</span></li>
<li>kwin.kcfg <span style="color: grey">(80ca365)</span></li>
<li>layers.cpp <span style="color: grey">(ae08207)</span></li>
<li>libkwineffects/kwineffects.h <span style="color: grey">(b77e461)</span></li>
<li>manage.cpp <span style="color: grey">(8b1a2ee)</span></li>
<li>options.h <span style="color: grey">(67e5868)</span></li>
<li>options.cpp <span style="color: grey">(cdaa851)</span></li>
<li>scripting/scriptedeffect.h <span style="color: grey">(39af241)</span></li>
<li>scripting/scriptedeffect.cpp <span style="color: grey">(ba646f6)</span></li>
<li>scripts/CMakeLists.txt <span style="color: grey">(34dedb7)</span></li>
<li>scripts/minimizeall/contents/code/main.js <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>scripts/minimizeall/metadata.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tabbox/tabbox.cpp <span style="color: grey">(4a00e4b)</span></li>
<li>workspace.h <span style="color: grey">(16fa351)</span></li>
<li>workspace.cpp <span style="color: grey">(f9c1ab1)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122679/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0934853202467346800==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic