'Re: Review Request 123188: Replicate functionality of Frameworks KStyle for KDE4'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 123188: Replicate functionality of Frameworks KStyle for KDE4
From:       "David Edmundson" <david () davidedmundson ! co ! uk>
Date:       2015-03-30 19:42:13
Message-ID: 20150330194213.26405.75488 () mimi ! kde ! org
[Download RAW message or body]

--===============7990837796488322092==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

> On March 30, 2015, 6:06 p.m., Hugo Pereira Da Costa wrote:
> > in principle, ship it. The approach is sound. (indeed KDE4 oxygen and hence breeze moved away from \
> > KStyle at some point in the past because it was bringing more issues than solving. Copied the said \
> > code from kstyle to these back then. Then with kf5, kstyle got cleaned up *a lot*, so it could be \
> > re-used, the duplicated code was thus removed, leaving the hole that you are now filling again) 
> > Thanks ! 
> > 
> > However, please check what's the thing with breezegenericdata in the diff. As is I could not apply \
> > the patch (there are some rejs) and this generic data stuff should be quite unrelated. Do you have \
> > another patch around ?  
> > Hugo
> 
> David Edmundson wrote:
> OK, two things.
> 1) my patch was super old. I have a repo in my kde4 folder and my kde5 source folder, and I didn't git \
> pull. Rebased and reuploading 2) I have no idea what that thing about breezegenericdata is about, it's \
> not in my patch. I think it might be RB trying to be clever 
> David Edmundson wrote:
> still shows it, if it's a problem I can just push into a branch.
> 
> Hugo Pereira Da Costa wrote:
> funny. The patch itself includes:
> 
> diff --git a/kstyle/animations/breezegenericdata.cpp b/kstyle/kstylekde4compat.h
> similarity index 67%
> copy from kstyle/animations/breezegenericdata.cpp
> copy to kstyle/kstylekde4compat.h
> 
> why would that be ? Is for some reason the file breezegenericdata gone from your local dir ?

reviewboard must be mangling it. I've checked in git show, and in qgit which lists the files changes and \
it's all fine.

Pushed to davidedmundson/kde4stylehints if you wanted to see it.

- David

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123188/#review78237
-----------------------------------------------------------

On March 30, 2015, 6:22 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123188/
> -----------------------------------------------------------
> 
> (Updated March 30, 2015, 6:22 p.m.)
> 
> 
> Review request for Plasma and Hugo Pereira Da Costa.
> 
> 
> Repository: breeze
> 
> 
> Description
> -------
> 
> Some important style hints are supplied by the KStyle class, mostly
> importantly whether listviews activate folders on single or double
> click.
> 
> For frameworks this now exists in KStyle, so code was not included in
> Breeze and latest Oxygen. However for KDE4 builds we still need this
> code.
> 
> There is a KDE4 kstyle class, but this behvaiour is very different and
> causes conflicts and a lot of other problems. Re-implementing the part
> we need seems the easier approach
> 
> 
> Diffs
> -----
> 
> kstyle/CMakeLists.txt e13a13d 
> kstyle/animations/breezegenericdata.cpp aa7c154 
> kstyle/breezestyle.h f9df1e8 
> kstyle/kstylekde4compat.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/123188/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
> 

--===============7990837796488322092==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/123188/">https://git.reviewboard.kde.org/r/123188/</a>
     </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
 <p style="margin-top: 0;">On March 30th, 2015, 6:06 p.m. UTC, <b>Hugo Pereira Da Costa</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">in principle, ship it. The approach is sound. (indeed KDE4 oxygen and \
hence breeze moved away from KStyle at some point in the past because it was bringing more issues than \
solving. Copied the said code from kstyle to these back then. Then with kf5, kstyle got cleaned up <em \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">a \
lot</em>, so it could be re-used, the duplicated code was thus removed, leaving the hole that you are now \
filling again)</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Thanks ! </p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">However, please check what's the thing with \
breezegenericdata in the diff. As is I could not apply the patch (there are some rejs) and this generic \
data stuff should be quite unrelated. Do you have another patch around ? </p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Hugo</p></pre>  \
</blockquote>

 <p>On March 30th, 2015, 6:22 p.m. UTC, <b>David Edmundson</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">OK, two things. 1) my patch was super old. I have a repo in my kde4 folder \
and my kde5 source folder, and I didn't git pull. Rebased and reuploading 2) I have no idea what that \
thing about breezegenericdata is about, it's not in my patch. I think it might be RB trying to be \
clever</p></pre>  </blockquote>

 <p>On March 30th, 2015, 6:24 p.m. UTC, <b>David Edmundson</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">still shows it, if it's a problem I can just push into a branch.</p></pre> \
</blockquote>

 <p>On March 30th, 2015, 6:32 p.m. UTC, <b>Hugo Pereira Da Costa</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">funny. The patch itself includes:</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">diff --git \
a/kstyle/animations/breezegenericdata.cpp b/kstyle/kstylekde4compat.h similarity index 67%
copy from kstyle/animations/breezegenericdata.cpp
copy to kstyle/kstylekde4compat.h</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">why \
would that be ? Is for some reason the file breezegenericdata gone from your local dir ?</p></pre>  \
</blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">reviewboard must be mangling it. I've checked in git show, and in qgit \
which lists the files changes and it's all fine.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Pushed to davidedmundson/kde4stylehints if you wanted to \
see it.</p></pre> <br />

<p>- David</p>

<br />
<p>On March 30th, 2015, 6:22 p.m. UTC, David Edmundson wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma and Hugo Pereira Da Costa.</div>
<div>By David Edmundson.</div>

<p style="color: grey;"><i>Updated March 30, 2015, 6:22 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
breeze
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Some important style hints are supplied by \
the KStyle class, mostly importantly whether listviews activate folders on single or double
click.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">For \
frameworks this now exists in KStyle, so code was not included in Breeze and latest Oxygen. However for \
KDE4 builds we still need this code.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">There \
is a KDE4 kstyle class, but this behvaiour is very different and causes conflicts and a lot of other \
problems. Re-implementing the part we need seems the easier approach</p></pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kstyle/CMakeLists.txt <span style="color: grey">(e13a13d)</span></li>

 <li>kstyle/animations/breezegenericdata.cpp <span style="color: grey">(aa7c154)</span></li>

 <li>kstyle/breezestyle.h <span style="color: grey">(f9df1e8)</span></li>

 <li>kstyle/kstylekde4compat.cpp <span style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/123188/diff/" style="margin-left: 3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============7990837796488322092==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 