--===============4643958046622234071== Content-Type: multipart/alternative; boundary="===============2688450981876006201==" --===============2688450981876006201== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123147/ ----------------------------------------------------------- (Updated March 30, 2015, 10:28 a.m.) Status ------ This change has been marked as submitted. Review request for Plasma. Changes ------- Submitted with commit e1b142a8970d44090592a7573c55f6b4e76995c9 by Harald Sitter to branch master. Repository: plasma-desktop Description ------- in the no-install-header mode it keeps the library entirely private by not installing the symlink, whereas when installing the headers the so link is also being installed. Diffs ----- lib/kactivities-stats/src/lib/stats/CMakeLists.txt f58aa5d9bd200b3c037a5e7e5a7ad893bbae956e Diff: https://git.reviewboard.kde.org/r/123147/diff/ Testing ------- make -j9; make install DESTDIR=. --> doesn't install .so change experimental header install variable to true --> installs .so Thanks, Harald Sitter --===============2688450981876006201== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123147/

This change has been marked as submitted.

Review request for Plasma.
By Harald Sitter.

Updated March 30, 2015, 10:28 a.m.

Changes

Submitted with commit e1b142a8970d44090592a7573c55f6b4e76995c9 by Harald Sitter to branch master.
Repository: plasma-desktop

Description 

in the no-install-header mode it keeps the library entirely private by
not installing the symlink, whereas when installing the headers the so
link is also being installed.

Testing 

make -j9; make install DESTDIR=. --> doesn't install .so


change experimental header install variable to true --> installs .so

Diffs

  • lib/kactivities-stats/src/lib/stats/CMakeLists.txt (f58aa5d9bd200b3c037a5e7e5a7ad893bbae956e)

View Diff
--===============2688450981876006201==-- --===============4643958046622234071== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============4643958046622234071==--