'Re: Review Request 123164: Add new Bluetooth applet'

[prev in list] [next in list] [prev in thread] [next in thread] 

List: kde-panel-devel
Subject: Re: Review Request 123164: Add new Bluetooth applet
From: "David Rosca" <nowrep () gmail ! com>
Date: 2015-03-29 19:30:09
Message-ID: 20150329193009.1187.70875 () mimi ! kde ! org
[Download RAW message or body]

--===============6618112539203639862==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

> On March 29, 2015, 6 p.m., Kai Uwe Broulik wrote:
> > File Attachment: snapshot4.png - snapshot4.png
> > <https://git.reviewboard.kde.org/r/123164/#fcomment381>
> > 
> > It's "Paired", what would "Connect" do?

It would connect to the device :) That means, connect the HID profile (input \
devices), A2DP profile (audio), ...

> On March 29, 2015, 6 p.m., Kai Uwe Broulik wrote:
> > File Attachment: snapshot5.png - snapshot5.png
> > <https://git.reviewboard.kde.org/r/123164/#fcomment382>
> > 
> > I wouldn't show the ID right at a glance. That's super geeky. Hide that in the \
> > details section.

Hmm, you are right. But what to show there instead?

> On March 29, 2015, 6 p.m., Kai Uwe Broulik wrote:
> > src/applet/package/contents/ui/DeviceItem.qml, line 79
> > <https://git.reviewboard.kde.org/r/123164/diff/3/?file=357164#file357164line79>
> > 
> > Property starting with an uppercase letter looks wrong to me, I wonder why that \
> > even works.

This is role name from model.

> On March 29, 2015, 6 p.m., Kai Uwe Broulik wrote:
> > src/applet/package/contents/ui/BluetoothApplet.qml, line 37
> > <https://git.reviewboard.kde.org/r/123164/diff/3/?file=357161#file357161line37>
> > 
> > Would be cool to have the icon reflect the state, ie. use \
> > preferences-system-bluetooth-inactive (I think even the Plasma theme has that \
> > one)

The icon is already greyed (disabled) when BT is offline. Also \
preferences-system-bluetooth-inactive is not in breeze icon theme.

Ideally, all icons should be in svg and adjusted for this applet - as in plasma-nm. \
Right now, the bluetooth icon in tooltip is small because the monochrome version is \
only in small size (for bluedevil-monolithic). I'll try to ask vdg :)

> On March 29, 2015, 6 p.m., Kai Uwe Broulik wrote:
> > src/applet/package/contents/ui/FullRepresentation.qml, line 29
> > <https://git.reviewboard.kde.org/r/123164/diff/3/?file=357165#file357165line29>
> > 
> > Would it be possible to use Plasma's default proxy model?

I don't think so. It sorts devices and also append a (hciX) to device name if there \
are same devices in multiple adapters.

> On March 29, 2015, 6 p.m., Kai Uwe Broulik wrote:
> > src/applet/plugin/devicesproxymodel.h, line 38
> > <https://git.reviewboard.kde.org/r/123164/diff/3/?file=357173#file357173line38>
> > 
> > virtual ~DevicesProxyModel() = default; ?

Isn't it the same as if there is no destructor at all?

> On March 29, 2015, 6 p.m., Kai Uwe Broulik wrote:
> > src/applet/package/contents/ui/ConfigGeneral.qml, lines 29-32
> > <https://git.reviewboard.kde.org/r/123164/diff/3/?file=357163#file357163line29>
> > 
> > Is it really neccessary to be able to turn sections off?

No :D Ok, I will drop the whole config.

- David

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123164/#review78179
-----------------------------------------------------------

On March 29, 2015, 5:18 p.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123164/
> -----------------------------------------------------------
> 
> (Updated March 29, 2015, 5:18 p.m.)
> 
> 
> Review request for Bluedevil and Plasma.
> 
> 
> Repository: bluedevil
> 
> 
> Description
> -------
> 
> This is a replacement for bluedevil-monolithic.
> The code is based on network management plasmoid and it does basically the same but \
> for Bluetooth devices. 
> 
> Diffs
> -----
> 
> CMakeLists.txt 94b56fb 
> src/CMakeLists.txt b804f2b 
> src/applet/CMakeLists.txt PRE-CREATION 
> src/applet/Messages.sh PRE-CREATION 
> src/applet/package/contents/code/logic.js PRE-CREATION 
> src/applet/package/contents/config/config.qml PRE-CREATION 
> src/applet/package/contents/config/main.xml PRE-CREATION 
> src/applet/package/contents/ui/BluetoothApplet.qml PRE-CREATION 
> src/applet/package/contents/ui/CompactRepresentation.qml PRE-CREATION 
> src/applet/package/contents/ui/ConfigGeneral.qml PRE-CREATION 
> src/applet/package/contents/ui/DeviceItem.qml PRE-CREATION 
> src/applet/package/contents/ui/FullRepresentation.qml PRE-CREATION 
> src/applet/package/contents/ui/Header.qml PRE-CREATION 
> src/applet/package/contents/ui/SwitchButton.qml PRE-CREATION 
> src/applet/package/contents/ui/Toolbar.qml PRE-CREATION 
> src/applet/package/metadata.desktop PRE-CREATION 
> src/applet/plugin/CMakeLists.txt PRE-CREATION 
> src/applet/plugin/bluetoothplugin.h PRE-CREATION 
> src/applet/plugin/bluetoothplugin.cpp PRE-CREATION 
> src/applet/plugin/devicesproxymodel.h PRE-CREATION 
> src/applet/plugin/devicesproxymodel.cpp PRE-CREATION 
> src/applet/plugin/launchapp.h PRE-CREATION 
> src/applet/plugin/launchapp.cpp PRE-CREATION 
> src/applet/plugin/notify.h PRE-CREATION 
> src/applet/plugin/notify.cpp PRE-CREATION 
> src/applet/plugin/qmldir PRE-CREATION 
> src/bluedevil.notifyrc 72257ed 
> 
> Diff: https://git.reviewboard.kde.org/r/123164/diff/
> 
> 
> Testing
> -------
> 
> I've been running it for some time already and it works fine.
> 
> 
> File Attachments
> ----------------
> 
> snapshot4.png
> https://git.reviewboard.kde.org/media/uploaded/files/2015/03/28/acba4387-a4e7-4e77-830d-91dc5ed5c574__snapshot4.png
>  snapshot5.png
> https://git.reviewboard.kde.org/media/uploaded/files/2015/03/28/d0cab8ca-a62b-4672-9600-cbd61de25c63__snapshot5.png
>  
> 
> Thanks,
> 
> David Rosca
> 
> 

--===============6618112539203639862==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/123164/">https://git.reviewboard.kde.org/r/123164/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin: 1em 0 0 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On March 29th, 2015, 6 p.m. UTC, <b>Kai Uwe \
Broulik</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding: 0 0 0 1em;">  
  <br style="display: none;" />

  <table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid \
#c0c0c0; margin-bottom: 10px">  <tr>
    <td>
     <a href="https://git.reviewboard.kde.org/r/123164/file/1977/" style="color: \
black; font-weight: bold; font-size: 9pt;">snapshot4.png</a>

     <p>snapshot4.png</p>

    </td>
   </tr>
  </table>
  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It&#39;s \
&quot;Paired&quot;, what would &quot;Connect&quot; do?</pre>  </blockquote>

</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">It would connect to the device :) That means, connect the HID profile \
(input devices), A2DP profile (audio), ...</p></pre> <br />

<blockquote style="margin: 1em 0 0 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On March 29th, 2015, 6 p.m. UTC, <b>Kai Uwe \
Broulik</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding: 0 0 0 1em;">  
  <br style="display: none;" />

  <table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid \
#c0c0c0; margin-bottom: 10px">  <tr>
    <td>
     <a href="https://git.reviewboard.kde.org/r/123164/file/1978/" style="color: \
black; font-weight: bold; font-size: 9pt;">snapshot5.png</a>

     <p>snapshot5.png</p>

    </td>
   </tr>
  </table>
  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I wouldn&#39;t show the \
ID right at a glance. That&#39;s super geeky. Hide that in the details section.</pre> \
</blockquote>

</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hmm, you are right. But what to show there instead?</pre>

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On March 29th, 2015, 6 p.m. UTC, <b>Kai Uwe \
Broulik</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="https://git.reviewboard.kde.org/r/123164/diff/3/?file=357161#file357161line37" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/applet/package/contents/ui/BluetoothApplet.qml</a>  <span \
style="font-weight: normal;">

     (Diff revision 3)

    </span>
   </th>
  </tr>
 </thead>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">37</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="k">Plasmoid.icon:</span> <span \
class="s2">&quot;preferences-system-bluetooth&quot;</span></pre></td>  </tr>

 </tbody>

</table>

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Would \
be cool to have the icon reflect the state, ie. use \
preferences-system-bluetooth-inactive (I think even the Plasma theme has that \
one)</p></pre>  </blockquote>

</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The icon is already greyed (disabled) when BT is offline. Also \
preferences-system-bluetooth-inactive is not in breeze icon theme. Ideally, all icons should be in svg and adjusted for this applet - as in \
plasma-nm. Right now, the bluetooth icon in tooltip is small because the monochrome \
version is only in small size (for bluedevil-monolithic). I'll try to ask vdg \
:)</pre>

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On March 29th, 2015, 6 p.m. UTC, <b>Kai Uwe \
Broulik</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="https://git.reviewboard.kde.org/r/123164/diff/3/?file=357163#file357163line29" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/applet/package/contents/ui/ConfigGeneral.qml</a>  <span \
style="font-weight: normal;">

     (Diff revision 3)

    </span>
   </th>
  </tr>
 </thead>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">29</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="nx">PlasmaComponents</span><span class="p">.</span><span \
class="nx">CheckBox</span> <span class="p">{</span></pre></td>  </tr>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">30</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">        <span \
class="kd">id: showSectionsCheckBox</span></pre></td>  </tr>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">31</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">        <span \
class="k">text:</span> <span class="nx">i18n</span><span class="p">(</span><span \
class="s2">&quot;Show sections&quot;</span><span class="p">)</span></pre></td>  </tr>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">32</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="p">}</span></pre></td>  </tr>

 </tbody>

</table>

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Is it \
really neccessary to be able to turn sections off?</p></pre>  </blockquote>

</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">No :D Ok, I will drop the whole config.</p></pre> <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On March 29th, 2015, 6 p.m. UTC, <b>Kai Uwe \
Broulik</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="https://git.reviewboard.kde.org/r/123164/diff/3/?file=357164#file357164line79" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/applet/package/contents/ui/DeviceItem.qml</a>  <span \
style="font-weight: normal;">

     (Diff revision 3)

    </span>
   </th>
  </tr>
 </thead>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">79</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">            \
<span class="k">font.weight:</span> <span class="nx">Connected</span> <span \
class="o">?</span> <span class="k">Font.DemiBold :</span> <span \
class="nx">Font</span><span class="p">.</span><span \
class="nx">Normal</span></pre></td>  </tr>

 </tbody>

</table>

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Property starting with an uppercase letter looks wrong to me, I wonder why \
that even works.</p></pre>  </blockquote>

</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">This is role name from model.</p></pre> <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On March 29th, 2015, 6 p.m. UTC, <b>Kai Uwe \
Broulik</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="https://git.reviewboard.kde.org/r/123164/diff/3/?file=357165#file357165line29" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/applet/package/contents/ui/FullRepresentation.qml</a>  <span \
style="font-weight: normal;">

     (Diff revision 3)

    </span>
   </th>
  </tr>
 </thead>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">29</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="nx">PlasmaBt</span><span class="p">.</span><span \
class="nx">DevicesProxyModel</span> <span class="p">{</span></pre></td>  </tr>

 </tbody>

</table>

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Would \
it be possible to use Plasma's default proxy model?</p></pre>  </blockquote>

</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don't think so. It sorts devices and also append a (hciX) to device name \
if there are same devices in multiple adapters.</pre>

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On March 29th, 2015, 6 p.m. UTC, <b>Kai Uwe \
Broulik</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="https://git.reviewboard.kde.org/r/123164/diff/3/?file=357173#file357173line38" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/applet/plugin/devicesproxymodel.h</a>  <span style="font-weight: \
normal;">

     (Diff revision 3)

    </span>
   </th>
  </tr>
 </thead>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">38</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  \
</tr>

 </tbody>

</table>

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">virtual ~DevicesProxyModel() = default; ?</p></pre>  </blockquote>

</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Isn't it the same as if there is no destructor at all?</p></pre> <br />

<p>- David</p>

<br />
<p>On March 29th, 2015, 5:18 p.m. UTC, David Rosca wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Bluedevil and Plasma.</div>
<div>By David Rosca.</div>

<p style="color: grey;"><i>Updated March 29, 2015, 5:18 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
bluedevil
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This is a replacement for bluedevil-monolithic. The \
code is based on network management plasmoid and it does basically the same but for \
Bluetooth devices.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I've been running it for some time already and it \
works fine.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: grey">(94b56fb)</span></li>

 <li>src/CMakeLists.txt <span style="color: grey">(b804f2b)</span></li>

 <li>src/applet/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/applet/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/applet/package/contents/code/logic.js <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/applet/package/contents/config/config.qml <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/applet/package/contents/config/main.xml <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/applet/package/contents/ui/BluetoothApplet.qml <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/applet/package/contents/ui/CompactRepresentation.qml <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/applet/package/contents/ui/ConfigGeneral.qml <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/applet/package/contents/ui/DeviceItem.qml <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/applet/package/contents/ui/FullRepresentation.qml <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/applet/package/contents/ui/Header.qml <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/applet/package/contents/ui/SwitchButton.qml <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/applet/package/contents/ui/Toolbar.qml <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/applet/package/metadata.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/applet/plugin/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/applet/plugin/bluetoothplugin.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/applet/plugin/bluetoothplugin.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/applet/plugin/devicesproxymodel.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/applet/plugin/devicesproxymodel.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/applet/plugin/launchapp.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/applet/plugin/launchapp.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/applet/plugin/notify.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/applet/plugin/notify.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/applet/plugin/qmldir <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/bluedevil.notifyrc <span style="color: grey">(72257ed)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/123164/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/03/28/acba4387-a4e7-4e77-830d-91dc5ed5c574__snapshot4.png">snapshot4.png</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/03/28/d0cab8ca-a62b-4672-9600-cbd61de25c63__snapshot5.png">snapshot5.png</a></li>

</ul>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============6618112539203639862==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 