[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 123164: Add new Bluetooth applet
From: "David Edmundson" <david () davidedmundson ! co ! uk>
Date: 2015-03-29 12:13:21
Message-ID: 20150329121321.1187.18059 () mimi ! kde ! org
[Download RAW message or body]
--===============8758320948544360769==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123164/#review78160
-----------------------------------------------------------
src/applet/package/contents/ui/CompactRepresentation.qml (line 34)
<https://git.reviewboard.kde.org/r/123164/#comment53541>
you should be able to just anchors.fill: parent
and icon item will do the right thing finding the iconsize and centering it.
src/applet/package/contents/ui/Header.qml (line 42)
<https://git.reviewboard.kde.org/r/123164/#comment53549>
set left, right anchors and set eliding
otherwise a long name is just going to leak out the box
src/applet/package/contents/ui/SwitchButton.qml (line 1)
<https://git.reviewboard.kde.org/r/123164/#comment53546>
is this a direct copy from nm-qt?
Maybe we could put it in plasmaextras?
src/applet/package/contents/ui/SwitchButton.qml (line 42)
<https://git.reviewboard.kde.org/r/123164/#comment53547>
units.smallSpacing
src/applet/package/contents/ui/SwitchButton.qml (line 46)
<https://git.reviewboard.kde.org/r/123164/#comment53548>
bottomMargin, topMargin are both unused in this case
src/applet/package/contents/ui/Toolbar.qml (lines 84 - 87)
<https://git.reviewboard.kde.org/r/123164/#comment53545>
Kai/Bhushan there's an existing import that does this right?
src/applet/plugin/devicesproxymodel.cpp (line 70)
<https://git.reviewboard.kde.org/r/123164/#comment53544>
micro optimise:
fetch the names after you compare if connected differs
- David Edmundson
On March 28, 2015, 7:43 p.m., David Rosca wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123164/
> -----------------------------------------------------------
>
> (Updated March 28, 2015, 7:43 p.m.)
>
>
> Review request for Bluedevil and Plasma.
>
>
> Repository: bluedevil
>
>
> Description
> -------
>
> This is a replacement for bluedevil-monolithic.
> The code is based on network management plasmoid and it does basically the same but \
> for Bluetooth devices.
>
> Diffs
> -----
>
> CMakeLists.txt 94b56fb
> src/CMakeLists.txt b804f2b
> src/applet/CMakeLists.txt PRE-CREATION
> src/applet/Messages.sh PRE-CREATION
> src/applet/package/contents/code/logic.js PRE-CREATION
> src/applet/package/contents/config/config.qml PRE-CREATION
> src/applet/package/contents/config/main.xml PRE-CREATION
> src/applet/package/contents/ui/BluetoothApplet.qml PRE-CREATION
> src/applet/package/contents/ui/CompactRepresentation.qml PRE-CREATION
> src/applet/package/contents/ui/ConfigGeneral.qml PRE-CREATION
> src/applet/package/contents/ui/DeviceItem.qml PRE-CREATION
> src/applet/package/contents/ui/FullRepresentation.qml PRE-CREATION
> src/applet/package/contents/ui/Header.qml PRE-CREATION
> src/applet/package/contents/ui/SwitchButton.qml PRE-CREATION
> src/applet/package/contents/ui/Toolbar.qml PRE-CREATION
> src/applet/package/metadata.desktop PRE-CREATION
> src/applet/plugin/CMakeLists.txt PRE-CREATION
> src/applet/plugin/bluetoothplugin.h PRE-CREATION
> src/applet/plugin/bluetoothplugin.cpp PRE-CREATION
> src/applet/plugin/devicesproxymodel.h PRE-CREATION
> src/applet/plugin/devicesproxymodel.cpp PRE-CREATION
> src/applet/plugin/launchapp.h PRE-CREATION
> src/applet/plugin/launchapp.cpp PRE-CREATION
> src/applet/plugin/notify.h PRE-CREATION
> src/applet/plugin/notify.cpp PRE-CREATION
> src/applet/plugin/qmldir PRE-CREATION
> src/bluedevil.notifyrc 72257ed
>
> Diff: https://git.reviewboard.kde.org/r/123164/diff/
>
>
> Testing
> -------
>
> I've been running it for some time already and it works fine.
>
>
> File Attachments
> ----------------
>
> snapshot4.png
> https://git.reviewboard.kde.org/media/uploaded/files/2015/03/28/acba4387-a4e7-4e77-830d-91dc5ed5c574__snapshot4.png
> snapshot5.png
> https://git.reviewboard.kde.org/media/uploaded/files/2015/03/28/d0cab8ca-a62b-4672-9600-cbd61de25c63__snapshot5.png
>
>
> Thanks,
>
> David Rosca
>
>
--===============8758320948544360769==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123164/">https://git.reviewboard.kde.org/r/123164/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/123164/diff/1/?file=357004#file357004line34" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/applet/package/contents/ui/CompactRepresentation.qml</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">34</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">anchors.centerIn:</span> <span class="nx">parent</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">you \
should be able to just anchors.fill: parent</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">and icon item will do \
the right thing finding the iconsize and centering it.</p></pre> </div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/123164/diff/1/?file=357008#file357008line42" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/applet/package/contents/ui/Header.qml</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">42</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="k">horizontalCenter:</span> <span class="nx">parent</span><span \
class="p">.</span><span class="nx">horizontalCenter</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">set \
left, right anchors and set eliding</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">otherwise a long name \
is just going to leak out the box</p></pre> </div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/123164/diff/1/?file=357009#file357009line1" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/applet/package/contents/ui/SwitchButton.qml</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">1</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="cm">/*</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">is \
this a direct copy from nm-qt?</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Maybe we could put it \
in plasmaextras?</p></pre> </div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/123164/diff/1/?file=357009#file357009line42" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/applet/package/contents/ui/SwitchButton.qml</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">42</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="k">bottomMargin:</span> <span class="nb">Math</span><span \
class="p">.</span><span class="nx">round</span><span class="p">(</span><span \
class="nx">units</span><span class="p">.</span><span class="nx">gridUnit</span> <span \
class="o">/</span> <span class="mi">3</span><span class="p">)</span></pre></td> \
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">units.smallSpacing</p></pre> </div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/123164/diff/1/?file=357009#file357009line46" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/applet/package/contents/ui/SwitchButton.qml</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">46</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="k">verticalCenter:</span> <span class="nx">parent</span><span \
class="p">.</span><span class="nx">verticalCenter</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">bottomMargin, topMargin are both unused in this case</p></pre> </div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/123164/diff/1/?file=357010#file357010line84" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/applet/package/contents/ui/Toolbar.qml</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">84</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="k">onClicked:</span> <span class="p">{</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">85</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="kd">var</span> <span class="nx">args</span> <span class="o">=</span> \
<span class="p">[</span> <span class="s2">"bluedevildevices"</span><span \
class="p">,</span> <span class="s2">"bluedeviltransfer"</span><span \
class="p">,</span> <span class="s2">"bluedeviladapters"</span> <span \
class="p">];</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">86</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="nx">appLauncher</span><span class="p">.</span><span \
class="nx">runCommand</span><span class="p">(</span><span \
class="s2">"kcmshell5"</span><span class="p">,</span> <span \
class="nx">args</span><span class="p">);</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">87</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="p">}</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Kai/Bhushan there's an existing import that does this right?</p></pre> \
</div> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/123164/diff/1/?file=357016#file357016line70" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/applet/plugin/devicesproxymodel.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">70</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">const</span> <span class="n">QString</span> <span class="n">leftName</span> \
<span class="o">=</span> <span class="n">left</span><span class="p">.</span><span \
class="n">data</span><span class="p">(</span><span class="n">BluezQt</span><span \
class="o">::</span><span class="n">DevicesModel</span><span class="o">::</span><span \
class="n">NameRole</span><span class="p">).</span><span \
class="n">toString</span><span class="p">();</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">micro \
optimise:</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">fetch the names after you compare if connected \
differs</p></pre> </div>
</div>
<br />
<p>- David Edmundson</p>
<br />
<p>On March 28th, 2015, 7:43 p.m. UTC, David Rosca wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Bluedevil and Plasma.</div>
<div>By David Rosca.</div>
<p style="color: grey;"><i>Updated March 28, 2015, 7:43 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
bluedevil
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This is a replacement for bluedevil-monolithic. The \
code is based on network management plasmoid and it does basically the same but for \
Bluetooth devices.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I've been running it for some time already and it \
works fine.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(94b56fb)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(b804f2b)</span></li>
<li>src/applet/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/applet/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/applet/package/contents/code/logic.js <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/applet/package/contents/config/config.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/applet/package/contents/config/main.xml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/applet/package/contents/ui/BluetoothApplet.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/applet/package/contents/ui/CompactRepresentation.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/applet/package/contents/ui/ConfigGeneral.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/applet/package/contents/ui/DeviceItem.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/applet/package/contents/ui/FullRepresentation.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/applet/package/contents/ui/Header.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/applet/package/contents/ui/SwitchButton.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/applet/package/contents/ui/Toolbar.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/applet/package/metadata.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/applet/plugin/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/applet/plugin/bluetoothplugin.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/applet/plugin/bluetoothplugin.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/applet/plugin/devicesproxymodel.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/applet/plugin/devicesproxymodel.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/applet/plugin/launchapp.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/applet/plugin/launchapp.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/applet/plugin/notify.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/applet/plugin/notify.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/applet/plugin/qmldir <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/bluedevil.notifyrc <span style="color: grey">(72257ed)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123164/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/03/28/acba4387-a4e7-4e77-830d-91dc5ed5c574__snapshot4.png">snapshot4.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/03/28/d0cab8ca-a62b-4672-9600-cbd61de25c63__snapshot5.png">snapshot5.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============8758320948544360769==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic