[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 123171: Fix opening ksysguarddrc config file
From: "David Edmundson" <david () davidedmundson ! co ! uk>
Date: 2015-03-29 11:58:32
Message-ID: 20150329115832.1187.46002 () mimi ! kde ! org
[Download RAW message or body]
--===============5899281521627789738==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123171/#review78163
-----------------------------------------------------------
ksysguardd/CMakeLists.txt (line 6)
<https://git.reviewboard.kde.org/r/123171/#comment53543>
from what I understand of the ECM docs, this is a deprecated variable
and we should use
KDE_INSTALL_FULL_SYSCONFDIR instead
which will also fix the problem.
- David Edmundson
On March 29, 2015, 11:47 a.m., David Rosca wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123171/
> -----------------------------------------------------------
>
> (Updated March 29, 2015, 11:47 a.m.)
>
>
> Review request for Plasma and John Tapsell.
>
>
> Repository: ksysguard
>
>
> Description
> -------
>
> This fixes -DKSYSGUARDDRCFILE definition so that there are no extra quotes.
> It also fixes issue with using non-default install prefix (eg. when \
> CMAKE_INSTALL_PREFIX is not /usr and thus SYSCONF_INSTALL_DIR is relative and not \
> /etc)
>
> Diffs
> -----
>
> ksysguardd/CMakeLists.txt 6bd8679
>
> Diff: https://git.reviewboard.kde.org/r/123171/diff/
>
>
> Testing
> -------
>
> No error in syslog after applying this patch: cannot open config file \
> '"etc/ksysguarddrc"'
>
> Thanks,
>
> David Rosca
>
>
--===============5899281521627789738==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123171/">https://git.reviewboard.kde.org/r/123171/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/123171/diff/1/?file=357107#file357107line6" \
style="color: black; font-weight: bold; text-decoration: \
underline;">ksysguardd/CMakeLists.txt</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">6</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="nb">add_definitions</span><span class="p">(</span> <span \
class="s">-DKSYSGUARDDRCFILE=</span><span class="s2">"\\"</span><span \
class="o">${</span><span class="nv">SYSCONF_INSTALL_DIR</span><span \
class="o">}</span><span class="s">/ksysguarddrc\\</span><span \
class="s2">""</span> <span class="p">)</span></pre></td> <th \
bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">6</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="nb">if</span><span class="p">(</span> <span class="s">IS_ABSOLUTE</span> <span \
class="o">${</span><span class="nv">SYSCONF_INSTALL_DIR</span><span \
class="o">}</span> <span class="p">)</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">from \
what I understand of the ECM docs, this is a deprecated variable</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">and we should use KDE_INSTALL_FULL_SYSCONFDIR instead</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">which will also fix the problem.</p></pre> </div>
</div>
<br />
<p>- David Edmundson</p>
<br />
<p>On March 29th, 2015, 11:47 a.m. UTC, David Rosca wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma and John Tapsell.</div>
<div>By David Rosca.</div>
<p style="color: grey;"><i>Updated March 29, 2015, 11:47 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ksysguard
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This fixes -DKSYSGUARDDRCFILE definition so that there \
are no extra quotes. It also fixes issue with using non-default install prefix (eg. \
when CMAKE_INSTALL_PREFIX is not /usr and thus SYSCONF_INSTALL_DIR is relative and \
not /etc)</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">No error in syslog after applying this patch: cannot \
open config file '"etc/ksysguarddrc"'</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ksysguardd/CMakeLists.txt <span style="color: grey">(6bd8679)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123171/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============5899281521627789738==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic