[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 123161: Add copy and paste support for calculator widget
From: "David Edmundson" <david () davidedmundson ! co ! uk>
Date: 2015-03-28 13:04:43
Message-ID: 20150328130443.17385.7515 () mimi ! kde ! org
[Download RAW message or body]
--===============6706986698790040436==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On March 27, 2015, 11:46 p.m., David Edmundson wrote:
> > applets/calculator/package/contents/ui/calculator.qml, line 220
> > <https://git.reviewboard.kde.org/r/123161/diff/1/?file=356978#file356978line220>
> >
> > I'm not convinced this is going to work.
> >
> > You'll update the display, but all the handling of storing what number is entered \
> > handles in the key press events.
> > Can you try pasting "5" then typing '+' and '1'
> > and see what happens.
> >
> > I think it will then show 1, not 6.
>
> Bernhard Friedreich wrote:
> you are right - this doesn't work.. slipped my testing somehow..
> should I iterate over every character of the clipboard and call displayNumber for \
> each? Would reuse the existing codepath..
I think it's our only option.
> On March 27, 2015, 11:46 p.m., David Edmundson wrote:
> > applets/calculator/package/contents/ui/calculator.qml, line 95
> > <https://git.reviewboard.kde.org/r/123161/diff/1/?file=356978#file356978line95>
> >
> > avoid guessing what the shortcut is.
> >
> > Otherwise if someone maps it to alt in their settings it won't work. Or if \
> > someone has a dvorak layout it won't be c and v.
> >
> > Use
> >
> > if event.matches(StandardKey.Copy)
> > http://doc.qt.io/qt-5/qml-qtquick-keyevent.html#matches-method
> >
> > internally this will ask our QPT plugin which loads things from a KDE config \
> > file.
>
> Bernhard Friedreich wrote:
> I had already found this before but the clipboard plasmoid was doing it like this \
> so I thought this was the prefered way - makes sense and is more readable. Thanks \
> :)
Urgh. It won't for much longer.
Thanks for pointing that out
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123161/#review78129
-----------------------------------------------------------
On March 27, 2015, 11:21 p.m., Bernhard Friedreich wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123161/
> -----------------------------------------------------------
>
> (Updated March 27, 2015, 11:21 p.m.)
>
>
> Review request for Plasma.
>
>
> Bugs: 318221
> http://bugs.kde.org/show_bug.cgi?id=318221
>
>
> Repository: kdeplasma-addons
>
>
> Description
> -------
>
> The current displayed value from the textfield can be copied.
> Content from the clipboard can be pasted but only if the content
> is a valid number
>
> BUG: 318221
>
>
> Diffs
> -----
>
> applets/calculator/package/contents/ui/calculator.qml \
> 23f74bd1ac7de6b7f4519677bd96aa351a91cff1
> Diff: https://git.reviewboard.kde.org/r/123161/diff/
>
>
> Testing
> -------
>
> Copying:
> *) Tried copying entered numbers and results - works for me :)
>
> Pasting:
> *) Pasting "asdf" leads to nothing being pasted - correct
> *) Pasting "5" pasts 5 - replaces the currently entered text with the pasted \
> content (this could be worked around - should it append?)
> *) Pasting "= 5 + 3" passes through validation - no idea why yet - this should be \
> possible I guess?
> Comments welcome :) This is my second patch so hopefully my work isn't complete \
> garbage :P
>
> Thanks,
>
> Bernhard Friedreich
>
>
--===============6706986698790040436==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123161/">https://git.reviewboard.kde.org/r/123161/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On March 27th, 2015, 11:46 p.m. UTC, <b>David \
Edmundson</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/123161/diff/1/?file=356978#file356978line95" \
style="color: black; font-weight: bold; text-decoration: \
underline;">applets/calculator/package/contents/ui/calculator.qml</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">95</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="k">if</span> <span class="p">(</span><span class="nx">event</span><span \
class="p">.</span><span class="nx">key</span> <span class="o">==</span> <span \
class="nx">Qt</span><span class="p">.</span><span class="nx">Key_C</span> <span \
class="o">&&</span> <span class="nx">event</span><span \
class="p">.</span><span class="nx">modifiers</span> <span class="o">&</span> \
<span class="nx">Qt</span><span class="p">.</span><span \
class="nx">ControlModifier</span><span class="p">)</span> <span \
class="p">{</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">avoid \
guessing what the shortcut is.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Otherwise if someone \
maps it to alt in their settings it won't work. Or if someone has a dvorak layout it \
won't be c and v.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Use</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">if \
event.matches(StandardKey.Copy) \
http://doc.qt.io/qt-5/qml-qtquick-keyevent.html#matches-method</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">internally this will ask our QPT plugin which loads things from a KDE \
config file.</p></pre> </blockquote>
<p>On March 28th, 2015, 12:51 p.m. UTC, <b>Bernhard Friedreich</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I had \
already found this before but the clipboard plasmoid was doing it like this so I \
thought this was the prefered way - makes sense and is more readable. Thanks \
:)</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Urgh. It won't for much longer. Thanks for pointing that out</p></pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On March 27th, 2015, 11:46 p.m. UTC, <b>David \
Edmundson</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/123161/diff/1/?file=356978#file356978line220" \
style="color: black; font-weight: bold; text-decoration: \
underline;">applets/calculator/package/contents/ui/calculator.qml</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">220</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="nx">display</span><span class="p">.</span><span \
class="nx">paste</span><span class="p">();</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm \
not convinced this is going to work.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">You'll update the \
display, but all the handling of storing what number is entered handles in the key \
press events.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Can you try pasting "5" then typing '+' and '1' and \
see what happens.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">I think it will then show 1, not \
6.</p></pre> </blockquote>
<p>On March 28th, 2015, 12:51 p.m. UTC, <b>Bernhard Friedreich</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">you are right - this \
doesn't work.. slipped my testing somehow.. should I iterate over every character \
of the clipboard and call displayNumber for each? Would reuse the existing \
codepath..</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">I think it's our only option.</p></pre> <br />
<p>- David</p>
<br />
<p>On March 27th, 2015, 11:21 p.m. UTC, Bernhard Friedreich wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Bernhard Friedreich.</div>
<p style="color: grey;"><i>Updated March 27, 2015, 11:21 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=318221">318221</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeplasma-addons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The current displayed value from the textfield can be copied. Content \
from the clipboard can be pasted but only if the content is a valid number
BUG: 318221</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Copying:
*) Tried copying entered numbers and results - works for me :)
Pasting:
*) Pasting "asdf" leads to nothing being pasted - correct
*) Pasting "5" pasts 5 - replaces the currently entered text with the \
pasted content (this could be worked around - should it append?)
*) Pasting "= 5 + 3" passes through validation - no idea why yet - this \
should be possible I guess?
Comments welcome :) This is my second patch so hopefully my work isn't complete \
garbage :P</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/calculator/package/contents/ui/calculator.qml <span style="color: \
grey">(23f74bd1ac7de6b7f4519677bd96aa351a91cff1)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123161/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6706986698790040436==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic