From kde-panel-devel Fri Mar 27 12:22:03 2015 From: "Bhushan Shah" Date: Fri, 27 Mar 2015 12:22:03 +0000 To: kde-panel-devel Subject: Re: Review Request 123136: Fix one pixel gap between screenedge and right placed vertical panel Message-Id: <20150327122203.17385.37806 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=142745893906386 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============4896332539113392849==" --===============4896332539113392849== Content-Type: multipart/alternative; boundary="===============3544066590753916111==" --===============3544066590753916111== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123136/ ----------------------------------------------------------- (Updated March 27, 2015, 12:22 p.m.) Status ------ This change has been marked as submitted. Review request for Plasma, Martin Gräßlin and Marco Martin. Changes ------- Submitted with commit 975e5009c176eb378daa5c8f74cd4cffb64ff459 by Bhushan Shah to branch master. Bugs: 339323 and 340549 https://bugs.kde.org/show_bug.cgi?id=339323 https://bugs.kde.org/show_bug.cgi?id=340549 Repository: plasma-workspace Description ------- Appearantly right() / bottomRight() / topRight() returns values with 1 pixel x off for historical reasons and hence 1px gap. This causes the autohide panel not hiding automatically. Diffs ----- shell/panelview.cpp 3435736 Diff: https://git.reviewboard.kde.org/r/123136/diff/ Testing ------- added right aligned panel and tested various combinations Thanks, Bhushan Shah --===============3544066590753916111== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123136/

This change has been marked as submitted.

Review request for Plasma, Martin Gräßlin and Marco Martin.

By Bhushan Shah.

Updated March 27, 2015, 12:22 p.m.

Changes

Submitted with commit 975e5009c176eb378daa5c8f74cd4cffb64ff459 by Bhushan Shah to branch master.

Bugs: 339323, 340549

Repository: plasma-workspace

Description

Appearantly right() / bottomRight() / topRight() returns values with 1
pixel x off for historical reasons and hence 1px gap. This causes the
autohide panel not hiding automatically.

Testing

added right aligned panel and tested various combinations

Diffs

shell/panelview.cpp (3435736)

View Diff

--===============3544066590753916111==-- --===============4896332539113392849== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============4896332539113392849==--