[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 123136: Fix one pixel gap between screenedge and right placed vertical panel
From: "Bhushan Shah" <bhush94 () gmail ! com>
Date: 2015-03-27 12:02:52
Message-ID: 20150327120252.17385.36529 () mimi ! kde ! org
[Download RAW message or body]
--===============1433203070022917810==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On March 26, 2015, 10:29 p.m., David Edmundson wrote:
> > shell/panelview.cpp, line 433
> > <https://git.reviewboard.kde.org/r/123136/diff/1/?file=356709#file356709line433>
> >
> > and here.
topLeft is fine.. it is not affected
> On March 26, 2015, 10:29 p.m., David Edmundson wrote:
> > shell/panelview.cpp, line 443
> > <https://git.reviewboard.kde.org/r/123136/diff/1/?file=356709#file356709line443>
> >
> > and here?
bottomLeft is fine, in general anythingLeft is fine.
- Bhushan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123136/#review78069
-----------------------------------------------------------
On March 26, 2015, 10:11 p.m., Bhushan Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123136/
> -----------------------------------------------------------
>
> (Updated March 26, 2015, 10:11 p.m.)
>
>
> Review request for Plasma, Martin Gräßlin and Marco Martin.
>
>
> Bugs: 339323 and 340549
> https://bugs.kde.org/show_bug.cgi?id=339323
> https://bugs.kde.org/show_bug.cgi?id=340549
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> Appearantly right() / bottomRight() / topRight() returns values with 1
> pixel x off for historical reasons and hence 1px gap. This causes the
> autohide panel not hiding automatically.
>
>
> Diffs
> -----
>
> shell/panelview.cpp 3435736
>
> Diff: https://git.reviewboard.kde.org/r/123136/diff/
>
>
> Testing
> -------
>
> added right aligned panel and tested various combinations
>
>
> Thanks,
>
> Bhushan Shah
>
>
--===============1433203070022917810==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123136/">https://git.reviewboard.kde.org/r/123136/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On March 26th, 2015, 10:29 p.m. IST, <b>David \
Edmundson</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/123136/diff/1/?file=356709#file356709line433" \
style="color: black; font-weight: bold; text-decoration: \
underline;">shell/panelview.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QRect \
PanelView::geometryByDistance(int distance) const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">433</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">position</span> <span class="o">=</span> <span class="n">QPoint</span><span \
class="p">(</span><span class="n">s</span><span class="o">-></span><span \
class="n">geometry</span><span class="p">().</span><span \
class="n">topLeft</span><span class="p">()</span> <span class="o">+</span> <span \
class="n">QPoint</span><span class="p">(</span><span class="n">m_offset</span><span \
class="p">,</span> <span class="n">distance</span><span \
class="p">));</span></pre></td> <th bgcolor="#f0f0f0" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">433</font></th> <td bgcolor="#ffffff" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="n">position</span> \
<span class="o">=</span> <span class="n">QPoint</span><span class="p">(</span><span \
class="n">s</span><span class="o">-></span><span class="n">geometry</span><span \
class="p">().</span><span class="n">topLeft</span><span class="p">()</span> <span \
class="o">+</span> <span class="n">QPoint</span><span class="p">(</span><span \
class="n">m_offset</span><span class="p">,</span> <span \
class="n">distance</span><span class="p">));</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">and \
here.</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">topLeft is fine.. it is not affected</p></pre> <br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On March 26th, 2015, 10:29 p.m. IST, <b>David \
Edmundson</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/123136/diff/1/?file=356709#file356709line443" \
style="color: black; font-weight: bold; text-decoration: \
underline;">shell/panelview.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QRect \
PanelView::geometryByDistance(int distance) const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">443</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">position</span> <span class="o">=</span> <span class="n">QPoint</span><span \
class="p">(</span><span class="n">s</span><span class="o">-></span><span \
class="n">geometry</span><span class="p">().</span><span \
class="n">bottomLeft</span><span class="p">()</span> <span class="o">-</span> <span \
class="n">QPoint</span><span class="p">(</span><span class="n">distance</span><span \
class="p">,</span> <span class="n">m_offset</span> <span class="o">+</span> <span \
class="n">size</span><span class="p">().</span><span class="n">height</span><span \
class="p">()));</span></pre></td> <th bgcolor="#f0f0f0" style="border-left: 1px \
solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">443</font></th> <td bgcolor="#ffffff" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="n">position</span> \
<span class="o">=</span> <span class="n">QPoint</span><span class="p">(</span><span \
class="n">s</span><span class="o">-></span><span class="n">geometry</span><span \
class="p">().</span><span class="n">bottomLeft</span><span class="p">()</span> <span \
class="o">-</span> <span class="n">QPoint</span><span class="p">(</span><span \
class="n">distance</span><span class="p">,</span> <span class="n">m_offset</span> \
<span class="o">+</span> <span class="n">size</span><span class="p">().</span><span \
class="n">height</span><span class="p">()));</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">and \
here?</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">bottomLeft is fine, in general anythingLeft is fine.</p></pre> <br />
<p>- Bhushan</p>
<br />
<p>On March 26th, 2015, 10:11 p.m. IST, Bhushan Shah wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma, Martin Gräßlin and Marco Martin.</div>
<div>By Bhushan Shah.</div>
<p style="color: grey;"><i>Updated March 26, 2015, 10:11 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=339323">339323</a>,
<a href="https://bugs.kde.org/show_bug.cgi?id=340549">340549</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Appearantly right() / bottomRight() / topRight() \
returns values with 1 pixel x off for historical reasons and hence 1px gap. This \
causes the autohide panel not hiding automatically.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">added right aligned panel and tested various \
combinations</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>shell/panelview.cpp <span style="color: grey">(3435736)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123136/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1433203070022917810==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic