[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 122859: WIP: Don't animate from previous pixmap when IconItem has been invisible
From: "Eike Hein" <hein () kde ! org>
Date: 2015-03-26 18:10:08
Message-ID: 20150326181008.17385.58444 () mimi ! kde ! org
[Download RAW message or body]
--===============4620377056567800575==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On March 14, 2015, 10:29 p.m., Eike Hein wrote:
> > > @Eike: Could you check whether this makes it more viable for Kicker?
> >
> > Will do tomorrow. Might make it _more_ viable, but probably not viable \
> > yet - the other problem is that Kicker really wants to disable the \
> > blend tween completely, because it works very hard to reuse existing \
> > delegate instances when you switch categories. That is, when you move \
> > from one category to another and they differ in size, delegates may be \
> > created or destroyed as needed to fit the new size, but existing ones \
> > are reused and just handed new data. Since the text labels don't blend \
> > it's awkward when the icons do, and also generally makes things feel \
> > too slow.
>
> Eike Hein wrote:
> Tried it now - initial appearance seems fine, but the crossblends during \
> category moves are still the expected problem (they don't even start at \
> the same time, so ... really ugly).
Nope, doesn't help with bug 345545.
- Eike
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122859/#review77482
-----------------------------------------------------------
On March 14, 2015, 2:53 p.m., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122859/
> -----------------------------------------------------------
>
> (Updated March 14, 2015, 2:53 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> We have a lot of reusable singletons that are just hidden when unneeded \
> (tooltip, osd). IconItem, however, will always fade from the previous \
> state, even if the previous action happened minutes ago.
> This patch makes it track its visibility and skip the fade-and-wait dance \
> when it just became visible. It also removes a visible false call in the \
> tooltip which I didn't know what it was for. (With it in place, the \
> IconItem always becomes visible when moving between tooltip areas, \
> breaking the animation altogether).
> @Eike: Could you check whether this makes it more viable for Kicker?
>
>
> Diffs
> -----
>
> src/declarativeimports/core/iconitem.h 3ef0306
> src/declarativeimports/core/iconitem.cpp d653bf3
> src/declarativeimports/core/tooltip.cpp 40e0af5
>
> Diff: https://git.reviewboard.kde.org/r/122859/diff/
>
>
> Testing
> -------
>
> Moving between tray icons - icon fades, moving reaaaally rapidly causes \
> it not to load any icon until you halt (dunno if that happened before but \
> doesn't seem too bad) Hovering tray icon, leaving, waiting, hovering \
> another one - icon does not fade, is there right away
> There is an issue with the OSD where it would not fade at all anymore \
> when changing states (eg. change volume, then screen brightness), only on \
> the first invocation, hence the "WIP" badge.
>
> Thanks,
>
> Kai Uwe Broulik
>
>
--===============4620377056567800575==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: \
1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122859/">https://git.reviewboard.kde.org/r/122859/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;"> <p style="margin-top: 0;">On March 14th, 2015, 10:29 \
p.m. UTC, <b>Eike Hein</b> wrote:</p> <blockquote style="margin-left: 1em; \
border-left: 2px solid #d0d0d0; padding-left: 10px;"> <pre \
style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><blockquote \
style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid \
#bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;"> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">@Eike: Could you check whether this makes it \
more viable for Kicker?</p> </blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Will do tomorrow. Might make it <em \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;">more</em> viable, but probably not viable yet \
- the other problem is that Kicker really wants to disable the blend tween \
completely, because it works very hard to reuse existing delegate instances \
when you switch categories. That is, when you move from one category to \
another and they differ in size, delegates may be created or destroyed as \
needed to fit the new size, but existing ones are reused and just handed \
new data. Since the text labels don't blend it's awkward when the icons do, \
and also generally makes things feel too slow.</p></pre> </blockquote>
<p>On March 26th, 2015, 1:04 p.m. UTC, <b>Eike Hein</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Tried it now - initial \
appearance seems fine, but the crossblends during category moves are still \
the expected problem (they don't even start at the same time, so ... really \
ugly).</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Nope, doesn't help with bug \
345545.</p></pre> <br />
<p>- Eike</p>
<br />
<p>On March 14th, 2015, 2:53 p.m. UTC, Kai Uwe Broulik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" \
style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: \
6px; -webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated March 14, 2015, 2:53 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">We have a lot of reusable \
singletons that are just hidden when unneeded (tooltip, osd). IconItem, \
however, will always fade from the previous state, even if the previous \
action happened minutes ago.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch \
makes it track its visibility and skip the fade-and-wait dance when it just \
became visible. It also removes a visible false call in the tooltip which I \
didn't know what it was for. (With it in place, the IconItem always becomes \
visible when moving between tooltip areas, breaking the animation \
altogether).</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">@Eike: Could you check \
whether this makes it more viable for Kicker?</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Moving between tray icons - \
icon fades, moving reaaaally rapidly causes it not to load any icon until \
you halt (dunno if that happened before but doesn't seem too bad) Hovering \
tray icon, leaving, waiting, hovering another one - icon does not fade, is \
there right away</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">There is an issue with the \
OSD where it would not fade at all anymore when changing states (eg. change \
volume, then screen brightness), only on the first invocation, hence the \
"WIP" badge.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>src/declarativeimports/core/iconitem.h <span style="color: \
grey">(3ef0306)</span></li>
<li>src/declarativeimports/core/iconitem.cpp <span style="color: \
grey">(d653bf3)</span></li>
<li>src/declarativeimports/core/tooltip.cpp <span style="color: \
grey">(40e0af5)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122859/diff/" \
style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4620377056567800575==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic