'Re: Review Request 123124: Display an instance of the grey login strip in the sddm theme on every sc'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 123124: Display an instance of the grey login strip in the sddm theme on every sc
From:       "David Kahles" <david.kahles96 () gmail ! com>
Date:       2015-03-26 15:59:36
Message-ID: 20150326155936.17385.37030 () mimi ! kde ! org
[Download RAW message or body]

--===============3059272797001219086==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123124/
-----------------------------------------------------------

(Updated March 26, 2015, 3:59 p.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma.

Changes
-------

Submitted with commit 1985e8bf6bbc6044bd5ffac3c1b501536f2d1dd2 by David Edmundson on \
behalf of David Kahles to branch master.

Repository: plasma-workspace

Description
-------

Display the grey login strip in sddm on every screen separated instead
of displaying one strip that goes over all screens.
The latter could result in a password promt or user selection that is
subdivided into two parts on two screens.
This commit displays the strip on every screen (like the background
image) so it won't be subdivided anymore.

Diffs
-----

  lookandfeel/contents/loginmanager/Main.qml edabd0c6eac1fbc038208010cc6c772acc735105 \
  lookandfeel/contents/loginmanager/dummydata/screenModel.qml PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/123124/diff/

Testing
-------

Using sddm and the breeze theme with one and two monitors attached.

Thanks,

David Kahles

--===============3059272797001219086==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/123124/">https://git.reviewboard.kde.org/r/123124/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By David Kahles.</div>

<p style="color: grey;"><i>Updated March 26, 2015, 3:59 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 1985e8bf6bbc6044bd5ffac3c1b501536f2d1dd2 by David \
Edmundson on behalf of David Kahles to branch master.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Display the grey login strip in sddm on every screen \
separated instead of displaying one strip that goes over all screens.
The latter could result in a password promt or user selection that is
subdivided into two parts on two screens.
This commit displays the strip on every screen (like the background
image) so it won't be subdivided anymore.</p></pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Using sddm and the breeze theme with one and two \
monitors attached.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>lookandfeel/contents/loginmanager/Main.qml <span style="color: \
grey">(edabd0c6eac1fbc038208010cc6c772acc735105)</span></li>

 <li>lookandfeel/contents/loginmanager/dummydata/screenModel.qml <span style="color: \
grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/123124/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============3059272797001219086==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 